rename developer_credential_timeout to process_timeout (Azure#30308)

Author: xiangyan99

sdk/identity/azure-identity/azure/identity/_credentials/default.py

@@ -82,7 +82,7 @@ class DefaultAzureCredential(ChainedTokenCredential):
         :class:`~azure.identity.VisualStudioCodeCredential`. Defaults to the "Azure: Tenant" setting in VS Code's user
         settings or, when that setting has no value, the "organizations" tenant, which supports only Azure Active
         Directory work or school accounts.
-    :keyword int developer_credential_timeout: The timeout in seconds to use for developer credentials that run
+    :keyword int process_timeout: The timeout in seconds to use for developer credentials that run
         subprocesses (e.g. AzureCliCredential, AzurePowerShellCredential). Defaults to **10** seconds.
 
     .. admonition:: Example:
@@ -129,7 +129,7 @@ def __init__(self, **kwargs: Any) -> None:  # pylint: disable=too-many-statement
             "shared_cache_tenant_id", os.environ.get(EnvironmentVariables.AZURE_TENANT_ID)
         )
 
-        developer_credential_timeout = kwargs.pop("developer_credential_timeout", 10)
+        process_timeout = kwargs.pop("process_timeout", 10)
 
         exclude_workload_identity_credential = kwargs.pop("exclude_workload_identity_credential", False)
         exclude_environment_credential = kwargs.pop("exclude_environment_credential", False)
@@ -161,7 +161,7 @@ def __init__(self, **kwargs: Any) -> None:  # pylint: disable=too-many-statement
                 )
             )
         if not exclude_developer_cli_credential:
-            credentials.append(AzureDeveloperCliCredential(process_timeout=developer_credential_timeout))
+            credentials.append(AzureDeveloperCliCredential(process_timeout=process_timeout))
         if not exclude_shared_token_cache_credential and SharedTokenCacheCredential.supported():
             try:
                 # username and/or tenant_id are only required when the cache contains tokens for multiple identities
@@ -174,9 +174,9 @@ def __init__(self, **kwargs: Any) -> None:  # pylint: disable=too-many-statement
         if not exclude_visual_studio_code_credential:
             credentials.append(VisualStudioCodeCredential(**vscode_args))
         if not exclude_cli_credential:
-            credentials.append(AzureCliCredential(process_timeout=developer_credential_timeout))
+            credentials.append(AzureCliCredential(process_timeout=process_timeout))
         if not exclude_powershell_credential:
-            credentials.append(AzurePowerShellCredential(process_timeout=developer_credential_timeout))
+            credentials.append(AzurePowerShellCredential(process_timeout=process_timeout))
         if not exclude_interactive_browser_credential:
             if interactive_browser_client_id:
                 credentials.append(

sdk/identity/azure-identity/azure/identity/aio/_credentials/default.py

@@ -74,7 +74,7 @@ class DefaultAzureCredential(ChainedTokenCredential):
         :class:`~azure.identity.aio.VisualStudioCodeCredential`. Defaults to the "Azure: Tenant" setting in VS Code's
         user settings or, when that setting has no value, the "organizations" tenant, which supports only Azure Active
         Directory work or school accounts.
-    :keyword int developer_credential_timeout: The timeout in seconds to use for developer credentials that run
+    :keyword int process_timeout: The timeout in seconds to use for developer credentials that run
         subprocesses (e.g. AzureCliCredential, AzurePowerShellCredential). Defaults to **10** seconds.
 
     .. admonition:: Example:
@@ -120,7 +120,7 @@ def __init__(self, **kwargs: Any) -> None:
             "visual_studio_code_tenant_id", os.environ.get(EnvironmentVariables.AZURE_TENANT_ID)
         )
 
-        developer_credential_timeout = kwargs.pop("developer_credential_timeout", 10)
+        process_timeout = kwargs.pop("process_timeout", 10)
 
         exclude_workload_identity_credential = kwargs.pop("exclude_workload_identity_credential", False)
         exclude_visual_studio_code_credential = kwargs.pop("exclude_visual_studio_code_credential", True)
@@ -151,7 +151,7 @@ def __init__(self, **kwargs: Any) -> None:
                 )
             )
         if not exclude_developer_cli_credential:
-            credentials.append(AzureDeveloperCliCredential(process_timeout=developer_credential_timeout))
+            credentials.append(AzureDeveloperCliCredential(process_timeout=process_timeout))
         if not exclude_shared_token_cache_credential and SharedTokenCacheCredential.supported():
             try:
                 # username and/or tenant_id are only required when the cache contains tokens for multiple identities
@@ -164,9 +164,9 @@ def __init__(self, **kwargs: Any) -> None:
         if not exclude_visual_studio_code_credential:
             credentials.append(VisualStudioCodeCredential(**vscode_args))
         if not exclude_cli_credential:
-            credentials.append(AzureCliCredential(process_timeout=developer_credential_timeout))
+            credentials.append(AzureCliCredential(process_timeout=process_timeout))
         if not exclude_powershell_credential:
-            credentials.append(AzurePowerShellCredential(process_timeout=developer_credential_timeout))
+            credentials.append(AzurePowerShellCredential(process_timeout=process_timeout))
 
         super().__init__(*credentials)
 

sdk/identity/azure-identity/tests/test_default.py

@@ -374,22 +374,22 @@ def validate_client_id(credential):
     validate_client_id(mock_credential)
 
 
-def test_developer_credential_timeout():
+def test_process_timeout():
     """the credential should allow configuring a process timeout for Azure CLI and PowerShell by kwarg"""
 
     timeout = 42
 
     with patch(DefaultAzureCredential.__module__ + ".AzureCliCredential") as mock_cli_credential:
         with patch(DefaultAzureCredential.__module__ + ".AzurePowerShellCredential") as mock_pwsh_credential:
-            DefaultAzureCredential(developer_credential_timeout=timeout)
+            DefaultAzureCredential(process_timeout=timeout)
 
     for credential in (mock_cli_credential, mock_pwsh_credential):
         _, kwargs = credential.call_args
         assert "process_timeout" in kwargs
         assert kwargs["process_timeout"] == timeout
 
 
-def test_developer_credential_timeout_default():
+def test_process_timeout_default():
     """the credential should allow configuring a process timeout for Azure CLI and PowerShell by kwarg"""
 
     with patch(DefaultAzureCredential.__module__ + ".AzureCliCredential") as mock_cli_credential:

sdk/identity/azure-identity/tests/test_default_async.py

@@ -282,21 +282,21 @@ def get_credential_for_shared_cache_test(expected_refresh_token, expected_access
         return DefaultAzureCredential(_cache=cache, transport=transport, **exclude_other_credentials, **kwargs)
 
 
-def test_developer_credential_timeout():
+def test_process_timeout():
     """the credential should allow configuring a process timeout for Azure CLI and PowerShell by kwarg"""
 
     timeout = 42
 
     with patch(DefaultAzureCredential.__module__ + ".AzureCliCredential") as mock_cli_credential:
         with patch(DefaultAzureCredential.__module__ + ".AzurePowerShellCredential") as mock_pwsh_credential:
-            DefaultAzureCredential(developer_credential_timeout=timeout)
+            DefaultAzureCredential(process_timeout=timeout)
 
     for credential in (mock_cli_credential, mock_pwsh_credential):
         _, kwargs = credential.call_args
         assert "process_timeout" in kwargs
         assert kwargs["process_timeout"] == timeout
 
-def test_developer_credential_timeout():
+def test_process_timeout():
     """the credential should allow configuring a process timeout for Azure CLI and PowerShell by kwarg"""
 
     with patch(DefaultAzureCredential.__module__ + ".AzureCliCredential") as mock_cli_credential: