[ACS JobRouter] Enum discriminators for polymorphic base classes (Azure#33149)

* change discriminator type for polymorphic base classes + fix mypy issues

* regen code with 'stream' kwarg removed

* update assets.json

* more mypy fixes
- suppress mypy in samples

* manually update generated operations to return the (Async)ItemPaged[TEntity]

Author: sarkar-rajarshi

sdk/communication/azure-communication-jobrouter/CHANGELOG.md

@@ -55,6 +55,27 @@
   - Removed property `assignment_id`
 - `CompleteJobOptions`
   - Removed property `assignment_id`
+- `JobMatchingMode`
+  - Property `kind` - Changed from `str` to `JobMatchingModeKind`
+  - Affected derived classes: `QueueAndMatchMode`, `ScheduleAndSuspendMode`, `SuspendMode`
+- `RouterRule`
+  - Property `kind` - Changed from `str` to `RouterRuleKind`
+  - Affected derived classes: `DirectMapRouterRule`, `ExpressionRouterRule`, `FunctionRouterRule`, `StaticRouterRule`, `WebhookRouterRule`
+- `DistributionMode`
+  - Property `kind` - Changed from `str` to `DistributionModeKind`
+  - Affected derived classes: `RoundRobinMode`, `LongestIdleMode`, `BestWorkerMode`
+- `ExceptionTrigger`
+  - Property `kind` - Changed from `str` to `ExceptionTriggerKind`
+  - Affected derived classes: `QueueLengthExceptionTrigger`, `WaitTimeExceptionTrigger`
+- `ExceptionAction`
+  - Property `kind` - Changed from `str` to `ExceptionActionKind`
+  - Affected derived classes: `CancelExceptionAction`, `ManualReclassifyExceptionAction`, `ReclassifyExceptionAction`
+- `QueueSelectorAttachment`
+  - Property `kind` - Changed from `str` to `QueueSelectorAttachmentKind`
+  - Affected derived classes: `ConditionalQueueSelectorAttachment`, `PassThroughQueueSelectorAttachment`, `RuleEngineQueueSelectorAttachment`, `StaticQueueSelectorAttachment`, `WeightedAllocationQueueSelectorAttachment`
+- `WorkerSelectorAttachment`
+  - Property `kind` - Changed from `str` to `WorkerSelectorAttachmentKind`
+  - Affected derived classes: `ConditionalWorkerSelectorAttachment`, `PassThroughWorkerSelectorAttachment`, `RuleEngineWorkerSelectorAttachment`, `StaticWorkerSelectorAttachment`, `WeightedAllocationWorkerSelectorAttachment`
 
 #### Renames
 - `ChannelConfiguration` -> `RouterChannel`

sdk/communication/azure-communication-jobrouter/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "python",
   "TagPrefix": "python/communication/azure-communication-jobrouter",
-  "Tag": "python/communication/azure-communication-jobrouter_40b4f337cd"
+  "Tag": "python/communication/azure-communication-jobrouter_19ef87bca3"
 }

sdk/communication/azure-communication-jobrouter/azure/communication/jobrouter/__init__.py

@@ -6,8 +6,8 @@
 # Changes may cause incorrect behavior and will be lost if the code is regenerated.
 # --------------------------------------------------------------------------
 
-from ._client import JobRouterAdministrationClient
-from ._client import JobRouterClient
+from ._patch import JobRouterAdministrationClient
+from ._patch import JobRouterClient
 from ._version import VERSION
 
 __version__ = VERSION

sdk/communication/azure-communication-jobrouter/azure/communication/jobrouter/_operations/__init__.py

@@ -6,8 +6,8 @@
 # Changes may cause incorrect behavior and will be lost if the code is regenerated.
 # --------------------------------------------------------------------------
 
-from ._operations import JobRouterAdministrationClientOperationsMixin
-from ._operations import JobRouterClientOperationsMixin
+from ._patch import JobRouterAdministrationClientOperationsMixin
+from ._patch import JobRouterClientOperationsMixin
 
 from ._patch import __all__ as _patch_all
 from ._patch import *  # pylint: disable=unused-wildcard-import

sdk/communication/azure-communication-jobrouter/azure/communication/jobrouter/_operations/_operations.py

@@ -10,7 +10,7 @@
 from io import IOBase
 import json
 import sys
-from typing import Any, Callable, Dict, IO, Iterable, List, Optional, TypeVar, Union, overload
+from typing import Any, Callable, Dict, IO, List, Optional, TypeVar, Union, overload
 import urllib.parse
 
 from azure.core import MatchConditions
@@ -1286,7 +1286,7 @@ def get_distribution_policy(self, distribution_policy_id: str, **kwargs: Any) ->
         return deserialized  # type: ignore
 
     @distributed_trace
-    def list_distribution_policies(self, **kwargs: Any) -> Iterable["_models.DistributionPolicy"]:
+    def list_distribution_policies(self, **kwargs: Any) -> ItemPaged["_models.DistributionPolicy"]:
         """Retrieves existing distribution policies.
 
         Retrieves existing distribution policies.
@@ -1383,8 +1383,6 @@ def delete_distribution_policy(  # pylint: disable=inconsistent-return-statement
 
         :param distribution_policy_id: The unique identifier of the policy. Required.
         :type distribution_policy_id: str
-        :keyword bool stream: Whether to stream the response of this operation. Defaults to False. You
-         will have to context manage the returned stream.
         :return: None
         :rtype: None
         :raises ~azure.core.exceptions.HttpResponseError:
@@ -1725,7 +1723,7 @@ def get_classification_policy(self, classification_policy_id: str, **kwargs: Any
         return deserialized  # type: ignore
 
     @distributed_trace
-    def list_classification_policies(self, **kwargs: Any) -> Iterable["_models.ClassificationPolicy"]:
+    def list_classification_policies(self, **kwargs: Any) -> ItemPaged["_models.ClassificationPolicy"]:
         """Retrieves existing classification policies.
 
         Retrieves existing classification policies.
@@ -1823,8 +1821,6 @@ def delete_classification_policy(  # pylint: disable=inconsistent-return-stateme
 
         :param classification_policy_id: Unique identifier of this policy. Required.
         :type classification_policy_id: str
-        :keyword bool stream: Whether to stream the response of this operation. Defaults to False. You
-         will have to context manage the returned stream.
         :return: None
         :rtype: None
         :raises ~azure.core.exceptions.HttpResponseError:
@@ -2165,7 +2161,7 @@ def get_exception_policy(self, exception_policy_id: str, **kwargs: Any) -> _mode
         return deserialized  # type: ignore
 
     @distributed_trace
-    def list_exception_policies(self, **kwargs: Any) -> Iterable["_models.ExceptionPolicy"]:
+    def list_exception_policies(self, **kwargs: Any) -> ItemPaged["_models.ExceptionPolicy"]:
         """Retrieves existing exception policies.
 
         Retrieves existing exception policies.
@@ -2262,8 +2258,6 @@ def delete_exception_policy(  # pylint: disable=inconsistent-return-statements
 
         :param exception_policy_id: The Id of the exception policy. Required.
         :type exception_policy_id: str
-        :keyword bool stream: Whether to stream the response of this operation. Defaults to False. You
-         will have to context manage the returned stream.
         :return: None
         :rtype: None
         :raises ~azure.core.exceptions.HttpResponseError:
@@ -2604,7 +2598,7 @@ def get_queue(self, queue_id: str, **kwargs: Any) -> _models.RouterQueue:
         return deserialized  # type: ignore
 
     @distributed_trace
-    def list_queues(self, **kwargs: Any) -> Iterable["_models.RouterQueue"]:
+    def list_queues(self, **kwargs: Any) -> ItemPaged["_models.RouterQueue"]:
         """Retrieves existing queues.
 
         Retrieves existing queues.
@@ -2699,8 +2693,6 @@ def delete_queue(self, queue_id: str, **kwargs: Any) -> None:  # pylint: disable
 
         :param queue_id: The Id of this queue. Required.
         :type queue_id: str
-        :keyword bool stream: Whether to stream the response of this operation. Defaults to False. You
-         will have to context manage the returned stream.
         :return: None
         :rtype: None
         :raises ~azure.core.exceptions.HttpResponseError:
@@ -3050,8 +3042,6 @@ def delete_job(self, job_id: str, **kwargs: Any) -> None:  # pylint: disable=inc
 
         :param job_id: The id of the job. Required.
         :type job_id: str
-        :keyword bool stream: Whether to stream the response of this operation. Defaults to False. You
-         will have to context manage the returned stream.
         :return: None
         :rtype: None
         :raises ~azure.core.exceptions.HttpResponseError:
@@ -3578,7 +3568,7 @@ def list_jobs(
         scheduled_before: Optional[datetime.datetime] = None,
         scheduled_after: Optional[datetime.datetime] = None,
         **kwargs: Any
-    ) -> Iterable["_models.RouterJob"]:
+    ) -> ItemPaged["_models.RouterJob"]:
         """Retrieves list of jobs based on filter parameters.
 
         Retrieves list of jobs based on filter parameters.
@@ -4489,8 +4479,6 @@ def delete_worker(self, worker_id: str, **kwargs: Any) -> None:  # pylint: disab
 
         :param worker_id: Id of the worker. Required.
         :type worker_id: str
-        :keyword bool stream: Whether to stream the response of this operation. Defaults to False. You
-         will have to context manage the returned stream.
         :return: None
         :rtype: None
         :raises ~azure.core.exceptions.HttpResponseError:
@@ -4544,7 +4532,7 @@ def list_workers(
         queue_id: Optional[str] = None,
         has_capacity: Optional[bool] = None,
         **kwargs: Any
-    ) -> Iterable["_models.RouterWorker"]:
+    ) -> ItemPaged["_models.RouterWorker"]:
         """Retrieves existing workers.
 
         Retrieves existing workers.