Skip to content

Commit 69afcf2

Browse files
[TA] revert rename for date time resolution (Azure#29065)
* revert rename datetime_subkind * changelog and samples
1 parent 611149a commit 69afcf2

File tree

6 files changed

+13
-23
lines changed

6 files changed

+13
-23
lines changed

sdk/textanalytics/azure-ai-textanalytics/CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ This version of the client library defaults to the service API version `2022-10-
1212
### Breaking Changes
1313

1414
- Removed models `BaseResolution` and `BooleanResolution`.
15-
- Renamed property `date_time_sub_kind` to `datetime_subkind` on `DateTimeResolution`.
1615
- Renamed model `AbstractSummaryAction` to `AbstractiveSummaryAction`.
1716
- Renamed model `AbstractSummaryResult` to `AbstractiveSummaryResult`.
1817
- Changed automatic language detection, it is now controlled by the boolean keyword argument `auto_detect_language`.

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_generated/v2022_10_01_preview/models/_models_py3.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2870,9 +2870,9 @@ class DateTimeResolution(BaseResolution):
28702870
(https://github.com/Microsoft/Recognizers-Text/blob/master/Patterns/English/English-DateTime.yaml).
28712871
Required.
28722872
:vartype timex: str
2873-
:ivar datetime_subkind: The DateTime SubKind. Required. Known values are: "Time", "Date",
2873+
:ivar date_time_sub_kind: The DateTime SubKind. Required. Known values are: "Time", "Date",
28742874
"DateTime", "Duration", and "Set".
2875-
:vartype datetime_subkind: str or
2875+
:vartype date_time_sub_kind: str or
28762876
~azure.ai.textanalytics.v2022_10_01_preview.models.DateTimeSubKind
28772877
:ivar value: The actual time that the extracted text denote. Required.
28782878
:vartype value: str
@@ -2886,14 +2886,14 @@ class DateTimeResolution(BaseResolution):
28862886
_validation = {
28872887
'resolution_kind': {'required': True},
28882888
'timex': {'required': True},
2889-
'datetime_subkind': {'required': True},
2889+
'date_time_sub_kind': {'required': True},
28902890
'value': {'required': True},
28912891
}
28922892

28932893
_attribute_map = {
28942894
"resolution_kind": {"key": "resolutionKind", "type": "str"},
28952895
"timex": {"key": "timex", "type": "str"},
2896-
"datetime_subkind": {"key": "dateTimeSubKind", "type": "str"},
2896+
"date_time_sub_kind": {"key": "dateTimeSubKind", "type": "str"},
28972897
"value": {"key": "value", "type": "str"},
28982898
"modifier": {"key": "modifier", "type": "str"},
28992899
}
@@ -2902,7 +2902,7 @@ def __init__(
29022902
self,
29032903
*,
29042904
timex: str,
2905-
datetime_subkind: Union[str, "_models.DateTimeSubKind"],
2905+
date_time_sub_kind: Union[str, "_models.DateTimeSubKind"],
29062906
value: str,
29072907
modifier: Optional[Union[str, "_models.TemporalModifier"]] = None,
29082908
**kwargs
@@ -2912,9 +2912,9 @@ def __init__(
29122912
(https://github.com/Microsoft/Recognizers-Text/blob/master/Patterns/English/English-DateTime.yaml).
29132913
Required.
29142914
:paramtype timex: str
2915-
:keyword datetime_subkind: The DateTime SubKind. Required. Known values are: "Time", "Date",
2915+
:keyword date_time_sub_kind: The DateTime SubKind. Required. Known values are: "Time", "Date",
29162916
"DateTime", "Duration", and "Set".
2917-
:paramtype datetime_subkind: str or
2917+
:paramtype date_time_sub_kind: str or
29182918
~azure.ai.textanalytics.v2022_10_01_preview.models.DateTimeSubKind
29192919
:keyword value: The actual time that the extracted text denote. Required.
29202920
:paramtype value: str
@@ -2927,7 +2927,7 @@ def __init__(
29272927
super().__init__(**kwargs)
29282928
self.resolution_kind = 'DateTimeResolution' # type: str
29292929
self.timex = timex
2930-
self.datetime_subkind = datetime_subkind
2930+
self.date_time_sub_kind = date_time_sub_kind
29312931
self.value = value
29322932
self.modifier = modifier
29332933

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_generated/v2022_10_01_preview/models/_patch.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ class DateTimeResolution(GeneratedDateTimeResolution, DictMixin):
131131
"""An extended ISO 8601 date/time representation as described in
132132
(https://github.com/Microsoft/Recognizers-Text/blob/master/Patterns/English/English-DateTime.yaml).
133133
Required."""
134-
datetime_subkind: str
134+
date_time_sub_kind: str
135135
"""The DateTime SubKind. Required. Known values are: "Time", "Date",
136136
"DateTime", "Duration", and "Set". Described in ~azure.ai.textanalytics.DateTimeSubKind."""
137137
value: str
@@ -146,12 +146,12 @@ def __init__(
146146
self,
147147
*,
148148
timex: str,
149-
datetime_subkind: str,
149+
date_time_sub_kind: str,
150150
value: str,
151151
modifier: Optional[str] = None,
152152
**kwargs
153153
):
154-
super().__init__(timex=timex, datetime_subkind=datetime_subkind, value=value, modifier=modifier, **kwargs)
154+
super().__init__(timex=timex, date_time_sub_kind=date_time_sub_kind, value=value, modifier=modifier, **kwargs)
155155

156156

157157
class InformationResolution(GeneratedInformationResolution, DictMixin):

sdk/textanalytics/azure-ai-textanalytics/samples/async_samples/sample_recognize_entity_resolutions_async.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ async def sample_recognize_entity_resolutions_async() -> None:
7070
f"and ISO4217 code of '{res.iso4217}'.")
7171
elif res.resolution_kind == ResolutionKind.DATE_TIME_RESOLUTION:
7272
print(f"......DateTime resolution has a value of '{res.value}', a subkind of "
73-
f"'{res.datetime_subkind}', and a timex of '{res.timex}'.")
73+
f"'{res.date_time_sub_kind}', and a timex of '{res.timex}'.")
7474
elif res.resolution_kind == ResolutionKind.INFORMATION_RESOLUTION:
7575
print(f"......Information resolution has a value of '{res.value}' and unit of '{res.unit}'.")
7676
elif res.resolution_kind == ResolutionKind.LENGTH_RESOLUTION:

sdk/textanalytics/azure-ai-textanalytics/samples/sample_recognize_entity_resolutions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def sample_recognize_entity_resolutions() -> None:
6565
f"and ISO4217 code of '{res.iso4217}'.")
6666
elif res.resolution_kind == ResolutionKind.DATE_TIME_RESOLUTION:
6767
print(f"......DateTime resolution has a value of '{res.value}', a subkind of "
68-
f"'{res.datetime_subkind}', and a timex of '{res.timex}'.")
68+
f"'{res.date_time_sub_kind}', and a timex of '{res.timex}'.")
6969
elif res.resolution_kind == ResolutionKind.INFORMATION_RESOLUTION:
7070
print(f"......Information resolution has a value of '{res.value}' and unit of '{res.unit}'.")
7171
elif res.resolution_kind == ResolutionKind.LENGTH_RESOLUTION:

sdk/textanalytics/azure-ai-textanalytics/swagger/README.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -191,12 +191,3 @@ directive:
191191
where: $.definitions.JobState
192192
transform: $.properties.lastUpdatedDateTime["x-ms-client-name"] = "lastUpdateDateTime";
193193
```
194-
195-
### Rename DateTimeResolution.date_time_sub_kind property to datetime_subkind
196-
197-
```yaml
198-
directive:
199-
- from: swagger-document
200-
where: $.definitions.DateTimeResolution
201-
transform: $.properties.dateTimeSubKind["x-ms-client-name"] = "datetimeSubkind";
202-
```

0 commit comments

Comments
 (0)