Skip to content

Commit 2cab9ac

Browse files
kashifkhanlmazuel
andauthored
[Azure Core Experimental] Typing Info (Azure#31581)
* typing info * Update pyproject.toml * fix mypy --------- Co-authored-by: Laurent Mazuel <lmazuel@microsoft.com>
1 parent acb6900 commit 2cab9ac

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

sdk/core/azure-core-experimental/azure/core/experimental/transport/__init__.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
#
2525
# --------------------------------------------------------------------------
2626
import sys
27+
from typing import List
2728

2829
# pylint: disable=undefined-all-variable
2930

@@ -34,10 +35,10 @@
3435
"AsyncHttpXTransport",
3536
]
3637

37-
def __dir__():
38+
def __dir__() -> List[str]:
3839
return __all__
3940

40-
def __getattr__(name):
41+
def __getattr__(name: str):
4142
if name == "PyodideTransport":
4243
try:
4344
from ._pyodide import PyodideTransport

sdk/core/azure-core-experimental/azure/core/experimental/transport/_httpx.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ def send(self, request: Union[HttpRequest, LegacyHttpRequest], **kwargs) -> Http
196196
"headers": request.headers.items(),
197197
"data": request.data,
198198
"files": request.files,
199-
"timeout": timeout if timeout else request.timeout,
199+
"timeout": timeout,
200200
**kwargs,
201201
}
202202

@@ -205,11 +205,11 @@ def send(self, request: Union[HttpRequest, LegacyHttpRequest], **kwargs) -> Http
205205

206206
stream_ctx: Optional[ContextManager] = None
207207
try:
208-
if stream_response:
208+
if stream_response and self.client:
209209
stream_ctx = self.client.stream(**parameters)
210210
if stream_ctx:
211211
response = stream_ctx.__enter__()
212-
else:
212+
elif self.client:
213213
response = self.client.request(**parameters)
214214
except (
215215
httpx.ReadTimeout,

sdk/core/azure-core-experimental/azure/core/experimental/transport/_httpx_async.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,18 +183,18 @@ async def send(self, request: Union[HttpRequest, LegacyHttpRequest], **kwargs) -
183183
"url": request.url,
184184
"headers": request.headers.items(),
185185
"data": request.data,
186-
"content": request.content,
186+
"content": request.content if hasattr(request, "content") else None,
187187
"files": request.files,
188188
**kwargs,
189189
}
190190

191191
stream_ctx: Optional[ContextManager] = None
192192

193193
try:
194-
if stream_response:
194+
if stream_response and self.client:
195195
req = self.client.build_request(**parameters)
196196
response = await self.client.send(req, stream=stream_response)
197-
else:
197+
elif self.client:
198198
response = await self.client.request(**parameters)
199199
except (
200200
httpx.ReadTimeout,

sdk/core/azure-core-experimental/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
type_check_samples = false
33
verifytypes = false
44
pyright = false
5-
mypy = false
5+
mypy = true

0 commit comments

Comments
 (0)