Validate date string (Azure#25967)

# Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

# All SDK Contribution checklist:
- [ ] **The pull request does not introduce [breaking changes]**
- [ X] **CHANGELOG is updated for new features, bug fixes or other significant changes.**
- [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-python/blob/main/CONTRIBUTING.md).**

## General Guidelines and Best Practices
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-python/blob/main/CONTRIBUTING.md##building-and-testing)
- [ X] Pull request includes test coverage for the included changes.

Author: anujissarMS

sdk/communication/azure-communication-rooms/CHANGELOG.md

@@ -1,12 +1,9 @@
 # Release History
 
-## 1.0.0b2 (Unreleased)
-
-### Features Added
-
-### Breaking Changes
+## 1.0.0b2 (2022-08-30)
 
 ### Bugs Fixed
+ - Invalid datestrings for `valid_from` and `valid_until` raises exception
 
 ### Other Changes
 Python 3.6 is no longer supported. Please use Python version 3.7 or later. For more details, please read our page on [Azure SDK for Python version support policy](https://github.com/Azure/azure-sdk-for-python/wiki/Azure-SDKs-Python-version-support-policy).

sdk/communication/azure-communication-rooms/azure/communication/rooms/_rooms_client.py

@@ -25,7 +25,7 @@
     RoomJoinPolicy
 )
 
-from ._shared.utils import parse_connection_str
+from ._shared.utils import parse_connection_str, verify_datetime_format
 from ._version import SDK_MONIKER
 from ._api_versions import DEFAULT_VERSION
 
@@ -117,23 +117,24 @@ def create_room(
         :rtype: ~azure.communication.rooms.CommunicationRoom
         :raises: ~azure.core.exceptions.HttpResponseError
         """
-        create_room_request = CreateRoomRequest(
-            valid_from=valid_from,
-            valid_until=valid_until,
-            room_join_policy=room_join_policy,
-            # pylint: disable=protected-access
-            participants=[p._to_room_participant_internal() for p in participants] if participants else None
-        )
-
-        repeatability_request_id = uuid.uuid1()
-        repeatability_first_sent = datetime.utcnow()
-
-        create_room_response = self._rooms_service_client.rooms.create_room(
-            create_room_request=create_room_request,
-            repeatability_request_id=repeatability_request_id,
-            repeatability_first_sent=repeatability_first_sent,
-            **kwargs)
-        return CommunicationRoom._from_room_response(create_room_response) # pylint: disable=protected-access
+        if verify_datetime_format(valid_from) and verify_datetime_format(valid_until):
+            create_room_request = CreateRoomRequest(
+                valid_from=valid_from,
+                valid_until=valid_until,
+                room_join_policy=room_join_policy,
+                # pylint: disable=protected-access
+                participants=[p._to_room_participant_internal() for p in participants] if participants else None
+            )
+
+            repeatability_request_id = uuid.uuid1()
+            repeatability_first_sent = datetime.utcnow()
+
+            create_room_response = self._rooms_service_client.rooms.create_room(
+                create_room_request=create_room_request,
+                repeatability_request_id=repeatability_request_id,
+                repeatability_first_sent=repeatability_first_sent,
+                **kwargs)
+            return CommunicationRoom._from_room_response(create_room_response) # pylint: disable=protected-access
 
     @distributed_trace
     def delete_room(
@@ -182,18 +183,18 @@ def update_room(
         :raises: ~azure.core.exceptions.HttpResponseError, ValueError
 
         """
-
-        update_room_request = UpdateRoomRequest(
-            valid_from=valid_from,
-            valid_until=valid_until,
-            room_join_policy=room_join_policy,
+        if verify_datetime_format(valid_from) and verify_datetime_format(valid_until):
+            update_room_request = UpdateRoomRequest(
+                valid_from=valid_from,
+                valid_until=valid_until,
+                room_join_policy=room_join_policy,
+                # pylint: disable=protected-access
+                participants=[p._to_room_participant_internal() for p in participants] if participants else None
+            )
+            update_room_response = self._rooms_service_client.rooms.update_room(
+                room_id=room_id, patch_room_request=update_room_request, **kwargs)
             # pylint: disable=protected-access
-            participants=[p._to_room_participant_internal() for p in participants] if participants else None
-        )
-        update_room_response = self._rooms_service_client.rooms.update_room(
-            room_id=room_id, patch_room_request=update_room_request, **kwargs)
-        # pylint: disable=protected-access
-        return CommunicationRoom._from_room_response(update_room_response)
+            return CommunicationRoom._from_room_response(update_room_response)
 
     @distributed_trace
     def get_room(

sdk/communication/azure-communication-rooms/azure/communication/rooms/_shared/utils.py

@@ -11,6 +11,7 @@
                     Tuple,
                     )
 from datetime import datetime
+import isodate
 from msrest.serialization import TZ_UTC
 from azure.core.credentials import AccessToken
 
@@ -66,6 +67,20 @@ def get_current_utc_as_int():
     return _convert_datetime_to_utc_int(current_utc_datetime)
 
 
+def verify_datetime_format(input_datetime):
+    #type: (datetime) -> bool
+    if input_datetime is None:
+        return True
+    try:
+        if isinstance(input_datetime, str):
+            input_datetime = isodate.parse_datetime(input_datetime)
+        if isinstance(input_datetime, datetime):
+            return True
+    except:
+        raise ValueError("{} is not a valid ISO-8601 datetime format".format(input_datetime)) from None
+    return True
+
+
 def create_access_token(token):
     # type: (str) -> azure.core.credentials.AccessToken
     """Creates an instance of azure.core.credentials.AccessToken from a

sdk/communication/azure-communication-rooms/tests/test_rooms_client.py

@@ -249,3 +249,16 @@ def mock_send(*_, **__):
 
         self.assertFalse(raised, 'Expected is no excpetion raised')
         self.assertListEqual(response.participants, [self.room_participant])
+
+    def test_invalid_datetime_raises_valueError(self):
+        rooms_client = RoomsClient("https://endpoint", AzureKeyCredential("fakeCredential=="), transport=None)
+
+        # verify value error on create room call
+        self.assertRaises(ValueError, rooms_client.create_room, valid_from="dummy", valid_until=self.valid_until)
+        self.assertRaises(ValueError, rooms_client.create_room, valid_from=self.valid_from, valid_until="dummy")
+        self.assertRaises(ValueError, rooms_client.create_room, valid_from="dummy", valid_until="dummy")
+
+        # verify ValueError on update_room calls
+        self.assertRaises(ValueError, rooms_client.update_room, room_id=self.room_id, valid_from="dummy", valid_until=self.valid_until)
+        self.assertRaises(ValueError, rooms_client.update_room, room_id=self.room_id, valid_from=self.valid_from, valid_until="dummy")
+        self.assertRaises(ValueError, rooms_client.update_room, room_id=self.room_id, valid_from="dummy", valid_until="dummy")