Fix request success criteria for 4xx errors (Azure#33617)

* fix request success criteria for 4xx errors

* fix tests

* apply for http type only

* remove unnecessary using

* fix failing test

Author: vishweshbankwar

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Customizations/Models/RequestData.cs

@@ -5,12 +5,9 @@
 
 using System.Diagnostics;
 using System.Globalization;
-
 using Azure.Core;
 using Azure.Monitor.OpenTelemetry.Exporter.Internals;
 
-using OpenTelemetry.Trace;
-
 namespace Azure.Monitor.OpenTelemetry.Exporter.Models
 {
     internal partial class RequestData
@@ -34,12 +31,21 @@ public RequestData(int version, Activity activity, ref TagEnumerationState monit
             Duration = activity.Duration < SchemaConstants.RequestData_Duration_LessThanDays
                 ? activity.Duration.ToString("c", CultureInfo.InvariantCulture)
                 : SchemaConstants.Duration_MaxValue;
-            Success = activity.Status != ActivityStatusCode.Error;
             ResponseCode = AzMonList.GetTagValue(ref monitorTags.MappedTags, SemanticConventions.AttributeHttpStatusCode)
                 ?.ToString().Truncate(SchemaConstants.RequestData_ResponseCode_MaxLength)
                 ?? "0";
-            Url = url.Truncate(SchemaConstants.RequestData_Url_MaxLength);
 
+            if (monitorTags.activityType ==  OperationType.Http && int.TryParse(ResponseCode, out int statusCode))
+            {
+                bool isSuccessStatusCode = statusCode != 0 && statusCode < 400;
+                Success = activity.Status != ActivityStatusCode.Error && isSuccessStatusCode;
+            }
+            else
+            {
+                Success = activity.Status != ActivityStatusCode.Error;
+            }
+
+            Url = url.Truncate(SchemaConstants.RequestData_Url_MaxLength);
             Properties = new ChangeTrackingDictionary<string, string>();
             Measurements = new ChangeTrackingDictionary<string, double>();
 

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Tests/RequestDataTests.cs

@@ -62,7 +62,7 @@ public void ValidateHttpRequestData()
             Assert.Equal(httpUrl, requestData.Url);
             Assert.Equal("0", requestData.ResponseCode);
             Assert.Equal(activity.Duration.ToString("c", CultureInfo.InvariantCulture), requestData.Duration);
-            Assert.Equal(activity.GetStatus() != Status.Error, requestData.Success);
+            Assert.False(requestData.Success);
             Assert.Null(requestData.Source);
             Assert.True(requestData.Properties.Count == 0);
             Assert.True(requestData.Measurements.Count == 0);
@@ -90,5 +90,31 @@ public void ValidateHttpRequestDataResponseCode(string httpStatusCode)
 
             Assert.Equal(httpResponseCode, requestData.ResponseCode);
         }
+
+        [Theory]
+        [InlineData("200", true)]
+        [InlineData("400", false)]
+        [InlineData("500", false)]
+        [InlineData("0", false)]
+        public void ValidateHttpRequestSuccess(string httpStatusCode, bool isSuccess)
+        {
+            using ActivitySource activitySource = new ActivitySource(ActivitySourceName);
+            using var activity = activitySource.StartActivity(
+                ActivityName,
+                ActivityKind.Server,
+                parentContext: new ActivityContext(ActivityTraceId.CreateRandom(), ActivitySpanId.CreateRandom(), ActivityTraceFlags.Recorded),
+                startTime: DateTime.UtcNow);
+
+            var httpResponseCode = httpStatusCode ?? "0";
+            activity.SetTag(SemanticConventions.AttributeHttpUrl, "https://www.foo.bar/search");
+            activity.SetTag(SemanticConventions.AttributeHttpStatusCode, httpStatusCode);
+
+            var monitorTags = TraceHelper.EnumerateActivityTags(activity);
+
+            var requestData = new RequestData(2, activity, ref monitorTags);
+
+            Assert.Equal(httpResponseCode, requestData.ResponseCode);
+            Assert.Equal(isSuccess, requestData.Success);
+        }
     }
 }