[ContainerInstance] Add backward compatibility for property renaming (Azure#33771)

Author: fengzhou-msft

sdk/containerinstance/Azure.ResourceManager.ContainerInstance/CHANGELOG.md

@@ -1,15 +1,11 @@
 # Release History
 
-## 1.1.0-beta.2 (Unreleased)
-
-### Features Added
-
-### Breaking Changes
-
-### Bugs Fixed
+## 1.1.0-beta.2 (2023-02-01)
 
 ### Other Changes
 
+- Added backward compatibility for the change of `DnsNameLabelReusePolicy` property replaced by `AutoGeneratedDnsNameLabelScope` in `ContainerGroupIPAddress`.
+
 ## 1.1.0-beta.1 (2023-01-26)
 This release is a preview release for ContainerGroup Priority property and Confidential Containers.
 

sdk/containerinstance/Azure.ResourceManager.ContainerInstance/api/Azure.ResourceManager.ContainerInstance.netstandard2.0.cs

@@ -235,7 +235,7 @@ public ContainerGroupIPAddress(System.Collections.Generic.IEnumerable<Azure.Reso
         public Azure.ResourceManager.ContainerInstance.Models.DnsNameLabelReusePolicy? AutoGeneratedDomainNameLabelScope { get { throw null; } set { } }
         public string DnsNameLabel { get { throw null; } set { } }
         [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        [System.ObsoleteAttribute("DnsNameLabelReusePolicy is deprecated, use AutoGeneratedDnsNameLabelScope instead")]
+        [System.ObsoleteAttribute("DnsNameLabelReusePolicy is deprecated, use AutoGeneratedDnsNameLabelScope instead", false)]
         public Azure.ResourceManager.ContainerInstance.Models.AutoGeneratedDomainNameLabelScope? DnsNameLabelReusePolicy { get { throw null; } set { } }
         public string Fqdn { get { throw null; } }
         public System.Net.IPAddress IP { get { throw null; } set { } }

sdk/containerinstance/Azure.ResourceManager.ContainerInstance/src/Customized/Models/ContainerGroupIPAddress.cs

@@ -4,20 +4,23 @@
 #nullable disable
 
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Net;
 using System.ComponentModel;
-using Azure.Core;
 
 namespace Azure.ResourceManager.ContainerInstance.Models
 {
     /// <summary> IP address for the container group. </summary>
     public partial class ContainerGroupIPAddress
     {
         /// <summary> The value representing the security enum. </summary>
-        [Obsolete("DnsNameLabelReusePolicy is deprecated, use AutoGeneratedDnsNameLabelScope instead")]
+        [Obsolete("DnsNameLabelReusePolicy is deprecated, use AutoGeneratedDnsNameLabelScope instead", false)]
         [EditorBrowsable(EditorBrowsableState.Never)]
-        public AutoGeneratedDomainNameLabelScope? DnsNameLabelReusePolicy { get; set; }
+        public AutoGeneratedDomainNameLabelScope? DnsNameLabelReusePolicy
+        {
+            get => AutoGeneratedDomainNameLabelScope == null ? null : new AutoGeneratedDomainNameLabelScope(AutoGeneratedDomainNameLabelScope.Value.ToString());
+            set
+            {
+                AutoGeneratedDomainNameLabelScope = value == null ? null : new DnsNameLabelReusePolicy(value.Value.ToString());
+            }
+        }
     }
 }

sdk/containerinstance/Azure.ResourceManager.ContainerInstance/tests/ContainerInstanceManagementTestBase.cs

@@ -98,7 +98,8 @@ protected static ContainerGroupData CreateContainerGroupData(string containerGro
                 keyName: "testencryptionkey",
                 keyVersion: "804d3f1d5ce2456b9bc3dc9e35aaa67e");
 
-	    if (priority == "Spot") {
+            if (priority == "Spot")
+            {
                 var priorityContainerGroup = new ContainerGroupData(
                     location: "westus",
                     containers: containers,
@@ -125,10 +126,10 @@ protected static ContainerGroupData CreateContainerGroupData(string containerGro
                     },
                     EncryptionProperties = encryptionProps,
                     Priority = ContainerGroupPriority.Spot,
-		    Sku = ContainerGroupSku.Standard
+                    Sku = ContainerGroupSku.Standard
                 };
                 return priorityContainerGroup;
-	    }
+            }
 
             var confidentialComputeProperties = new ConfidentialComputeProperties();
             var sku = new ContainerGroupSku("Standard");
@@ -145,7 +146,7 @@ protected static ContainerGroupData CreateContainerGroupData(string containerGro
                                 cpu: 1.0))
                     )
                     {
-		        Ports =
+                Ports =
                         {
                             new ContainerPort(80)
                         },
@@ -171,7 +172,7 @@ protected static ContainerGroupData CreateContainerGroupData(string containerGro
                     IPAddress = new ContainerGroupIPAddress(
                             ports: new[] { new ContainerGroupPort(80) { Protocol = ContainerGroupNetworkProtocol.Tcp } },
                             addressType: ContainerGroupIPAddressType.Public
-		    ),
+            ),
                     RestartPolicy = ContainerGroupRestartPolicy.Never,
                     Identity = new ManagedServiceIdentity(ManagedServiceIdentityType.SystemAssigned),
                     InitContainers = {
@@ -194,7 +195,7 @@ protected static ContainerGroupData CreateContainerGroupData(string containerGro
                     Sku = ContainerGroupSku.Confidential
                 };
                 return confContainerGroup;
-	    }
+            }
 
             var containerGroup = new ContainerGroupData(
                 location: "westus",
@@ -249,11 +250,11 @@ protected void VerifyContainerGroupProperties(ContainerGroupData expected, Conta
             Assert.AreEqual(expected.Diagnostics?.LogAnalytics.WorkspaceId, actual.Diagnostics?.LogAnalytics.WorkspaceId);
             Assert.NotNull(actual.Containers);
             Assert.AreEqual(1, actual.Containers.Count);
-	    if (expected.Priority != ContainerGroupPriority.Spot)
-	    {
-		Assert.NotNull(actual.IPAddress);
+            if (expected.Priority != ContainerGroupPriority.Spot)
+            {
+                Assert.NotNull(actual.IPAddress);
                 Assert.NotNull(actual.IPAddress.IP);
-	    }
+            }
             Assert.AreEqual(expected.EncryptionProperties?.KeyName, actual.EncryptionProperties?.KeyName);
             Assert.AreEqual(expected.EncryptionProperties?.KeyVersion, actual.EncryptionProperties?.KeyVersion);
             Assert.AreEqual(expected.EncryptionProperties?.VaultBaseUri, actual.EncryptionProperties?.VaultBaseUri);
@@ -267,9 +268,10 @@ protected void VerifyContainerGroupProperties(ContainerGroupData expected, Conta
             Assert.AreEqual(expected.InitContainers[0].Name, actual.InitContainers[0].Name);
             Assert.AreEqual(expected.InitContainers[0].Image, actual.InitContainers[0].Image);
             Assert.AreEqual(expected.Priority, actual.Priority);
-            if (expected.Sku == ContainerGroupSku.Confidential) {
+            if (expected.Sku == ContainerGroupSku.Confidential)
+            {
                 Assert.NotNull(actual.ConfidentialComputeProperties?.CcePolicy);
-	    }
+            }
         }
     }
 }