DataMovement StorageResource construction refactor | Part 1 (Azure#38086)

* removed old rehydration code

* "provider" apis added

* implement local file StorageResourceProvider

* StorageResourceProvider apis async | basic blobs implementation

* implement blobstorageresourceprovider "from" methods

* move away from constructors to providers.

can't make blob resource constructors internal yet without a massive test
refactor

* provider cred infra

* republic local fil resources

* undo smaple changes

* remove cred functionality from blob provider

* restore old rehydration files

* tests rehydration

* exportapi

* unrecord rehydration tests

* rename arg

* exportapi

Author: jaschrep-msft

sdk/storage/Azure.Storage.Common/tests/Shared/RandomExtensions.cs

@@ -0,0 +1,22 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System;
+
+namespace Azure.Storage.Tests
+{
+    public static class RandomExtensions
+    {
+        private const string _alphanumeric = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
+
+        public static string NextString(this Random random, int length)
+        {
+            var buffer = new char[length];
+            for (var i = 0; i < length; i++)
+            {
+                buffer[i] = _alphanumeric[random.Next(_alphanumeric.Length)];
+            }
+            return new string(buffer);
+        }
+    }
+}

sdk/storage/Azure.Storage.DataMovement.Blobs/api/Azure.Storage.DataMovement.Blobs.net6.0.cs

@@ -41,6 +41,19 @@ public BlobContainerClientTransferOptions() { }
         public Azure.Storage.DataMovement.Blobs.BlobStorageResourceContainerOptions BlobContainerOptions { get { throw null; } set { } }
         public Azure.Storage.DataMovement.DataTransferOptions TransferOptions { get { throw null; } set { } }
     }
+    public partial class BlobsStorageResourceProvider : Azure.Storage.DataMovement.StorageResourceProvider
+    {
+        public BlobsStorageResourceProvider() { }
+        protected override string TypeId { get { throw null; } }
+        public Azure.Storage.DataMovement.StorageResource FromBlob(string blobUri, Azure.Storage.DataMovement.Blobs.BlobStorageResourceOptions options = null) { throw null; }
+        public Azure.Storage.DataMovement.StorageResource FromClient(Azure.Storage.Blobs.BlobContainerClient client, Azure.Storage.DataMovement.Blobs.BlobStorageResourceContainerOptions options = null) { throw null; }
+        public Azure.Storage.DataMovement.StorageResource FromClient(Azure.Storage.Blobs.Specialized.AppendBlobClient client, Azure.Storage.DataMovement.Blobs.AppendBlobStorageResourceOptions options = null) { throw null; }
+        public Azure.Storage.DataMovement.StorageResource FromClient(Azure.Storage.Blobs.Specialized.BlockBlobClient client, Azure.Storage.DataMovement.Blobs.BlockBlobStorageResourceOptions options = null) { throw null; }
+        public Azure.Storage.DataMovement.StorageResource FromClient(Azure.Storage.Blobs.Specialized.PageBlobClient client, Azure.Storage.DataMovement.Blobs.PageBlobStorageResourceOptions options = null) { throw null; }
+        public Azure.Storage.DataMovement.StorageResource FromContainer(string containerUri, Azure.Storage.DataMovement.Blobs.BlobStorageResourceContainerOptions options = null) { throw null; }
+        protected override System.Threading.Tasks.Task<Azure.Storage.DataMovement.StorageResource> FromDestinationAsync(Azure.Storage.DataMovement.DataTransferProperties properties, System.Threading.CancellationToken cancellationToken) { throw null; }
+        protected override System.Threading.Tasks.Task<Azure.Storage.DataMovement.StorageResource> FromSourceAsync(Azure.Storage.DataMovement.DataTransferProperties properties, System.Threading.CancellationToken cancellationToken) { throw null; }
+    }
     public partial class BlobStorageResourceContainer : Azure.Storage.DataMovement.StorageResourceContainer
     {
         public BlobStorageResourceContainer(Azure.Storage.Blobs.BlobContainerClient blobContainerClient, Azure.Storage.DataMovement.Blobs.BlobStorageResourceContainerOptions options = null) { }

sdk/storage/Azure.Storage.DataMovement.Blobs/api/Azure.Storage.DataMovement.Blobs.netstandard2.0.cs

@@ -41,6 +41,19 @@ public BlobContainerClientTransferOptions() { }
         public Azure.Storage.DataMovement.Blobs.BlobStorageResourceContainerOptions BlobContainerOptions { get { throw null; } set { } }
         public Azure.Storage.DataMovement.DataTransferOptions TransferOptions { get { throw null; } set { } }
     }
+    public partial class BlobsStorageResourceProvider : Azure.Storage.DataMovement.StorageResourceProvider
+    {
+        public BlobsStorageResourceProvider() { }
+        protected override string TypeId { get { throw null; } }
+        public Azure.Storage.DataMovement.StorageResource FromBlob(string blobUri, Azure.Storage.DataMovement.Blobs.BlobStorageResourceOptions options = null) { throw null; }
+        public Azure.Storage.DataMovement.StorageResource FromClient(Azure.Storage.Blobs.BlobContainerClient client, Azure.Storage.DataMovement.Blobs.BlobStorageResourceContainerOptions options = null) { throw null; }
+        public Azure.Storage.DataMovement.StorageResource FromClient(Azure.Storage.Blobs.Specialized.AppendBlobClient client, Azure.Storage.DataMovement.Blobs.AppendBlobStorageResourceOptions options = null) { throw null; }
+        public Azure.Storage.DataMovement.StorageResource FromClient(Azure.Storage.Blobs.Specialized.BlockBlobClient client, Azure.Storage.DataMovement.Blobs.BlockBlobStorageResourceOptions options = null) { throw null; }
+        public Azure.Storage.DataMovement.StorageResource FromClient(Azure.Storage.Blobs.Specialized.PageBlobClient client, Azure.Storage.DataMovement.Blobs.PageBlobStorageResourceOptions options = null) { throw null; }
+        public Azure.Storage.DataMovement.StorageResource FromContainer(string containerUri, Azure.Storage.DataMovement.Blobs.BlobStorageResourceContainerOptions options = null) { throw null; }
+        protected override System.Threading.Tasks.Task<Azure.Storage.DataMovement.StorageResource> FromDestinationAsync(Azure.Storage.DataMovement.DataTransferProperties properties, System.Threading.CancellationToken cancellationToken) { throw null; }
+        protected override System.Threading.Tasks.Task<Azure.Storage.DataMovement.StorageResource> FromSourceAsync(Azure.Storage.DataMovement.DataTransferProperties properties, System.Threading.CancellationToken cancellationToken) { throw null; }
+    }
     public partial class BlobStorageResourceContainer : Azure.Storage.DataMovement.StorageResourceContainer
     {
         public BlobStorageResourceContainer(Azure.Storage.Blobs.BlobContainerClient blobContainerClient, Azure.Storage.DataMovement.Blobs.BlobStorageResourceContainerOptions options = null) { }

sdk/storage/Azure.Storage.DataMovement.Blobs/src/BlobContainerClientExtensions.cs

@@ -15,6 +15,8 @@ namespace Azure.Storage.Blobs
     public static class BlobContainerClientExtensions
     {
         private static Lazy<TransferManager> s_defaultTransferManager = new Lazy<TransferManager>(() => new TransferManager(default));
+        private static Lazy<LocalFilesStorageResourceProvider> s_filesProvider = new();
+        private static Lazy<BlobsStorageResourceProvider> s_blobsProvider = new();
 
         /// <summary>
         /// Uploads the entire contents of local directory to the blob container.
@@ -47,8 +49,8 @@ public static Task<DataTransfer> StartUploadDirectoryAsync(
         /// <returns>A <see cref="DataTransfer"/> instance which can be used track progress and wait for completion with <see cref="DataTransfer.WaitForCompletionAsync"/>.</returns>
         public static async Task<DataTransfer> StartUploadDirectoryAsync(this BlobContainerClient client, string localDirectoryPath, BlobContainerClientTransferOptions options)
         {
-            StorageResourceContainer localDirectory = new LocalDirectoryStorageResourceContainer(localDirectoryPath);
-            StorageResourceContainer blobDirectory = new BlobStorageResourceContainer(client, options?.BlobContainerOptions);
+            StorageResource localDirectory = s_filesProvider.Value.FromPath(localDirectoryPath);
+            StorageResource blobDirectory = s_blobsProvider.Value.FromClient(client, options?.BlobContainerOptions);
 
             return await s_defaultTransferManager.Value.StartTransferAsync(localDirectory, blobDirectory, options?.TransferOptions).ConfigureAwait(false);
         }
@@ -84,8 +86,8 @@ public static Task<DataTransfer> StartDownloadToDirectoryAsync(
         /// <returns></returns>
         public static async Task<DataTransfer> StartDownloadToDirectoryAsync(this BlobContainerClient client, string localDirectoryPath, BlobContainerClientTransferOptions options)
         {
-            StorageResourceContainer localDirectory = new LocalDirectoryStorageResourceContainer(localDirectoryPath);
-            StorageResourceContainer blobDirectory = new BlobStorageResourceContainer(client, options?.BlobContainerOptions);
+            StorageResource localDirectory = s_filesProvider.Value.FromPath(localDirectoryPath);
+            StorageResource blobDirectory = s_blobsProvider.Value.FromClient(client, options?.BlobContainerOptions);
 
             return await s_defaultTransferManager.Value.StartTransferAsync(blobDirectory, localDirectory, options?.TransferOptions).ConfigureAwait(false);
         }