Fix to prevent empty strings or null to be passed as paths for LocalFileStorageResource and LocalDirectoryStorageResourceContainer. (Azure#36015)

Author: amnguye

sdk/storage/Azure.Storage.DataMovement/CHANGELOG.md

@@ -7,6 +7,7 @@
 ### Breaking Changes
 
 ### Bugs Fixed
+- Fix to prevent empty strings or null to be passed as paths for `LocalFileStorageResource` and `LocalDirectoryStorageResourceContainer`.
 
 ### Other Changes
 

sdk/storage/Azure.Storage.DataMovement/src/Shared/LocalDirectoryStorageResourceContainer.cs

@@ -8,6 +8,7 @@
 using System.Runtime.CompilerServices;
 using System.Text;
 using System.Threading;
+using Azure.Core;
 using Azure.Storage.DataMovement.Models;
 
 namespace Azure.Storage.DataMovement
@@ -40,6 +41,7 @@ public class LocalDirectoryStorageResourceContainer : StorageResourceContainer
         /// <param name="path"></param>
         public LocalDirectoryStorageResourceContainer(string path)
         {
+            Argument.AssertNotNullOrWhiteSpace(path, nameof(path));
             _path = path;
         }
 

sdk/storage/Azure.Storage.DataMovement/src/Shared/LocalFileStorageResource.cs

@@ -64,6 +64,7 @@ public class LocalFileStorageResource : StorageResource
         /// <param name="path"></param>
         public LocalFileStorageResource(string path)
         {
+            Argument.AssertNotNullOrWhiteSpace(path, nameof(path));
             _path = path;
         }
 

sdk/storage/Azure.Storage.DataMovement/tests/LocalDirectoryStorageResourceTests.cs

@@ -8,6 +8,7 @@
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
+using Azure.Core;
 using Azure.Storage.DataMovement.Models;
 using Azure.Storage.Test.Shared;
 using NUnit.Framework;
@@ -42,6 +43,19 @@ public void Ctor_string()
             }
         }
 
+        [Test]
+        public void Ctor_Error()
+        {
+            Assert.Catch<ArgumentException>( () =>
+                new LocalDirectoryStorageResourceContainer(""));
+
+            Assert.Catch<ArgumentException>(() =>
+                new LocalDirectoryStorageResourceContainer("   "));
+
+            Assert.Catch<ArgumentException>(() =>
+                new LocalDirectoryStorageResourceContainer(default));
+        }
+
         [Test]
         public async Task GetStorageResourcesAsync()
         {

sdk/storage/Azure.Storage.DataMovement/tests/LocalFileStorageResourceTests.cs

@@ -81,6 +81,19 @@ public void Ctor_string()
             }
         }
 
+        [Test]
+        public void Ctor_Error()
+        {
+            Assert.Catch<ArgumentException>(() =>
+                new LocalFileStorageResource(""));
+
+            Assert.Catch<ArgumentException>(() =>
+                new LocalFileStorageResource("   "));
+
+            Assert.Catch<ArgumentException>(() =>
+                new LocalFileStorageResource(default));
+        }
+
         [Test]
         public async Task ReadStreamAsync()
         {