Use Rooms connection string for tests (Azure#32564)

Author: anujissarMS

sdk/communication/Azure.Communication.Rooms/tests/RoomsClientLiveTestBase.cs

@@ -17,16 +17,28 @@ namespace Azure.Communication.Rooms.Tests
     public class RoomsClientLiveTestBase : RecordedTestBase<RoomsClientTestEnvironment>
     {
         private const string DateTimeStampRegEx = @"[0-9]*-[0-9]*-[0-9]*T[0-9]*:[0-9]*:[0-9]*.[0-9]*Z";
+        private const string URIDomainNameReplacerRegEx = @"https://([^/?]+)";
+        private const string URIIdentityReplacerRegEx = @"/identities/([^/?]+)";
+        private const string URIRoomsIdReplacerRegEx = @"/rooms/\d*";
+        private const string RequestBodyIdReplacerRegex = @"8:acs:[a-zA-Z0-9-_]*";
+
         public RoomsClientLiveTestBase(bool isAsync) : base(isAsync)
         {
             SanitizedHeaders.Add("x-ms-content-sha256");
             IgnoredHeaders.Add("Repeatability-Request-ID");
             IgnoredHeaders.Add("Repeatability-First-Sent");
+            JsonPathSanitizers.Add("$..token");
+            JsonPathSanitizers.Add("$..appId");
+            JsonPathSanitizers.Add("$..userId");
             BodyRegexSanitizers.Add(new BodyRegexSanitizer(DateTimeStampRegEx, SanitizeValue));
+            BodyRegexSanitizers.Add(new BodyRegexSanitizer(RequestBodyIdReplacerRegex, SanitizeValue));
+            UriRegexSanitizers.Add(new UriRegexSanitizer(URIIdentityReplacerRegEx, "/identities/Sanitized"));
+            UriRegexSanitizers.Add(new UriRegexSanitizer(URIDomainNameReplacerRegEx, "https://sanitized.communication.azure.com"));
+            UriRegexSanitizers.Add(new UriRegexSanitizer(URIRoomsIdReplacerRegEx, "/rooms/Sanitized"));
         }
         protected RoomsClient CreateInstrumentedRoomsClient(ServiceVersion version)
         {
-            var connectionString = TestEnvironment.LiveTestDynamicConnectionString;
+            var connectionString = TestEnvironment.CommunicationConnectionStringRooms;
             RoomsClient client = new RoomsClient(connectionString, CreateRoomsClientOptionsWithCorrelationVectorLogs(version));
 
             #region Snippet:Azure_Communication_Rooms_Tests_Samples_CreateRoomsClient
@@ -45,7 +57,7 @@ protected RoomsClient CreateInstrumentedRoomsClient(ServiceVersion version)
         protected CommunicationIdentityClient CreateInstrumentedCommunicationIdentityClient()
             => InstrumentClient(
                 new CommunicationIdentityClient(
-                    TestEnvironment.LiveTestDynamicConnectionString,
+                    TestEnvironment.CommunicationConnectionStringRooms,
                     InstrumentClientOptions(new CommunicationIdentityClientOptions(CommunicationIdentityClientOptions.ServiceVersion.V2021_03_07))));
 
         private RoomsClientOptions CreateRoomsClientOptionsWithCorrelationVectorLogs(ServiceVersion version)

sdk/communication/Azure.Communication.Rooms/tests/RoomsClientLiveTests.cs

@@ -118,19 +118,14 @@ public async Task AcsRoomRequestLiveTest()
                 Assert.IsTrue(getRoomParticipantsResult.Any(x => x.Role == RoleType.Attendee), "Expected GetRoom to contain role2");
 
                 // Update Room
-                List<RoomParticipant> updateRoomParticipants = new List<RoomParticipant>();
-                RoomParticipant participant3 = new RoomParticipant(new CommunicationUserIdentifier(communicationUser3), RoleType.Presenter);
-                updateRoomParticipants.Add(participant3);
+                validFrom = validFrom.AddHours(1);
 
-                Response<CommunicationRoom> updateRoomResponse = await roomsClient.UpdateRoomAsync(createdRoomId, validFrom, validUntil, RoomJoinPolicy.InviteOnly, updateRoomParticipants);
+                Response<CommunicationRoom> updateRoomResponse = await roomsClient.UpdateRoomAsync(createdRoomId, validFrom, validUntil, roomJoinPolicy:RoomJoinPolicy.CommunicationServiceUsers);
                 CommunicationRoom updateCommunicationRoom = updateRoomResponse.Value;
                 List<RoomParticipant> updateRoomParticipantsResult = updateCommunicationRoom.Participants.ToList();
                 Assert.AreEqual(createdRoomId, updateCommunicationRoom.Id);
-                Assert.AreEqual(1, updateRoomParticipantsResult.Count, "Expected UpdateRoom participants count to be 1");
-                Assert.IsTrue(updateRoomParticipantsResult.Any(x => x.CommunicationIdentifier.Equals(participant3.CommunicationIdentifier)), "Expected UpdateRoom to contain user3");
-                Assert.IsFalse(updateRoomParticipantsResult.Any(x => x.CommunicationIdentifier.Equals(participant1.CommunicationIdentifier)), "Expected UpdateRoom to not contain user1");
-                Assert.IsFalse(updateRoomParticipantsResult.Any(x => x.CommunicationIdentifier.Equals(participant2.CommunicationIdentifier)), "Expected UpdateRoom to not contain user2");
-                Assert.AreEqual(updateCommunicationRoom.ValidUntil, updateCommunicationRoom.ValidUntil);
+                Assert.AreEqual(2, updateRoomParticipantsResult.Count, "Expected UpdateRoom participants count to be 2");
+                Assert.AreEqual(RoomJoinPolicy.CommunicationServiceUsers , updateCommunicationRoom.RoomJoinPolicy, "Expected RoomJoinPolicy to be updated");
 
                 // Delete Room
                 Response deleteRoomResponse = await roomsClient.DeleteRoomAsync(createdRoomId);

sdk/communication/Azure.Communication.Rooms/tests/RoomsClientTestEnvironment.cs

@@ -1,11 +1,21 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+using System;
 using Azure.Communication.Tests;
+using Azure.Core.TestFramework;
 
 namespace Azure.Communication.Rooms.Tests
 {
     public class RoomsClientTestEnvironment : CommunicationTestEnvironment
     {
+        public const string CommunicationConnectionStringRoomsVariableName = "COMMUNICATION_CONNECTION_STRING_ROOMS";
+        public string CommunicationConnectionStringRooms => GetRecordedVariable(
+            CommunicationConnectionStringRoomsVariableName,
+            options => options.HasSecretConnectionStringParameter("accessKey", SanitizedValue.Base64));
+
+        public Uri CommunicationRoomsEndpoint => new(Core.ConnectionString.Parse(CommunicationConnectionStringRooms).GetRequired("endpoint"));
+
+        public string CommunicationRoomsAccessKey => Core.ConnectionString.Parse(CommunicationConnectionStringRooms).GetRequired("accesskey");
     }
 }