Skip to content

Commit a17da11

Browse files
authored
Add ScaledAssetDimensions to Azure Object Anchors (Azure#28294)
# Contributing to the Azure SDK Please see our [CONTRIBUTING.md](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md) if you are not familiar with contributing to this repository or have questions. For specific information about pull request etiquette and best practices, see [this section](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#pull-request-etiquette-and-best-practices).
1 parent daf55c5 commit a17da11

File tree

13 files changed

+535
-318
lines changed

13 files changed

+535
-318
lines changed

sdk/objectanchors/Azure.MixedReality.ObjectAnchors.Conversion/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## 0.3.0-beta.3 (Unreleased)
44

55
### Features Added
6+
- Added `ScaledAssetDimensions` to `AssetConversionProperties`.
67

78
### Breaking Changes
89
- `OutputModelUri` now returns a `Uri` to a `.zip` file containing the `.ou` file instead of the `.ou` file itself when using the new default service version: `V0_3_preview_0`.

sdk/objectanchors/Azure.MixedReality.ObjectAnchors.Conversion/api/Azure.MixedReality.ObjectAnchors.Conversion.netstandard2.0.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ internal AssetConversionProperties() { }
5050
public System.Uri InputAssetUri { get { throw null; } }
5151
public System.Guid JobId { get { throw null; } set { } }
5252
public System.Uri OutputModelUri { get { throw null; } }
53+
public System.Numerics.Vector3? ScaledAssetDimensions { get { throw null; } }
5354
public string ServerErrorDetails { get { throw null; } }
5455
}
5556
public enum AssetConversionStatus
@@ -167,7 +168,7 @@ public enum ServiceVersion
167168
public static partial class ObjectAnchorsConversionModelFactory
168169
{
169170
public static Azure.MixedReality.ObjectAnchors.Conversion.AssetConversionConfiguration AssetConversionConfiguration(System.Numerics.Vector3 assetDimensions, System.Numerics.Vector3 boundingBoxCenter, System.Numerics.Vector3 gravity, System.Collections.Generic.IReadOnlyList<int> keyFrameIndexes, System.Collections.Generic.IReadOnlyList<Azure.MixedReality.ObjectAnchors.Conversion.TrajectoryPose> groundTruthTrajectoryCameraPoses, System.Numerics.Quaternion principalAxis, float scale, System.Numerics.Vector4 supportingPlane, System.Collections.Generic.IReadOnlyList<Azure.MixedReality.ObjectAnchors.Conversion.TrajectoryPose> testTrajectoryCameraPoses) { throw null; }
170-
public static Azure.MixedReality.ObjectAnchors.Conversion.AssetConversionProperties AssetConversionProperties(string clientErrorDetails, string serverErrorDetails, Azure.MixedReality.ObjectAnchors.Conversion.ConversionErrorCode conversionErrorCode, System.Guid? jobId, System.Uri outputModelUri, Azure.MixedReality.ObjectAnchors.Conversion.AssetConversionStatus? assetConversionStatus, Azure.MixedReality.ObjectAnchors.Conversion.AssetFileType assetFileType, System.Uri uploadedInputAssetUri, System.Guid? accountId, Azure.MixedReality.ObjectAnchors.Conversion.AssetConversionConfiguration assetConversionConfiguration) { throw null; }
171+
public static Azure.MixedReality.ObjectAnchors.Conversion.AssetConversionProperties AssetConversionProperties(string clientErrorDetails, string serverErrorDetails, Azure.MixedReality.ObjectAnchors.Conversion.ConversionErrorCode conversionErrorCode, System.Guid? jobId, System.Uri outputModelUri, Azure.MixedReality.ObjectAnchors.Conversion.AssetConversionStatus? assetConversionStatus, Azure.MixedReality.ObjectAnchors.Conversion.AssetFileType assetFileType, System.Uri uploadedInputAssetUri, System.Guid? accountId, Azure.MixedReality.ObjectAnchors.Conversion.AssetConversionConfiguration assetConversionConfiguration, System.Numerics.Vector3 scaledAssetDimensions) { throw null; }
171172
public static Azure.MixedReality.ObjectAnchors.Conversion.AssetUploadUriResult GetAssetUploadUriResult(System.Uri uploadedInputAssetUri) { throw null; }
172173
public static Azure.MixedReality.ObjectAnchors.Conversion.TrajectoryPose TrajectoryPose(System.Numerics.Quaternion rotation, System.Numerics.Vector3 translation) { throw null; }
173174
}

sdk/objectanchors/Azure.MixedReality.ObjectAnchors.Conversion/src/Customizations/Models/AssetConversionProperties.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,11 @@ internal set
7575
/// </summary>
7676
public Guid AccountId { get => AccountIdInternal.GetValueOrDefault(); set => AccountIdInternal = value; }
7777

78+
/// <summary>
79+
/// The scaled dimensions of the asset.
80+
/// </summary>
81+
public System.Numerics.Vector3? ScaledAssetDimensions { get => ScaledAssetDimensionsWrapper == null ? null : ScaledAssetDimensionsWrapper; }
82+
7883
[CodeGenMember("OutputModelUri")]
7984
internal string OutputModelUriString { get; }
8085

@@ -89,5 +94,8 @@ internal set
8994

9095
[CodeGenMember("AccountId")]
9196
internal Guid? AccountIdInternal { get; set; }
97+
98+
[CodeGenMember("ScaledAssetDimensions")]
99+
internal Vector3 ScaledAssetDimensionsWrapper { get; set; }
92100
}
93101
}

sdk/objectanchors/Azure.MixedReality.ObjectAnchors.Conversion/src/Generated/BlobUploadEndpointRestClient.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/objectanchors/Azure.MixedReality.ObjectAnchors.Conversion/src/Generated/IngestionJobRestClient.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/objectanchors/Azure.MixedReality.ObjectAnchors.Conversion/src/Generated/Models/AssetConversionProperties.Serialization.cs

Lines changed: 13 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/objectanchors/Azure.MixedReality.ObjectAnchors.Conversion/src/Generated/Models/AssetConversionProperties.cs

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/objectanchors/Azure.MixedReality.ObjectAnchors.Conversion/src/ObjectAnchorsConversionModelFactory.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ public static AssetConversionConfiguration AssetConversionConfiguration(
5252
/// <param name="uploadedInputAssetUri"> The Uri to the Asset to be ingested by the AOA Asset Conversion Service. This asset needs to have been uploaded to the service using an endpoint provided from a call to the GetUploadUri API. </param>
5353
/// <param name="accountId"> Identifier for the Account owning the AOA asset conversion Job. </param>
5454
/// <param name="assetConversionConfiguration"> The configuration of the AOA asset conversion job. </param>
55+
/// <param name="scaledAssetDimensions">The scaled dimensions of the asset.</param>
5556
/// <returns> A new instance of the <see cref="AssetConversionProperties"/> for mocking purposes. </returns>
5657
public static AssetConversionProperties AssetConversionProperties(
5758
string clientErrorDetails,
@@ -63,7 +64,8 @@ public static AssetConversionProperties AssetConversionProperties(
6364
AssetFileType assetFileType,
6465
Uri uploadedInputAssetUri,
6566
Guid? accountId,
66-
AssetConversionConfiguration assetConversionConfiguration)
67+
AssetConversionConfiguration assetConversionConfiguration,
68+
System.Numerics.Vector3 scaledAssetDimensions)
6769
{
6870
return new AssetConversionProperties(
6971
clientErrorDetails,
@@ -75,7 +77,8 @@ public static AssetConversionProperties AssetConversionProperties(
7577
assetFileType.ToString(),
7678
uploadedInputAssetUri.AbsoluteUri,
7779
accountId,
78-
assetConversionConfiguration);
80+
assetConversionConfiguration,
81+
new Vector3(scaledAssetDimensions));
7982
}
8083

8184
/// <summary>

sdk/objectanchors/Azure.MixedReality.ObjectAnchors.Conversion/src/autorest.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ Run `dotnet build /t:GenerateCode` to generate code.
44

55
``` yaml
66
input-file:
7-
- https://raw.githubusercontent.com/Azure/azure-rest-api-specs/5e3607a19fee8f1f12b9bc9cdfc0b684ac8e1cb8/specification/mixedreality/data-plane/Microsoft.MixedReality/preview/0.3-preview.0/mr-aoa.json
7+
- https://raw.githubusercontent.com/Azure/azure-rest-api-specs/508692ba774b8909a3cd8673dfeb8c0fa81721af/specification/mixedreality/data-plane/Microsoft.MixedReality/preview/0.3-preview.1/mr-aoa.json
88
generation1-convenience-client: true
99
```

0 commit comments

Comments
 (0)