Use TrySetCanceled and TrySetResult to avoid finalizing the task twice (Azure#37984)

elanmart · web-flow · commit 9d1c01a9bdf0 · 2023-08-02T11:35:00.000-07:00
diff --git a/sdk/openai/Azure.AI.OpenAI/src/Helpers/AsyncAutoResetEvent.cs b/sdk/openai/Azure.AI.OpenAI/src/Helpers/AsyncAutoResetEvent.cs
@@ -25,7 +25,7 @@ public Task WaitAsync(CancellationToken cancellationToken = default)
                 else
                 {
                     var tcs = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
-                    cancellationToken.Register(() => tcs?.SetCanceled());
+                    cancellationToken.Register(() => tcs?.TrySetCanceled());
                     _waits.Enqueue(tcs);
                     return tcs.Task;
                 }
@@ -42,7 +42,7 @@ public void Set()
                 else if (!_signaled)
                     _signaled = true;
             }
-            toRelease?.SetResult(true);
+            toRelease?.TrySetResult(true);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ public Task WaitAsync(CancellationToken cancellationToken = default)`
`25`	`25`	`else`
`26`	`26`	`{`
`27`	`27`	`var tcs = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);`
`28`		`- cancellationToken.Register(() => tcs?.SetCanceled());`
	`28`	`+ cancellationToken.Register(() => tcs?.TrySetCanceled());`
`29`	`29`	`_waits.Enqueue(tcs);`
`30`	`30`	`return tcs.Task;`
`31`	`31`	`}`
`@@ -42,7 +42,7 @@ public void Set()`
`42`	`42`	`else if (!_signaled)`
`43`	`43`	`_signaled = true;`
`44`	`44`	`}`
`45`		`- toRelease?.SetResult(true);`
	`45`	`+ toRelease?.TrySetResult(true);`
`46`	`46`	`}`
`47`	`47`	`}`
`48`	`48`	`}`