Register new mgmt sdk to core client (Azure#35722)

* typespec renaming for unified pipeline

* register mgmt sdk to mgmt core client

* add test

* use for instead of foreach

* normalize the path

* remove unused code

* share the common function to remove duplicate

Author: chunyu3

eng/scripts/Update-Mgmt-CI.ps1

@@ -1,3 +1,5 @@
+. (Join-Path $PSScriptRoot automation GenerateAndBuildLib.ps1)
+
 $packagesPath = "$PSScriptRoot/../../sdk"
 
 $track2MgmtDirs = Get-ChildItem -Path "$packagesPath" -Directory -Recurse -Depth 1 | Where-Object { $_.Name -match "(Azure.ResourceManager.)" -and $(Test-Path("$($_.FullName)/src")) }
@@ -94,33 +96,5 @@ foreach($mgmtDir in $track2MgmtDirs) {
 
 Write-Host "Updating mgmt core client ci.mgmt.yml"
 #add path for each mgmt library into Azure.ResourceManager
-$armCiFile = "$packagesPath/resourcemanager/ci.mgmt.yml"
-$armLines = Get-Content $armCiFile
-$newLines = [System.Collections.ArrayList]::new()
-$startIndex = $track2MgmtDirs[0].FullName.IndexOf(("\sdk\")) + 1
-$shouldRemove = $false
-foreach($line in $armLines) {
-    if($line.StartsWith("  paths:")) {
-        $newLines.Add($line) | Out-Null
-        $newLines.Add("    include:") | Out-Null
-        $newLines.Add("    - sdk/resourcemanager") | Out-Null
-        $newLines.Add("    - common/ManagementTestShared") | Out-Null
-        $newLines.Add("    - common/ManagementCoreShared") | Out-Null
-        foreach($dir in $track2MgmtDirs) {
-            $newLine = "    - $($dir.FullName.Substring($startIndex, $dir.FullName.Length - $startIndex).Replace('\', '/'))"
-            $newLines.Add($newLine) | Out-Null
-        }
-        $shouldRemove = $true
-        Continue
-    }
+RegisterMgmtSDKToMgmtCoreClient -packagesPath $packagesPath
 
-    if($shouldRemove) {
-        if($line.StartsWith(" ")) {
-            Continue
-        }
-        $shouldRemove = $false
-    }
-
-    $newLines.Add($line) | Out-Null
-}
-Set-Content -Path $armCiFile $newLines

eng/scripts/automation/GenerateAndBuildLib.ps1

@@ -5,7 +5,7 @@ $TSP_LOCATION_FILE = "tsp-location.yaml"
 . (Join-Path $PSScriptRoot ".." ".." "common" "scripts" "Helpers" PSModule-Helpers.ps1)
 
 #mgmt: swagger directory name to sdk directory name map
-$packageNameHash = [ordered]@{"vmware" = "avs"; 
+$packageNameHash = [ordered]@{"vmware" = "avs";
     "azure-kusto" = "kusto";
     "cosmos-db" = "cosmosdb";
     "msi" = "managedserviceidentity";
@@ -55,7 +55,7 @@ function Get-SwaggerInfo()
 create or update the autorest config file for sdk (autorest.md)
 
 .DESCRIPTION
-1. update input-file or require block according to the input parameter. If readme parameter is provided, autorest.md will 
+1. update input-file or require block according to the input parameter. If readme parameter is provided, autorest.md will
 contain only require block, if input-file parameter is provided, autorest.md will contain only require block.
 2. merge the autorestConfig to the autorest.md
 
@@ -111,9 +111,9 @@ function CreateOrUpdateAutorestConfigFile() {
 
             $inputRegex = "(?:(?:input-file|require)\s*:\s*\r?\n(?:\s*-\s+.*\r?\n)+|(?:input-file|require):\s+.*)"
             $fileContent = $fileContent -replace $inputRegex, $configline
-            $fileContent | Set-Content $autorestFilePath    
+            $fileContent | Set-Content $autorestFilePath
         }
-        
+
         # update autorest.md with configuration
         if ( $autorestConfigYaml) {
             Write-Host "Update autorest.md with configuration."
@@ -153,7 +153,7 @@ function CreateOrUpdateAutorestConfigFile() {
             Throw "autorest.md does not exist, and no autorest configuration to create one."
         }
     }
-} 
+}
 
 function Update-CIYmlFile() {
     param (
@@ -177,6 +177,44 @@ function Update-CIYmlFile() {
     }
 }
 
+function RegisterMgmtSDKToMgmtCoreClient () {
+    param(
+        [string]$packagesPath
+    )
+    $track2MgmtDirs = Get-ChildItem -Path "$packagesPath" -Directory -Recurse -Depth 1 | Where-Object { $_.Name -match "(Azure.ResourceManager.)" -and $(Test-Path("$($_.FullName)/src")) }
+    Write-Host "Updating mgmt core client ci.mgmt.yml"
+    #add path for each mgmt library into Azure.ResourceManager
+    $armCiFile = "$packagesPath/resourcemanager/ci.mgmt.yml"
+    $armLines = Get-Content $armCiFile
+    $newLines = [System.Collections.ArrayList]::new()
+    $startIndex = $track2MgmtDirs[0].FullName.Replace('\', '/').IndexOf(("/sdk/")) + 1
+    $shouldRemove = $false
+    foreach($line in $armLines) {
+        if($line.StartsWith("  paths:")) {
+            $newLines.Add($line) | Out-Null
+            $newLines.Add("    include:") | Out-Null
+            $newLines.Add("    - sdk/resourcemanager") | Out-Null
+            $newLines.Add("    - common/ManagementTestShared") | Out-Null
+            $newLines.Add("    - common/ManagementCoreShared") | Out-Null
+            foreach($dir in $track2MgmtDirs) {
+                $newLine = "    - $($dir.FullName.Replace('\', '/').Substring($startIndex, $dir.FullName.Length - $startIndex))"
+                $newLines.Add($newLine) | Out-Null
+            }
+            $shouldRemove = $true
+            Continue
+        }
+
+        if($shouldRemove) {
+            if($line.StartsWith(" ")) {
+                Continue
+            }
+            $shouldRemove = $false
+        }
+
+        $newLines.Add($line) | Out-Null
+    }
+    Set-Content -Path $armCiFile $newLines
+}
 <#
 .SYNOPSIS
 Prepare the SDK pacakge for data-plane.
@@ -310,7 +348,7 @@ function New-MgmtPackageFolder() {
         [string]$AUTOREST_CONFIG_FILE = "autorest.md",
         [string]$outputJsonFile = "newPacakgeOutput.json"
     )
-  
+
     if ($packageName -eq "") {
         $packageName = $service
     }
@@ -334,8 +372,11 @@ function New-MgmtPackageFolder() {
       Push-Location $projectFolder
       dotnet new azuremgmt --provider $packageName --includeCI true --force
       Pop-Location
+
+      $packagesPath = Join-Path $sdkPath "sdk"
+      RegisterMgmtSDKToMgmtCoreClient -packagesPath $packagesPath
     }
-  
+
     # update the readme path.
     if ($readme) {
       Write-Host "Updating autorest.md file."
@@ -344,19 +385,19 @@ function New-MgmtPackageFolder() {
       $file="$projectFolder/src/$AUTOREST_CONFIG_FILE"
       (Get-Content $file) -replace $rquirefileRex, "$requirefile" | Set-Content $file
     }
-  
+
     Push-Location $sdkPath
     $relativeFolderPath = Resolve-Path $projectFolder -Relative
     Pop-Location
-  
+
     $outputJson = [PSCustomObject]@{
       service = $service
       packageName = $mgmtPackageName
       projectFolder = $projectFolder
       path = @($relativeFolderPath)
     }
     $outputJson | ConvertTo-Json -depth 100 | Out-File $outputJsonFile
-  
+
     return $projectFolder
 }
 
@@ -368,7 +409,7 @@ function CreateOrUpdateTypeSpecConfigFile() {
         [string]$repo = "",
         [string]$specRoot = "",
         [string]$additionalSubDirectories="" #additional directories needed, separated by semicolon if more than one
-        
+
     )
     if (!(Test-Path -Path $typespecConfigurationFile)) {
         New-Item -Path $typespecConfigurationFile
@@ -433,15 +474,15 @@ function New-TypeSpecPackageFolder() {
         if (Test-Path -Path $projectFolder/src/autorest.md) {
             Remove-Item -Path $projectFolder/src/autorest.md
         }
-        
+
         CreateOrUpdateTypeSpecConfigFile `
             -typespecConfigurationFile $projectFolder/$TSP_LOCATION_FILE `
             -directory $relatedTypeSpecProjectFolder `
             -commit $commit `
             -repo $repo `
             -specRoot $specRoot `
             -additionalSubDirectories $additionalSubDirectories
-        
+
         Update-CIYmlFile -ciFilePath $ciymlFilePath -artifact $namespace
     } else {
         Write-Host "Path doesn't exist. create template."
@@ -461,7 +502,7 @@ function New-TypeSpecPackageFolder() {
         $clientName = $namespaceArray[-1]
         $groupName = $namespaceArray[1..$endIndex] -join "."
         $dotnetNewCmd = "dotnet new azsdkdpg --name $namespace --clientName $clientName --groupName $groupName --serviceDirectory $service --force"
-        
+
         if (Test-Path -Path $ciymlFilePath) {
             Write-Host "ci.yml already exists. update it to include the new serviceDirectory."
             Update-CIYmlFile -ciFilePath $ciymlFilePath -artifact $namespace
@@ -576,12 +617,12 @@ function Invoke-GenerateAndBuildSDK () {
     Write-Host "readmeFile:$readmeFile"
     $service, $serviceType = Get-ResourceProviderFromReadme $readmeFile
     Write-Host "service:$service, serviceType:$serviceType"
-    
+
     if (!$readmeFile.StartsWith("http") -And !(Test-Path -Path $readmeFile)) {
         Write-Error "readme file '$readmeFile' does not exist."
         exit 1
     }
-    
+
     $packagesToGen = @()
     $newPackageOutput = "newPackageOutput.json"
     if ( $serviceType -eq "resource-manager" ) {
@@ -747,7 +788,7 @@ function GeneratePackage()
             Remove-Item $logFilePath
         }
     }
-    
+
     $changelog = [PSCustomObject]@{
         content           = $content
         hasBreakingChange = $hasBreakingChange
@@ -778,7 +819,7 @@ function GeneratePackage()
     if ( $serviceType -eq "resource-manager" ) {
         $ciFilePath = "sdk/$service/ci.mgmt.yml"
     }
-    $generatedSDKPackages.Add(@{packageName="$packageName"; 
+    $generatedSDKPackages.Add(@{packageName="$packageName";
                                 result=$result;
                                 path=@("$path", "$ciFilePath");
                                 packageFolder="$projectFolder";
@@ -801,7 +842,7 @@ function UpdateExistingSDKByInputFiles()
 
     $autorestFilesPath = Get-ChildItem -Path "$sdkRootPath/sdk"  -Filter autorest.md -Recurse | Resolve-Path -Relative
     Write-Host "Updating autorest.md files for all the changed swaggers."
-    
+
     $sdksInfo = @{}
     $regexToFindSha = "https:\/\/[^`"]*[\/][0-9a-f]{4,40}[\/]"
     foreach ($path in $autorestFilesPath) {
@@ -834,5 +875,5 @@ function UpdateExistingSDKByInputFiles()
         $projectFolder = Resolve-Path -Path $projectFolder
         GeneratePackage -projectFolder $projectFolder -sdkRootPath $sdkRootPath -path $path -downloadUrlPrefix "$downloadUrlPrefix" -serviceType $serviceType -generatedSDKPackages $generatedSDKPackages
     }
-    
+
 }