Modified set method response to no longer contain the raw content of the Http response. (Azure#33850)

Author: jiriburant

sdk/communication/Azure.Communication.PhoneNumbers/src/SipRouting/Generated/Models/CommunicationError.cs

@@ -172,8 +172,7 @@ public virtual Response SetTrunk(
             scope.Start();
             try
             {
-                var response = _restClient.PatchSipConfiguration(config, cancellationToken);
-                return response.GetRawResponse();
+                return _restClient.PatchSipConfiguration(config, cancellationToken);
             }
             catch (Exception ex)
             {
@@ -197,8 +196,7 @@ public virtual async Task<Response> SetTrunkAsync(
             scope.Start();
             try
             {
-                var response = await _restClient.PatchSipConfigurationAsync(config, cancellationToken).ConfigureAwait(false);
-                return response.GetRawResponse();
+                return await _restClient.PatchSipConfigurationAsync(config, cancellationToken).ConfigureAwait(false);
             }
             catch (Exception ex)
             {
@@ -222,8 +220,7 @@ public virtual Response DeleteTrunk(
             scope.Start();
             try
             {
-                var response = _restClient.PatchSipConfiguration(removeConfig, cancellationToken);
-                return response.GetRawResponse();
+                return _restClient.PatchSipConfiguration(removeConfig, cancellationToken);
             }
             catch (Exception ex)
             {
@@ -247,8 +244,7 @@ public virtual async Task<Response> DeleteTrunkAsync(
             scope.Start();
             try
             {
-                var response = await _restClient.PatchSipConfigurationAsync(removeConfig, cancellationToken).ConfigureAwait(false);
-                return response.GetRawResponse();
+                return await _restClient.PatchSipConfigurationAsync(removeConfig, cancellationToken).ConfigureAwait(false);
             }
             catch (Exception ex)
             {
@@ -376,8 +372,7 @@ public virtual Response SetTrunks(
                     return currentConfig.GetRawResponse();
                 }
 
-                var response = _restClient.PatchSipConfiguration(new SipConfiguration(newTrunks), cancellationToken);
-                return response.GetRawResponse();
+                return _restClient.PatchSipConfiguration(new SipConfiguration(newTrunks), cancellationToken);
             }
             catch (Exception ex)
             {
@@ -417,8 +412,7 @@ public virtual async Task<Response> SetTrunksAsync(
                     return currentConfig.GetRawResponse();
                 }
 
-                var response = await _restClient.PatchSipConfigurationAsync(new SipConfiguration(newTrunks), cancellationToken).ConfigureAwait(false);
-                return response.GetRawResponse();
+                return await _restClient.PatchSipConfigurationAsync(new SipConfiguration(newTrunks), cancellationToken).ConfigureAwait(false);
             }
             catch (Exception ex) {
                 scope.Failed(ex);
@@ -441,7 +435,8 @@ public virtual Response SetRoutes(
             {
                 var config = new SipConfiguration(routes);
                 var response = _restClient.PatchSipConfiguration(config, cancellationToken);
-                return response.GetRawResponse();
+
+                return response;
             }
             catch (Exception ex)
             {
@@ -464,8 +459,7 @@ public virtual async Task<Response> SetRoutesAsync(
             try
             {
                 var config = new SipConfiguration(routes);
-                var response = await _restClient.PatchSipConfigurationAsync(config, cancellationToken).ConfigureAwait(false);
-                return response.GetRawResponse();
+                return await _restClient.PatchSipConfigurationAsync(config, cancellationToken).ConfigureAwait(false);
             }
             catch (Exception ex)
             {

sdk/communication/Azure.Communication.PhoneNumbers/src/SipRouting/Generated/Models/CommunicationErrorResponse.cs

@@ -2,6 +2,9 @@
 // Licensed under the MIT License.
 
 using System.IO;
+using System.Text.Json;
+using System.Threading.Tasks;
+using System.Threading;
 using Azure.Core;
 
 namespace Azure.Communication.PhoneNumbers.SipRouting
@@ -15,9 +18,9 @@ internal HttpMessage CreatePatchSipConfigurationRequest(SipConfiguration body)
             var request = message.Request;
             request.Method = RequestMethod.Patch;
             var uri = new RawRequestUriBuilder();
-            uri.AppendRaw(endpoint, false);
+            uri.AppendRaw(_endpoint, false);
             uri.AppendPath("/sip", false);
-            uri.AppendQuery("api-version", apiVersion, true);
+            uri.AppendQuery("api-version", _apiVersion, true);
             request.Uri = uri;
             request.Headers.Add("Accept", "application/json");
             if (body != null)
@@ -29,5 +32,55 @@ internal HttpMessage CreatePatchSipConfigurationRequest(SipConfiguration body)
             }
             return message;
         }
+
+        /// <summary> Patches SIP configuration for resource. </summary>
+        /// <param name="body"> Configuration patch. </param>
+        /// <param name="cancellationToken"> The cancellation token to use. </param>
+        public async Task<Response> PatchSipConfigurationAsync(SipConfiguration body = null, CancellationToken cancellationToken = default)
+        {
+            using var message = CreatePatchSipConfigurationRequest(body);
+            await _pipeline.SendAsync(message, cancellationToken).ConfigureAwait(false);
+            switch (message.Response.Status)
+            {
+                case 200:
+                    {
+                        SipConfiguration value = default;
+                        using var document = await JsonDocument.ParseAsync(message.Response.ContentStream, default, cancellationToken).ConfigureAwait(false);
+                        value = SipConfiguration.DeserializeSipConfiguration(document.RootElement);
+                        var response = Response.FromValue(value, message.Response);
+                        Response mappedResponse = response.GetRawResponse();
+                        mappedResponse.ContentStream = null;
+
+                        return mappedResponse;
+                    }
+                default:
+                    throw await ClientDiagnostics.CreateRequestFailedExceptionAsync(message.Response).ConfigureAwait(false);
+            }
+        }
+
+        /// <summary> Patches SIP configuration for resource. </summary>
+        /// <param name="body"> Configuration patch. </param>
+        /// <param name="cancellationToken"> The cancellation token to use. </param>
+        public Response PatchSipConfiguration(SipConfiguration body = null, CancellationToken cancellationToken = default)
+        {
+            using var message = CreatePatchSipConfigurationRequest(body);
+            _pipeline.Send(message, cancellationToken);
+            switch (message.Response.Status)
+            {
+                case 200:
+                    {
+                        SipConfiguration value = default;
+                        using var document = JsonDocument.Parse(message.Response.ContentStream);
+                        value = SipConfiguration.DeserializeSipConfiguration(document.RootElement);
+                        var response = Response.FromValue(value, message.Response);
+                        Response mappedResponse = response.GetRawResponse();
+                        mappedResponse.ContentStream = null;
+
+                        return mappedResponse;
+                    }
+                default:
+                    throw ClientDiagnostics.CreateRequestFailedException(message.Response);
+            }
+        }
     }
 }