Azure.Identity Prepare release (Azure#38195)

christothes · web-flow · commit 21c6d8cfd1d2 · 2023-08-14T20:59:48.000Z
diff --git a/sdk/identity/Azure.Identity/CHANGELOG.md b/sdk/identity/Azure.Identity/CHANGELOG.md
@@ -1,24 +1,20 @@
 # Release History
 
-## 1.10.0-beta.2 (Unreleased)
+## 1.10.0 (2023-08-14)
 
 ### Features Added
 - Added `BrowserCustomization` property to `InteractiveBrowserCredential` to enable web view customization for interactive authentication.
 
-### Breaking Changes
-
 ### Bugs Fixed
 
 - ManagedIdentityCredential will no longer attempt to parse invalid json payloads on responses from the managed identity endpoint.
 - Fixed an issue where AzurePowerShellCredential fails to parse the token response from Azure PowerShell. [#22638](https://github.com/Azure/azure-sdk-for-net/issues/22638)
 
-### Other Changes
-
 ## 1.10.0-beta.1 (2023-07-17)
 
 ### Features Added
 - Continuous Access Evaluation (CAE) is now configurable per-request by setting the `IsCaeEnabled` property of `TokenRequestContext` via its constructor.
-- Added `IsSupportLoggingEnabled` property to `TokenCredentialOptions` which equates to passing 'true' for the `enablePiiLogging` parameter to the 'WithLogging' method on the MSAL client builder.
+- Added `IsUnsafeSupportLoggingEnabled` property to `TokenCredentialOptions` which equates to passing 'true' for the `enablePiiLogging` parameter to the 'WithLogging' method on the MSAL client builder.
 
 ### Bugs Fixed
 - Fixed an issue with `TokenCachePersistenceOptions` where credentials in the same process would share the same cache, even if they had different configured names.
diff --git a/sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs b/sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs
@@ -373,7 +373,7 @@ public partial class TokenCredentialOptions : Azure.Core.ClientOptions
         public TokenCredentialOptions() { }
         public System.Uri AuthorityHost { get { throw null; } set { } }
         public new Azure.Identity.TokenCredentialDiagnosticsOptions Diagnostics { get { throw null; } }
-        public bool IsSupportLoggingEnabled { get { throw null; } set { } }
+        public bool IsUnsafeSupportLoggingEnabled { get { throw null; } set { } }
     }
     public abstract partial class UnsafeTokenCacheOptions : Azure.Identity.TokenCachePersistenceOptions
     {
diff --git a/sdk/identity/Azure.Identity/src/Azure.Identity.csproj b/sdk/identity/Azure.Identity/src/Azure.Identity.csproj
@@ -2,7 +2,7 @@
   <PropertyGroup>
     <Description>This is the implementation of the Azure SDK Client Library for Azure Identity</Description>
     <AssemblyTitle>Microsoft Azure.Identity Component</AssemblyTitle>
-    <Version>1.10.0-beta.2</Version>
+    <Version>1.10.0</Version>
     <!--The ApiCompatVersion is managed automatically and should not generally be modified manually.-->
     <ApiCompatVersion>1.9.0</ApiCompatVersion>
     <PackageTags>Microsoft Azure Identity;$(PackageCommonTags)</PackageTags>
diff --git a/sdk/identity/Azure.Identity/src/Credentials/AzureCliCredential.cs b/sdk/identity/Azure.Identity/src/Credentials/AzureCliCredential.cs
@@ -68,7 +68,7 @@ public AzureCliCredential(AzureCliCredentialOptions options)
 
         internal AzureCliCredential(CredentialPipeline pipeline, IProcessService processService, AzureCliCredentialOptions options = null)
         {
-            _logPII = options?.IsSupportLoggingEnabled ?? false;
+            _logPII = options?.IsUnsafeSupportLoggingEnabled ?? false;
             _logAccountDetails = options?.Diagnostics?.IsAccountIdentifierLoggingEnabled ?? false;
             _pipeline = pipeline;
             _path = !string.IsNullOrEmpty(EnvironmentVariables.Path) ? EnvironmentVariables.Path : DefaultPath;
diff --git a/sdk/identity/Azure.Identity/src/Credentials/AzureDeveloperCliCredential.cs b/sdk/identity/Azure.Identity/src/Credentials/AzureDeveloperCliCredential.cs
@@ -61,7 +61,7 @@ public AzureDeveloperCliCredential(AzureDeveloperCliCredentialOptions options)
 
         internal AzureDeveloperCliCredential(CredentialPipeline pipeline, IProcessService processService, AzureDeveloperCliCredentialOptions options = null)
         {
-            _logPII = options?.IsSupportLoggingEnabled ?? false;
+            _logPII = options?.IsUnsafeSupportLoggingEnabled ?? false;
             _logAccountDetails = options?.Diagnostics?.IsAccountIdentifierLoggingEnabled ?? false;
             _pipeline = pipeline;
             _processService = processService ?? ProcessService.Default;
diff --git a/sdk/identity/Azure.Identity/src/Credentials/AzurePowerShellCredential.cs b/sdk/identity/Azure.Identity/src/Credentials/AzurePowerShellCredential.cs
@@ -61,7 +61,7 @@ public AzurePowerShellCredential(AzurePowerShellCredentialOptions options) : thi
         internal AzurePowerShellCredential(AzurePowerShellCredentialOptions options, CredentialPipeline pipeline, IProcessService processService)
         {
             UseLegacyPowerShell = false;
-            _logPII = options?.IsSupportLoggingEnabled ?? false;
+            _logPII = options?.IsUnsafeSupportLoggingEnabled ?? false;
             _logAccountDetails = options?.Diagnostics?.IsAccountIdentifierLoggingEnabled ?? false;
             TenantId = options?.TenantId;
             _pipeline = pipeline ?? CredentialPipeline.GetInstance(options);
diff --git a/sdk/identity/Azure.Identity/src/Credentials/TokenCredentialOptions.cs b/sdk/identity/Azure.Identity/src/Credentials/TokenCredentialOptions.cs
@@ -37,7 +37,7 @@ public Uri AuthorityHost
         /// the <see cref="DiagnosticsOptions.IsLoggingContentEnabled"/> property must be set to <c>true</c>.
         /// Setting this property to `true` equates to passing 'true' for the enablePiiLogging parameter to the 'WithLogging' method on the MSAL client builder.
         /// </summary>
-        public bool IsSupportLoggingEnabled { get; set; }
+        public bool IsUnsafeSupportLoggingEnabled { get; set; }
 
         /// <summary>
         /// Gets or sets whether this credential is part of a chained credential.
@@ -52,7 +52,7 @@ internal virtual T Clone<T>()
             // copy TokenCredentialOptions Properties
             clone.AuthorityHost = AuthorityHost;
 
-            clone.IsSupportLoggingEnabled = IsSupportLoggingEnabled;
+            clone.IsUnsafeSupportLoggingEnabled = IsUnsafeSupportLoggingEnabled;
 
             // copy TokenCredentialDiagnosticsOptions specific options
             clone.Diagnostics.IsAccountIdentifierLoggingEnabled = Diagnostics.IsAccountIdentifierLoggingEnabled;
diff --git a/sdk/identity/Azure.Identity/src/Credentials/VisualStudioCredential.cs b/sdk/identity/Azure.Identity/src/Credentials/VisualStudioCredential.cs
@@ -53,7 +53,7 @@ public VisualStudioCredential(VisualStudioCredentialOptions options) : this(opti
 
         internal VisualStudioCredential(string tenantId, CredentialPipeline pipeline, IFileSystemService fileSystem, IProcessService processService, VisualStudioCredentialOptions options = null)
         {
-            _logPII = options?.IsSupportLoggingEnabled ?? false;
+            _logPII = options?.IsUnsafeSupportLoggingEnabled ?? false;
             _logAccountDetails = options?.Diagnostics?.IsAccountIdentifierLoggingEnabled ?? false;
             TenantId = tenantId;
             _pipeline = pipeline ?? CredentialPipeline.GetInstance(null);
diff --git a/sdk/identity/Azure.Identity/src/MsalClientBase.cs b/sdk/identity/Azure.Identity/src/MsalClientBase.cs
@@ -44,7 +44,7 @@ protected MsalClientBase(CredentialPipeline pipeline, string tenantId, string cl
             DisableInstanceDiscovery = options is ISupportsDisableInstanceDiscovery supportsDisableInstanceDiscovery && supportsDisableInstanceDiscovery.DisableInstanceDiscovery;
             ISupportsTokenCachePersistenceOptions cacheOptions = options as ISupportsTokenCachePersistenceOptions;
             _tokenCachePersistenceOptions = cacheOptions?.TokenCachePersistenceOptions;
-            IsSupportLoggingEnabled = options?.IsSupportLoggingEnabled ?? false;
+            IsSupportLoggingEnabled = options?.IsUnsafeSupportLoggingEnabled ?? false;
             Pipeline = pipeline;
             TenantId = tenantId;
             ClientId = clientId;
diff --git a/sdk/identity/Azure.Identity/tests/AuthorizationCodeCredentialTests.cs b/sdk/identity/Azure.Identity/tests/AuthorizationCodeCredentialTests.cs
@@ -33,7 +33,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
                 Transport = config.Transport,
                 DisableInstanceDiscovery = config.DisableInstanceDiscovery,
                 AdditionallyAllowedTenants = config.AdditionallyAllowedTenants,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
             };
             var pipeline = CredentialPipeline.GetInstance(options);
             return InstrumentClient(
diff --git a/sdk/identity/Azure.Identity/tests/AzureCliCredentialTests.cs b/sdk/identity/Azure.Identity/tests/AzureCliCredentialTests.cs
@@ -32,7 +32,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
             {
                 AdditionallyAllowedTenants = config.AdditionallyAllowedTenants,
                 TenantId = config.TenantId,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
             };
             var (_, _, processOutput) = CredentialTestHelpers.CreateTokenForAzureCli();
             var testProcess = new TestProcess { Output = processOutput };
diff --git a/sdk/identity/Azure.Identity/tests/AzureDeveloperCliCredentialTests.cs b/sdk/identity/Azure.Identity/tests/AzureDeveloperCliCredentialTests.cs
@@ -32,7 +32,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
             {
                 AdditionallyAllowedTenants = config.AdditionallyAllowedTenants,
                 TenantId = config.TenantId,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
             };
             var (_, _, processOutput) = CredentialTestHelpers.CreateTokenForAzureDeveloperCli();
             var testProcess = new TestProcess { Output = processOutput };
diff --git a/sdk/identity/Azure.Identity/tests/AzurePowerShellCredentialsTests.cs b/sdk/identity/Azure.Identity/tests/AzurePowerShellCredentialsTests.cs
@@ -41,7 +41,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
             {
                 AdditionallyAllowedTenants = config.AdditionallyAllowedTenants,
                 TenantId = config.TenantId,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
             };
             var (_, _, processOutput) = CredentialTestHelpers.CreateTokenForAzurePowerShell(TimeSpan.FromSeconds(30));
             var testProcess = new TestProcess { Output = processOutput };
diff --git a/sdk/identity/Azure.Identity/tests/ClientAssertionCredentialTests.cs b/sdk/identity/Azure.Identity/tests/ClientAssertionCredentialTests.cs
@@ -30,7 +30,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
                 Transport = config.Transport,
                 DisableInstanceDiscovery = config.DisableInstanceDiscovery,
                 AdditionallyAllowedTenants = config.AdditionallyAllowedTenants,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
             };
             var pipeline = CredentialPipeline.GetInstance(options);
             options.Pipeline = pipeline;
diff --git a/sdk/identity/Azure.Identity/tests/ClientCertificateCredentialTests.cs b/sdk/identity/Azure.Identity/tests/ClientCertificateCredentialTests.cs
@@ -41,7 +41,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
                 Transport = config.Transport,
                 DisableInstanceDiscovery = config.DisableInstanceDiscovery,
                 AdditionallyAllowedTenants = config.AdditionallyAllowedTenants,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
             };
             var pipeline = CredentialPipeline.GetInstance(options);
             var certificatePath = Path.Combine(TestContext.CurrentContext.TestDirectory, "Data", "cert.pfx");
diff --git a/sdk/identity/Azure.Identity/tests/ClientSecretCredentialTests.cs b/sdk/identity/Azure.Identity/tests/ClientSecretCredentialTests.cs
@@ -30,7 +30,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
                 Transport = config.Transport,
                 DisableInstanceDiscovery = config.DisableInstanceDiscovery,
                 AdditionallyAllowedTenants = config.AdditionallyAllowedTenants,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
             };
             var pipeline = CredentialPipeline.GetInstance(options);
             return InstrumentClient(new ClientSecretCredential(config.TenantId, ClientId, "secret", options, pipeline, null));
diff --git a/sdk/identity/Azure.Identity/tests/CredentialTestBase.cs b/sdk/identity/Azure.Identity/tests/CredentialTestBase.cs
@@ -115,7 +115,7 @@ public async Task RespectsIsSupportLoggingEnabled([Values(true, false)] bool isS
             {
                 Transport = mockTransport,
                 TenantId = TenantId,
-                IsSupportLoggingEnabled = isSupportLoggingEnabled
+                IsUnsafeSupportLoggingEnabled = isSupportLoggingEnabled
             };
             var credential = GetTokenCredential(config);
             if (!CredentialTestHelpers.IsMsalCredential(credential))
diff --git a/sdk/identity/Azure.Identity/tests/DeviceCodeCredentialTests.cs b/sdk/identity/Azure.Identity/tests/DeviceCodeCredentialTests.cs
@@ -65,7 +65,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
                 Transport = config.Transport,
                 AdditionallyAllowedTenants = config.AdditionallyAllowedTenants,
                 DisableInstanceDiscovery = config.DisableInstanceDiscovery,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
             };
             var pipeline = CredentialPipeline.GetInstance(options);
             return InstrumentClient(new DeviceCodeCredential((code, _) =>
diff --git a/sdk/identity/Azure.Identity/tests/EnvironmentCredential_ClientCertificateTests.cs b/sdk/identity/Azure.Identity/tests/EnvironmentCredential_ClientCertificateTests.cs
@@ -46,7 +46,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
                 {
                     Transport = config.Transport,
                     DisableInstanceDiscovery = config.DisableInstanceDiscovery,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
                 };
 
                 var pipeline = CredentialPipeline.GetInstance(options);
diff --git a/sdk/identity/Azure.Identity/tests/EnvironmentCredential_ClientSecretTests.cs b/sdk/identity/Azure.Identity/tests/EnvironmentCredential_ClientSecretTests.cs
@@ -46,7 +46,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
                 {
                     Transport = config.Transport,
                     DisableInstanceDiscovery = config.DisableInstanceDiscovery,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
                 };
 
                 var pipeline = CredentialPipeline.GetInstance(options);
diff --git a/sdk/identity/Azure.Identity/tests/EnvironmentCredential_UserNamePasswordTests.cs b/sdk/identity/Azure.Identity/tests/EnvironmentCredential_UserNamePasswordTests.cs
@@ -47,7 +47,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
                 {
                     Transport = config.Transport,
                     DisableInstanceDiscovery = config.DisableInstanceDiscovery,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
                 };
 
                 return InstrumentClient(new EnvironmentCredential(options));
diff --git a/sdk/identity/Azure.Identity/tests/InteractiveBrowserCredentialTests.cs b/sdk/identity/Azure.Identity/tests/InteractiveBrowserCredentialTests.cs
@@ -37,7 +37,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
                 TokenCachePersistenceOptions = tokenCacheOptions,
                 AdditionallyAllowedTenants = config.AdditionallyAllowedTenants,
                 AuthenticationRecord = new AuthenticationRecord(ExpectedUsername, "login.windows.net", $"{ObjectId}.{resolvedTenantId}", resolvedTenantId, ClientId),
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
             };
             var pipeline = CredentialPipeline.GetInstance(options);
             return InstrumentClient(new InteractiveBrowserCredential(config.TenantId, ClientId, options, pipeline, null) { _isCaeDisabledRequestCached = true, _isCaeEnabledRequestCached = true });
diff --git a/sdk/identity/Azure.Identity/tests/MsalClientBaseTests.cs b/sdk/identity/Azure.Identity/tests/MsalClientBaseTests.cs
@@ -39,13 +39,13 @@ public void LogPiiIsEnforcedPerInstance([Values(true, false)] bool logPii)
                 new CredentialPipeline(new HttpPipeline(new MockTransport()), new ClientDiagnostics(Moq.Mock.Of<ClientOptions>())),
                 "tenant",
                 "client",
-                new InteractiveBrowserCredentialOptions(){ IsSupportLoggingEnabled = logPii });
+                new InteractiveBrowserCredentialOptions(){ IsUnsafeSupportLoggingEnabled = logPii });
 
             var client_2 = new MockMsalClient(
                 new CredentialPipeline(new HttpPipeline(new MockTransport()), new ClientDiagnostics(Moq.Mock.Of<ClientOptions>())),
                 "tenant",
                 "client",
-                new InteractiveBrowserCredentialOptions(){ IsSupportLoggingEnabled = false }); // never log PII
+                new InteractiveBrowserCredentialOptions(){ IsUnsafeSupportLoggingEnabled = false }); // never log PII
 
             Assert.AreEqual(logPii, client_1.IsSupportLoggingEnabled);
 
diff --git a/sdk/identity/Azure.Identity/tests/OnBehalfOfCredentialTests.cs b/sdk/identity/Azure.Identity/tests/OnBehalfOfCredentialTests.cs
@@ -53,7 +53,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
                 Transport = config.Transport,
                 AdditionallyAllowedTenants = config.AdditionallyAllowedTenants,
                 DisableInstanceDiscovery = config.DisableInstanceDiscovery,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
             };
             var pipeline = CredentialPipeline.GetInstance(options);
             return InstrumentClient(
diff --git a/sdk/identity/Azure.Identity/tests/SharedTokenCacheCredentialTests.cs b/sdk/identity/Azure.Identity/tests/SharedTokenCacheCredentialTests.cs
@@ -34,7 +34,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
             {
                 Transport = config.Transport,
                 DisableInstanceDiscovery = config.DisableInstanceDiscovery,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
             };
             var pipeline = CredentialPipeline.GetInstance(options);
             return InstrumentClient(new SharedTokenCacheCredential(config.TenantId, null, options, pipeline, null));
diff --git a/sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs b/sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs
@@ -250,7 +250,7 @@ public static T CreatePopulatedOptions<T>(bool setTransport)
                     DisableInstanceDiscovery = true,
                     TokenCachePersistenceOptions = new TokenCachePersistenceOptions(),
                     AuthorityHost = AzureAuthorityHosts.AzureChina,
-                    IsSupportLoggingEnabled = true,
+                    IsUnsafeSupportLoggingEnabled = true,
                     Retry =
                     {
                         MaxRetries = 15,
diff --git a/sdk/identity/Azure.Identity/tests/UsernamePasswordCredentialTests.cs b/sdk/identity/Azure.Identity/tests/UsernamePasswordCredentialTests.cs
@@ -35,7 +35,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
                 Transport = config.Transport,
                 DisableInstanceDiscovery = config.DisableInstanceDiscovery,
                 AdditionallyAllowedTenants = config.AdditionallyAllowedTenants,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
             };
             var pipeline = CredentialPipeline.GetInstance(options);
             return InstrumentClient(new UsernamePasswordCredential("user", "password", config.TenantId, ClientId, options, pipeline, null));
diff --git a/sdk/identity/Azure.Identity/tests/VisualStudioCredentialTests.cs b/sdk/identity/Azure.Identity/tests/VisualStudioCredentialTests.cs
@@ -38,7 +38,7 @@ public override TokenCredential GetTokenCredential(CommonCredentialTestConfig co
             var vsOptions = new VisualStudioCredentialOptions
             {
                 AdditionallyAllowedTenants = config.AdditionallyAllowedTenants,
-                IsSupportLoggingEnabled = config.IsSupportLoggingEnabled,
+                IsUnsafeSupportLoggingEnabled = config.IsUnsafeSupportLoggingEnabled,
             };
             return InstrumentClient(new VisualStudioCredential(config.TenantId, default, fileSystem, new TestProcessService(testProcess, true), vsOptions));
         }

Original file line number	Diff line number	Diff line change
`@@ -373,7 +373,7 @@ public partial class TokenCredentialOptions : Azure.Core.ClientOptions`
`373`	`373`	`public TokenCredentialOptions() { }`
`374`	`374`	`public System.Uri AuthorityHost { get { throw null; } set { } }`
`375`	`375`	`public new Azure.Identity.TokenCredentialDiagnosticsOptions Diagnostics { get { throw null; } }`
`376`		`- public bool IsSupportLoggingEnabled { get { throw null; } set { } }`
	`376`	`+ public bool IsUnsafeSupportLoggingEnabled { get { throw null; } set { } }`
`377`	`377`	`}`
`378`	`378`	`public abstract partial class UnsafeTokenCacheOptions : Azure.Identity.TokenCachePersistenceOptions`
`379`	`379`	`{`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ public AzureCliCredential(AzureCliCredentialOptions options)`
`68`	`68`
`69`	`69`	`internal AzureCliCredential(CredentialPipeline pipeline, IProcessService processService, AzureCliCredentialOptions options = null)`
`70`	`70`	`{`
`71`		`- _logPII = options?.IsSupportLoggingEnabled ?? false;`
	`71`	`+ _logPII = options?.IsUnsafeSupportLoggingEnabled ?? false;`
`72`	`72`	`_logAccountDetails = options?.Diagnostics?.IsAccountIdentifierLoggingEnabled ?? false;`
`73`	`73`	`_pipeline = pipeline;`
`74`	`74`	`_path = !string.IsNullOrEmpty(EnvironmentVariables.Path) ? EnvironmentVariables.Path : DefaultPath;`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public AzureDeveloperCliCredential(AzureDeveloperCliCredentialOptions options)`
`61`	`61`
`62`	`62`	`internal AzureDeveloperCliCredential(CredentialPipeline pipeline, IProcessService processService, AzureDeveloperCliCredentialOptions options = null)`
`63`	`63`	`{`
`64`		`- _logPII = options?.IsSupportLoggingEnabled ?? false;`
	`64`	`+ _logPII = options?.IsUnsafeSupportLoggingEnabled ?? false;`
`65`	`65`	`_logAccountDetails = options?.Diagnostics?.IsAccountIdentifierLoggingEnabled ?? false;`
`66`	`66`	`_pipeline = pipeline;`
`67`	`67`	`_processService = processService ?? ProcessService.Default;`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public AzurePowerShellCredential(AzurePowerShellCredentialOptions options) : thi`
`61`	`61`	`internal AzurePowerShellCredential(AzurePowerShellCredentialOptions options, CredentialPipeline pipeline, IProcessService processService)`
`62`	`62`	`{`
`63`	`63`	`UseLegacyPowerShell = false;`
`64`		`- _logPII = options?.IsSupportLoggingEnabled ?? false;`
	`64`	`+ _logPII = options?.IsUnsafeSupportLoggingEnabled ?? false;`
`65`	`65`	`_logAccountDetails = options?.Diagnostics?.IsAccountIdentifierLoggingEnabled ?? false;`
`66`	`66`	`TenantId = options?.TenantId;`
`67`	`67`	`_pipeline = pipeline ?? CredentialPipeline.GetInstance(options);`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public VisualStudioCredential(VisualStudioCredentialOptions options) : this(opti`
`53`	`53`
`54`	`54`	`internal VisualStudioCredential(string tenantId, CredentialPipeline pipeline, IFileSystemService fileSystem, IProcessService processService, VisualStudioCredentialOptions options = null)`
`55`	`55`	`{`
`56`		`- _logPII = options?.IsSupportLoggingEnabled ?? false;`
	`56`	`+ _logPII = options?.IsUnsafeSupportLoggingEnabled ?? false;`
`57`	`57`	`_logAccountDetails = options?.Diagnostics?.IsAccountIdentifierLoggingEnabled ?? false;`
`58`	`58`	`TenantId = tenantId;`
`59`	`59`	`_pipeline = pipeline ?? CredentialPipeline.GetInstance(null);`