DynamicData: Allow arrays of objects where elements are allowed types (Azure#38458)

* Allow arrays of objects that are allowed types

* cast to string array instead

Author: annelo-msft

sdk/core/Azure.Core/src/DynamicData/DynamicData.AllowList.cs

@@ -158,8 +158,9 @@ private static bool IsAllowedEnumerableValue(Type elementType, IEnumerable enume
                         continue;
                     }
 
-                    // Don't allow heterogenous collections
-                    if (item.GetType() != elementType)
+                    // Don't allow heterogenous collections,
+                    // unless the types it's holding are allowed types.
+                    if (item.GetType() != elementType && !IsAllowedType(item.GetType()))
                     {
                         return false;
                     }

sdk/core/Azure.Core/tests/DynamicData/DynamicJsonAllowListTests.cs

@@ -6,7 +6,6 @@
 using System.IO;
 using System.Net.Http;
 using System.Runtime.Serialization;
-using System.Text.Json;
 using Azure.Core.Serialization;
 using NUnit.Framework;
 
@@ -66,6 +65,46 @@ public void CanAssignObjectArray()
             Assert.DoesNotThrow(() => json.Bar = new object[] { 2, false, "b" });
         }
 
+        [Test]
+        public void CanAssignObjectArrayOfAllowedTypes()
+        {
+            dynamic json = BinaryData.FromString("""{"foo":1}""").ToDynamicFromJson(JsonPropertyNames.CamelCase);
+
+            // Existing property
+            Assert.DoesNotThrow(() => json.Foo = new object[] { 1, null, "a" });
+
+            // New property
+            Assert.DoesNotThrow(() => json.Bar = new object[] { 2, false, "b" });
+        }
+
+        [Test]
+        public void CanAssignArrayOfDynamic()
+        {
+            dynamic jsonWithArray = BinaryData.FromString("""
+                {
+                    "MyArray": ["a", "b", "c"]
+                }
+                """).ToDynamicFromJson(JsonPropertyNames.CamelCase);
+
+            dynamic json = BinaryData.FromString("""{"foo": 1}""").ToDynamicFromJson(JsonPropertyNames.CamelCase);
+
+            // Existing property
+            Assert.DoesNotThrow(() => json.Foo = jsonWithArray.MyArray);
+
+            // New property
+            Assert.DoesNotThrow(() => json.Bar = jsonWithArray.MyArray);
+
+            // Create list to add an item to
+            List<string> list = new((string[])json.Foo);
+            list.Add("d");
+
+            json.Foo = list;
+            Assert.IsTrue("a" == json.Foo[0]);
+            Assert.IsTrue("b" == json.Foo[1]);
+            Assert.IsTrue("c" == json.Foo[2]);
+            Assert.IsTrue("d" == json.Foo[3]);
+        }
+
         [Test]
         public void CannotAssignObjectArrayContainingUnallowedTypes()
         {