Skip to content

Commit 19645ea

Browse files
authored
[Cdn] Address the first review comments (Azure#28291)
* address first part comments * address second part comments * fix nullable issue * update api
1 parent ef4713a commit 19645ea

32 files changed

+199
-94
lines changed

sdk/cdn/Azure.ResourceManager.Cdn/api/Azure.ResourceManager.Cdn.netstandard2.0.cs

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public AfdCustomDomainData() { }
2222
public Azure.ResourceManager.Cdn.Models.DeploymentStatus? DeploymentStatus { get { throw null; } }
2323
public Azure.ResourceManager.Cdn.Models.DomainValidationState? DomainValidationState { get { throw null; } }
2424
public string HostName { get { throw null; } set { } }
25-
public string PreValidatedCustomDomainResourceIdId { get { throw null; } set { } }
25+
public Azure.Core.ResourceIdentifier PreValidatedCustomDomainResourceId { get { throw null; } set { } }
2626
public string ProfileName { get { throw null; } }
2727
public Azure.ResourceManager.Cdn.Models.AfdProvisioningState? ProvisioningState { get { throw null; } }
2828
public Azure.ResourceManager.Cdn.Models.AfdCustomDomainHttpsParameters TlsSettings { get { throw null; } set { } }
@@ -453,7 +453,7 @@ public partial class CdnEndpointData : Azure.ResourceManager.Models.TrackedResou
453453
public CdnEndpointData(Azure.Core.AzureLocation location) : base (default(Azure.Core.AzureLocation)) { }
454454
public System.Collections.Generic.IList<string> ContentTypesToCompress { get { throw null; } }
455455
public System.Collections.Generic.IReadOnlyList<Azure.ResourceManager.Cdn.CdnCustomDomainData> CustomDomains { get { throw null; } }
456-
public string DefaultOriginGroupId { get { throw null; } set { } }
456+
public Azure.Core.ResourceIdentifier DefaultOriginGroupId { get { throw null; } set { } }
457457
public Azure.ResourceManager.Cdn.Models.EndpointPropertiesUpdateParametersDeliveryPolicy DeliveryPolicy { get { throw null; } set { } }
458458
public System.Collections.Generic.IList<Azure.ResourceManager.Cdn.Models.GeoFilter> GeoFilters { get { throw null; } }
459459
public string HostName { get { throw null; } }
@@ -470,7 +470,7 @@ public CdnEndpointData(Azure.Core.AzureLocation location) : base (default(Azure.
470470
public Azure.ResourceManager.Cdn.Models.QueryStringCachingBehavior? QueryStringCachingBehavior { get { throw null; } set { } }
471471
public Azure.ResourceManager.Cdn.Models.EndpointResourceState? ResourceState { get { throw null; } }
472472
public System.Collections.Generic.IList<Azure.ResourceManager.Cdn.Models.UrlSigningKey> UrlSigningKeys { get { throw null; } set { } }
473-
public string WebApplicationFirewallPolicyLinkId { get { throw null; } set { } }
473+
public Azure.Core.ResourceIdentifier WebApplicationFirewallPolicyLinkId { get { throw null; } set { } }
474474
}
475475
public partial class CdnEndpointResource : Azure.ResourceManager.ArmResource
476476
{
@@ -581,7 +581,7 @@ public CdnOriginData() { }
581581
public string PrivateLinkAlias { get { throw null; } set { } }
582582
public string PrivateLinkApprovalMessage { get { throw null; } set { } }
583583
public string PrivateLinkLocation { get { throw null; } set { } }
584-
public string PrivateLinkResourceId { get { throw null; } set { } }
584+
public Azure.Core.ResourceIdentifier PrivateLinkResourceId { get { throw null; } set { } }
585585
public string ProvisioningState { get { throw null; } }
586586
public Azure.ResourceManager.Cdn.Models.OriginResourceState? ResourceState { get { throw null; } }
587587
public int? Weight { get { throw null; } set { } }
@@ -705,7 +705,7 @@ protected ProfileCollection() { }
705705
public partial class ProfileData : Azure.ResourceManager.Models.TrackedResourceData
706706
{
707707
public ProfileData(Azure.Core.AzureLocation location, Azure.ResourceManager.Cdn.Models.CdnSku sku) : base (default(Azure.Core.AzureLocation)) { }
708-
public string FrontDoorId { get { throw null; } }
708+
public System.Guid? FrontDoorId { get { throw null; } }
709709
public string Kind { get { throw null; } }
710710
public int? OriginResponseTimeoutSeconds { get { throw null; } set { } }
711711
public string ProvisioningState { get { throw null; } }
@@ -801,7 +801,7 @@ namespace Azure.ResourceManager.Cdn.Models
801801
public partial class ActivatedResourceReference
802802
{
803803
public ActivatedResourceReference() { }
804-
public string Id { get { throw null; } set { } }
804+
public Azure.Core.ResourceIdentifier Id { get { throw null; } set { } }
805805
public bool? IsActive { get { throw null; } }
806806
}
807807
[System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
@@ -828,13 +828,13 @@ public partial class AfdCustomDomainHttpsParameters
828828
public AfdCustomDomainHttpsParameters(Azure.ResourceManager.Cdn.Models.AfdCertificateType certificateType) { }
829829
public Azure.ResourceManager.Cdn.Models.AfdCertificateType CertificateType { get { throw null; } set { } }
830830
public Azure.ResourceManager.Cdn.Models.AfdMinimumTlsVersion? MinimumTlsVersion { get { throw null; } set { } }
831-
public string SecretId { get { throw null; } set { } }
831+
public Azure.Core.ResourceIdentifier SecretId { get { throw null; } set { } }
832832
}
833833
public partial class AfdCustomDomainPatch
834834
{
835835
public AfdCustomDomainPatch() { }
836836
public Azure.Core.ResourceIdentifier AzureDnsZoneId { get { throw null; } set { } }
837-
public string PreValidatedCustomDomainResourceIdId { get { throw null; } set { } }
837+
public Azure.Core.ResourceIdentifier PreValidatedCustomDomainResourceId { get { throw null; } set { } }
838838
public string ProfileName { get { throw null; } }
839839
public Azure.ResourceManager.Cdn.Models.AfdCustomDomainHttpsParameters TlsSettings { get { throw null; } set { } }
840840
}
@@ -1121,7 +1121,7 @@ public partial class CdnEndpointPatch
11211121
{
11221122
public CdnEndpointPatch() { }
11231123
public System.Collections.Generic.IList<string> ContentTypesToCompress { get { throw null; } }
1124-
public string DefaultOriginGroupId { get { throw null; } set { } }
1124+
public Azure.Core.ResourceIdentifier DefaultOriginGroupId { get { throw null; } set { } }
11251125
public Azure.ResourceManager.Cdn.Models.EndpointPropertiesUpdateParametersDeliveryPolicy DeliveryPolicy { get { throw null; } set { } }
11261126
public System.Collections.Generic.IList<Azure.ResourceManager.Cdn.Models.GeoFilter> GeoFilters { get { throw null; } }
11271127
public bool? IsCompressionEnabled { get { throw null; } set { } }
@@ -1134,7 +1134,7 @@ public CdnEndpointPatch() { }
11341134
public Azure.ResourceManager.Cdn.Models.QueryStringCachingBehavior? QueryStringCachingBehavior { get { throw null; } set { } }
11351135
public System.Collections.Generic.IDictionary<string, string> Tags { get { throw null; } }
11361136
public System.Collections.Generic.IList<Azure.ResourceManager.Cdn.Models.UrlSigningKey> UrlSigningKeys { get { throw null; } set { } }
1137-
public string WebApplicationFirewallPolicyLinkId { get { throw null; } set { } }
1137+
public Azure.Core.ResourceIdentifier WebApplicationFirewallPolicyLinkId { get { throw null; } set { } }
11381138
}
11391139
public partial class CdnManagedHttpsOptions : Azure.ResourceManager.Cdn.Models.CustomDomainHttpsContent
11401140
{
@@ -1161,7 +1161,7 @@ public CdnOriginPatch() { }
11611161
public string PrivateLinkAlias { get { throw null; } set { } }
11621162
public string PrivateLinkApprovalMessage { get { throw null; } set { } }
11631163
public string PrivateLinkLocation { get { throw null; } set { } }
1164-
public string PrivateLinkResourceId { get { throw null; } set { } }
1164+
public Azure.Core.ResourceIdentifier PrivateLinkResourceId { get { throw null; } set { } }
11651165
public int? Weight { get { throw null; } set { } }
11661166
}
11671167
public partial class CdnSku
@@ -1202,7 +1202,7 @@ public partial class CdnUsage
12021202
{
12031203
internal CdnUsage() { }
12041204
public long CurrentValue { get { throw null; } }
1205-
public string Id { get { throw null; } }
1205+
public Azure.Core.ResourceIdentifier Id { get { throw null; } }
12061206
public long Limit { get { throw null; } }
12071207
public Azure.ResourceManager.Cdn.Models.UsageName Name { get { throw null; } }
12081208
public Azure.ResourceManager.Cdn.Models.UsageUnit Unit { get { throw null; } }
@@ -1529,7 +1529,7 @@ public DeepCreatedOrigin(string name) { }
15291529
public string PrivateLinkAlias { get { throw null; } set { } }
15301530
public string PrivateLinkApprovalMessage { get { throw null; } set { } }
15311531
public string PrivateLinkLocation { get { throw null; } set { } }
1532-
public string PrivateLinkResourceId { get { throw null; } set { } }
1532+
public Azure.Core.ResourceIdentifier PrivateLinkResourceId { get { throw null; } set { } }
15331533
public int? Weight { get { throw null; } set { } }
15341534
}
15351535
public partial class DeepCreatedOriginGroup

sdk/cdn/Azure.ResourceManager.Cdn/src/Generated/AfdCustomDomainData.cs

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/cdn/Azure.ResourceManager.Cdn/src/Generated/CdnEndpointData.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/cdn/Azure.ResourceManager.Cdn/src/Generated/CdnOriginData.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/cdn/Azure.ResourceManager.Cdn/src/Generated/Models/ActivatedResourceReference.Serialization.cs

Lines changed: 7 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/cdn/Azure.ResourceManager.Cdn/src/Generated/Models/ActivatedResourceReference.cs

Lines changed: 4 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/cdn/Azure.ResourceManager.Cdn/src/Generated/Models/AfdCustomDomainData.Serialization.cs

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/cdn/Azure.ResourceManager.Cdn/src/Generated/Models/AfdCustomDomainHttpsParameters.cs

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)