release-for-synapse-access-control-rlc (Azure#23250)

* release-for-synapse-access-control-rlc

* update samples to use isUnexpected

* remove unused imports

* update version

Author: qiaozha

sdk/synapse/synapse-access-control-rest/review/synapse-access-control.api.md

@@ -8,7 +8,7 @@
  * @azsdk-weight 10
  */
 
-import AccessControl from "@azure-rest/synapse-access-control";
+import AccessControl, { isUnexpected } from "@azure-rest/synapse-access-control";
 import { DefaultAzureCredential } from "@azure/identity";
 import { v4 } from "uuid";
 import dotenv from "dotenv";
@@ -31,7 +31,7 @@ async function main() {
     .path("/roleAssignments/{roleAssignmentId}", roleAssignmentId)
     .put({ body: { principalId, roleId, scope } });
 
-  if (result.status !== "200") {
+  if (isUnexpected(result)) {
     throw result.body.error;
   }
 

sdk/synapse/synapse-access-control-rest/samples-dev/createRoleAssignment.ts

@@ -8,7 +8,7 @@
  * @azsdk-weight 20
  */
 
-import AccessControl, { paginate } from "@azure-rest/synapse-access-control";
+import AccessControl, { isUnexpected, paginate } from "@azure-rest/synapse-access-control";
 import { DefaultAzureCredential } from "@azure/identity";
 import dotenv from "dotenv";
 
@@ -20,7 +20,7 @@ async function main() {
   const client = AccessControl(endpoint, new DefaultAzureCredential());
   const initialResponse = await client.path("/roleAssignments").get();
 
-  if (initialResponse.status !== "200") {
+  if (isUnexpected(initialResponse)) {
     throw initialResponse.body.error;
   }
 

sdk/synapse/synapse-access-control-rest/samples-dev/listRoleAssignments.ts

@@ -7,7 +7,8 @@
  * @summary creates a role assignment
  */
 
-const AccessControl = require("@azure-rest/synapse-access-control").default;
+const AccessControl = require("@azure-rest/synapse-access-control").default,
+  { isUnexpected } = require("@azure-rest/synapse-access-control");
 const { DefaultAzureCredential } = require("@azure/identity");
 const { v4 } = require("uuid");
 require("dotenv").config();
@@ -28,7 +29,7 @@ async function main() {
     .path("/roleAssignments/{roleAssignmentId}", roleAssignmentId)
     .put({ body: { principalId, roleId, scope } });
 
-  if (result.status !== "200") {
+  if (isUnexpected(result)) {
     throw result.body.error;
   }
 

sdk/synapse/synapse-access-control-rest/samples/v1-beta/javascript/createRoleAssignment.js

@@ -8,7 +8,7 @@
  */
 
 const AccessControl = require("@azure-rest/synapse-access-control").default,
-  { paginate } = require("@azure-rest/synapse-access-control");
+  { isUnexpected, paginate } = require("@azure-rest/synapse-access-control");
 const { DefaultAzureCredential } = require("@azure/identity");
 require("dotenv").config();
 
@@ -18,7 +18,7 @@ async function main() {
   const client = AccessControl(endpoint, new DefaultAzureCredential());
   const initialResponse = await client.path("/roleAssignments").get();
 
-  if (initialResponse.status !== "200") {
+  if (isUnexpected(initialResponse)) {
     throw initialResponse.body.error;
   }
 

sdk/synapse/synapse-access-control-rest/samples/v1-beta/javascript/listRoleAssignments.js

@@ -38,7 +38,7 @@
   "devDependencies": {
     "@types/uuid": "^8.0.0",
     "@types/node": "^12.0.0",
-    "typescript": "~4.4.0",
+    "typescript": "~4.6.0",
     "rimraf": "latest"
   }
 }

sdk/synapse/synapse-access-control-rest/samples/v1-beta/typescript/package.json

@@ -7,7 +7,7 @@
  * @summary creates a role assignment
  */
 
-import AccessControl from "@azure-rest/synapse-access-control";
+import AccessControl, { isUnexpected } from "@azure-rest/synapse-access-control";
 import { DefaultAzureCredential } from "@azure/identity";
 import { v4 } from "uuid";
 import dotenv from "dotenv";
@@ -30,7 +30,7 @@ async function main() {
     .path("/roleAssignments/{roleAssignmentId}", roleAssignmentId)
     .put({ body: { principalId, roleId, scope } });
 
-  if (result.status !== "200") {
+  if (isUnexpected(result)) {
     throw result.body.error;
   }
 

sdk/synapse/synapse-access-control-rest/samples/v1-beta/typescript/src/createRoleAssignment.ts

@@ -7,7 +7,7 @@
  * @summary list role assignments
  */
 
-import AccessControl, { paginate } from "@azure-rest/synapse-access-control";
+import AccessControl, { isUnexpected, paginate } from "@azure-rest/synapse-access-control";
 import { DefaultAzureCredential } from "@azure/identity";
 import dotenv from "dotenv";
 
@@ -19,7 +19,7 @@ async function main() {
   const client = AccessControl(endpoint, new DefaultAzureCredential());
   const initialResponse = await client.path("/roleAssignments").get();
 
-  if (initialResponse.status !== "200") {
+  if (isUnexpected(initialResponse)) {
     throw initialResponse.body.error;
   }
 

sdk/synapse/synapse-access-control-rest/samples/v1-beta/typescript/src/listRoleAssignments.ts

@@ -0,0 +1,41 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+import { getClient, ClientOptions } from "@azure-rest/core-client";
+import { TokenCredential } from "@azure/core-auth";
+import { AccessControlRestClient } from "./clientDefinitions";
+
+export default function createClient(
+  endpoint: string,
+  credentials: TokenCredential,
+  options: ClientOptions = {}
+): AccessControlRestClient {
+  const baseUrl = options.baseUrl ?? `${endpoint}`;
+  options.apiVersion = options.apiVersion ?? "2020-12-01";
+  options = {
+    ...options,
+    credentials: {
+      scopes: ["https://dev.azuresynapse.net/.default"]
+    }
+  };
+
+  const userAgentInfo = `azsdk-js-synapse-access-control-rest/1.0.0-beta.1`;
+  const userAgentPrefix =
+    options.userAgentOptions && options.userAgentOptions.userAgentPrefix
+      ? `${options.userAgentOptions.userAgentPrefix} ${userAgentInfo}`
+      : `${userAgentInfo}`;
+  options = {
+    ...options,
+    userAgentOptions: {
+      userAgentPrefix
+    }
+  };
+
+  const client = getClient(
+    baseUrl,
+    credentials,
+    options
+  ) as AccessControlRestClient;
+
+  return client;
+}

sdk/synapse/synapse-access-control-rest/src/accessControlRestClient.ts

@@ -30,14 +30,13 @@ import {
   RoleDefinitionsListScopes200Response,
   RoleDefinitionsListScopesdefaultResponse
 } from "./responses";
-import { getClient, ClientOptions, Client } from "@azure-rest/core-client";
-import { TokenCredential } from "@azure/core-auth";
+import { Client, StreamableMethod } from "@azure-rest/core-client";
 
 export interface RoleAssignmentsCheckPrincipalAccess {
   /** Check if the given principalId has access to perform list of actions at a given scope. */
   post(
     options: RoleAssignmentsCheckPrincipalAccessParameters
-  ): Promise<
+  ): StreamableMethod<
     | RoleAssignmentsCheckPrincipalAccess200Response
     | RoleAssignmentsCheckPrincipalAccessdefaultResponse
   >;
@@ -47,7 +46,7 @@ export interface RoleAssignmentsListRoleAssignments {
   /** List role assignments. */
   get(
     options?: RoleAssignmentsListRoleAssignmentsParameters
-  ): Promise<
+  ): StreamableMethod<
     | RoleAssignmentsListRoleAssignments200Response
     | RoleAssignmentsListRoleAssignmentsdefaultResponse
   >;
@@ -57,21 +56,21 @@ export interface RoleAssignmentsCreateRoleAssignment {
   /** Create role assignment. */
   put(
     options: RoleAssignmentsCreateRoleAssignmentParameters
-  ): Promise<
+  ): StreamableMethod<
     | RoleAssignmentsCreateRoleAssignment200Response
     | RoleAssignmentsCreateRoleAssignmentdefaultResponse
   >;
   /** Get role assignment by role assignment Id. */
   get(
     options?: RoleAssignmentsGetRoleAssignmentByIdParameters
-  ): Promise<
+  ): StreamableMethod<
     | RoleAssignmentsGetRoleAssignmentById200Response
     | RoleAssignmentsGetRoleAssignmentByIddefaultResponse
   >;
   /** Delete role assignment by role assignment Id. */
   delete(
     options?: RoleAssignmentsDeleteRoleAssignmentByIdParameters
-  ): Promise<
+  ): StreamableMethod<
     | RoleAssignmentsDeleteRoleAssignmentById200Response
     | RoleAssignmentsDeleteRoleAssignmentById204Response
     | RoleAssignmentsDeleteRoleAssignmentByIddefaultResponse
@@ -82,7 +81,7 @@ export interface RoleDefinitionsListRoleDefinitions {
   /** List role definitions. */
   get(
     options?: RoleDefinitionsListRoleDefinitionsParameters
-  ): Promise<
+  ): StreamableMethod<
     | RoleDefinitionsListRoleDefinitions200Response
     | RoleDefinitionsListRoleDefinitionsdefaultResponse
   >;
@@ -92,7 +91,7 @@ export interface RoleDefinitionsGetRoleDefinitionById {
   /** Get role definition by role definition Id. */
   get(
     options?: RoleDefinitionsGetRoleDefinitionByIdParameters
-  ): Promise<
+  ): StreamableMethod<
     | RoleDefinitionsGetRoleDefinitionById200Response
     | RoleDefinitionsGetRoleDefinitionByIddefaultResponse
   >;
@@ -102,7 +101,7 @@ export interface RoleDefinitionsListScopes {
   /** List rbac scopes. */
   get(
     options?: RoleDefinitionsListScopesParameters
-  ): Promise<
+  ): StreamableMethod<
     | RoleDefinitionsListScopes200Response
     | RoleDefinitionsListScopesdefaultResponse
   >;
@@ -132,20 +131,3 @@ export interface Routes {
 export type AccessControlRestClient = Client & {
   path: Routes;
 };
-
-export default function AccessControl(
-  endpoint: string,
-  credentials: TokenCredential,
-  options: ClientOptions = {}
-): AccessControlRestClient {
-  const baseUrl = options.baseUrl ?? `${endpoint}`;
-  options.apiVersion = options.apiVersion ?? "2020-12-01";
-  options = {
-    ...options,
-    credentials: {
-      scopes: ["https://dev.azuresynapse.net/.default"]
-    }
-  };
-
-  return getClient(baseUrl, credentials, options) as AccessControlRestClient;
-}