Commit cf0a0f8
authored
Updates notification-hubs deleteRegistration so that it actually HTTP DELETEs. (Azure#25910)
According to the docs, the delete API expects a `HTTP DELETE
/registrations/<registrationId>`, but the got uses `HTTP GET`, hence
delete does not work.
https://learn.microsoft.com/en-us/rest/api/notificationhubs/delete-registration
<img width="699" alt="Screenshot 2023-05-17 at 22 49 27"
src="https://github.com/Azure/azure-sdk-for-js/assets/86589079/2a4687da-0cc7-4d0b-a758-370ae017ad05">
### Packages impacted by this PR
https://www.npmjs.com/package/@azure/notification-hubs
### Issues associated with this PR
N/A
### Describe the problem that is addressed by this PR
According to the docs, the delete API expects a `HTTP DELETE
/registrations/<registrationId>`, but the got uses `HTTP GET`, hence
delete does not work.
https://learn.microsoft.com/en-us/rest/api/notificationhubs/delete-registration
### Checklists
- [x] Added impacted package name to the issue description? Yes
- [x] Does this PR needs any fixes in the SDK Generator?** No
- [x] Added a changelog: Not necessary1 parent 0afa40a commit cf0a0f8
File tree
1 file changed
+1
-1
lines changed- sdk/notificationhubs/notification-hubs/src/api
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
0 commit comments