[engsys] fixing linter errors (Azure#21459)

* [engsys] fixing linter errors

* Address CR feedback

Author: jeremymeng

sdk/core/core-client-rest/src/urlHelpers.ts

@@ -62,7 +62,7 @@ function skipQueryParameterEncoding(url: URL) {
     return url;
   }
   const searchPieces: string[] = [];
-  for (let [name, value] of url.searchParams) {
+  for (const [name, value] of url.searchParams) {
     // QUIRK: searchParams.get retrieves the values decoded
     searchPieces.push(`${name}=${value}`);
   }

sdk/eventgrid/eventgrid/src/eventGridClient.ts

@@ -33,7 +33,7 @@ export type EventGridPublisherClientOptions = CommonClientOptions;
  */
 export type SendOptions = OperationOptions;
 
-/***
+/**
  * Options for the send events operation, when the input schema is cloud event.
  */
 export interface CloudEventSendOptions extends SendOptions {

sdk/storage/storage-blob-changefeed/src/utils/utils.common.ts

@@ -172,7 +172,7 @@ export function minDate(dateA: Date, dateB?: Date): Date {
   return dateA;
 }
 
-export function rawEventToBlobChangeFeedEvent(rawEvent: any): BlobChangeFeedEvent {
+export function rawEventToBlobChangeFeedEvent(rawEvent: Record<string, any>): BlobChangeFeedEvent {
   if (rawEvent.eventTime) {
     rawEvent.eventTime = new Date(rawEvent.eventTime);
   }
@@ -186,7 +186,7 @@ export function rawEventToBlobChangeFeedEvent(rawEvent: any): BlobChangeFeedEven
       delete rawEvent.data.recursive;
     }
     if (rawEvent.data.previousInfo) {
-      let previousInfo = rawEvent.data.previousInfo;
+      const previousInfo = rawEvent.data.previousInfo;
 
       if (previousInfo.SoftDeleteSnapshot) {
         previousInfo.softDeleteSnapshot = previousInfo.SoftDeleteSnapshot;
@@ -213,7 +213,7 @@ export function rawEventToBlobChangeFeedEvent(rawEvent: any): BlobChangeFeedEven
     }
 
     if (rawEvent.data.blobPropertiesUpdated) {
-      let updatedBlobProperties: UpdatedBlobProperties = {};
+      const updatedBlobProperties: UpdatedBlobProperties = {};
       Object.entries(rawEvent.data.blobPropertiesUpdated).map((item) => {
         const blobPropertyChange = {
           propertyName: item[0],
@@ -227,7 +227,7 @@ export function rawEventToBlobChangeFeedEvent(rawEvent: any): BlobChangeFeedEven
     }
 
     if (rawEvent.data.asyncOperationInfo) {
-      let longRunningOperationInfo = rawEvent.data.asyncOperationInfo;
+      const longRunningOperationInfo = rawEvent.data.asyncOperationInfo;
       if (longRunningOperationInfo.DestinationTier) {
         longRunningOperationInfo.destinationAccessTier = longRunningOperationInfo.DestinationTier;
         delete longRunningOperationInfo.DestinationTier;

sdk/storage/storage-blob-changefeed/test/utils/testutils.common.ts

@@ -139,21 +139,20 @@ export function isSuperSet(m1?: BlobMetadata, m2?: BlobMetadata): boolean {
 /**
  * Sleep for seconds.
  *
- * @param seconds -
+ * @param seconds - duration to sleep in seconds
  */
 export function sleep(seconds: number): Promise<void> {
   return new Promise((resolve) => {
     setTimeout(resolve, seconds * 1000);
   });
 }
 /**
- * Read text content from a stream
- * @param stream
- * @returns
+ * Read text content from a stream as string
+ * @param stream - stream to read from
+ * @returns a utf-8 string that is the whole content of the stream
  */
 export function streamToString(stream: Readable): Promise<string> {
-  let chunks: any[];
-  chunks = [];
+  const chunks: any[] = [];
   return new Promise((resolve, reject) => {
     stream.on("data", (chunk) => chunks.push(Buffer.from(chunk)));
     stream.on("error", (err) => reject(err));