Skip to content

Commit b70f822

Browse files
sarangan12srnagarscottaddie
authored
[@azure/monitor-query] Code Changes to add Batch Client to Metrics Query Client (Azure#26418)
Fixes Azure#25058 ### Packages impacted by this PR @azure/monitor-query ### Issues associated with this PR NA ### Describe the problem that is addressed by this PR In this PR, a new client called `MetricsBatchClient` has been added to the SDK. This Client is generated from this [swagger](https://raw.githubusercontent.com/Azure/azure-rest-api-specs/5f700acd3d094d8eedca381932f2e7916afd2e55/specification/monitor/data-plane/Microsoft.Insights/preview/2023-05-01-preview/metricBatch.json). ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? The names of the following properties: `Metric`, `TimeSeriesElement`, `MetricValue`, `MetadataValue` and `MetricUnit` are conflicting with the existing names. So, they are renamed as `BatchMetric`, `BatchTimeSeriesElement`, `BatchMetricValue`, `BatchMetadataValue` and `BatchMetricUnit`. ### Are there test cases added in this PR? _(If not, why?)_ Since this is a beta release and needed to be released at the earliest and the code has been tested locally, test cases are not added with this PR. It will be added seperately ### Provide a list of related PRs _(if any)_ None ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ `...\azure-sdk-for-js\sdk\monitor\monitor-query> autorest --typescript .\swagger\metric-Batch.md` ### Checklists - [X] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [X] Added a changelog (if necessary) @KarishmaGhiya @jeremymeng Please review and approve the PR. @srnagar @scottaddie @xirzec FYI...... --------- Co-authored-by: Srikanta <51379715+srnagar@users.noreply.github.com> Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
1 parent 28b2618 commit b70f822

File tree

26 files changed

+1723
-308
lines changed

26 files changed

+1723
-308
lines changed

.github/CODEOWNERS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -882,10 +882,10 @@
882882
/sdk/dnsresolver/ci.mgmt.yml @qiaozha @MaryGao
883883

884884
# PRLabel: %Monitor
885-
/sdk/monitor/monitor-ingestion/ @KarishmaGhiya @sarangan12
885+
/sdk/monitor/monitor-ingestion/ @srnagar @lmolkova @jairmyree @KarishmaGhiya @nisha-bhatia @pvaneck @gracewilcox @sarangan12 @scottaddie
886886
/sdk/monitor/monitor-opentelemetry @hectorhdzg @JacksonWeber
887887
/sdk/monitor/monitor-opentelemetry-exporter @hectorhdzg @JacksonWeber
888-
/sdk/monitor/monitor-query/ @KarishmaGhiya @sarangan12
888+
/sdk/monitor/monitor-query/ @srnagar @lmolkova @jairmyree @KarishmaGhiya @nisha-bhatia @pvaneck @gracewilcox @sarangan12 @scottaddie
889889

890890
# PRLabel: %Mgmt
891891
/sdk/quantum/arm-quantum/ @qiaozha @MaryGao

.vscode/cspell.json

Lines changed: 129 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,11 @@
22
"version": "0.1",
33
"language": "en",
44
"languageId": "typescript,javascript",
5-
"dictionaries": ["powershell", "typescript", "node"],
5+
"dictionaries": [
6+
"powershell",
7+
"typescript",
8+
"node"
9+
],
610
"ignorePaths": [
711
"**/node_modules/**",
812
"**/recordings/**",
@@ -144,15 +148,31 @@
144148
"overrides": [
145149
{
146150
"filename": "eng/pipelines",
147-
"words": ["azuresdkartifacts", "policheck", "gdnbaselines"]
151+
"words": [
152+
"azuresdkartifacts",
153+
"policheck",
154+
"gdnbaselines"
155+
]
148156
},
149157
{
150158
"filename": "sdk/videoanalyzer/video-analyzer-edge/review/**/*.md",
151-
"words": ["abgr", "Abgr", "argb", "Argb", "bgra", "Bgra", "Grpc", "onvif", "Onvif"]
159+
"words": [
160+
"abgr",
161+
"Abgr",
162+
"argb",
163+
"Argb",
164+
"bgra",
165+
"Bgra",
166+
"Grpc",
167+
"onvif",
168+
"Onvif"
169+
]
152170
},
153171
{
154172
"filename": "sdk/storage/storage-blob/review/**/*.md",
155-
"words": ["RAGRS"]
173+
"words": [
174+
"RAGRS"
175+
]
156176
},
157177
{
158178
"filename": "sdk/search/search-documents/review/**/*.md",
@@ -180,15 +200,28 @@
180200
},
181201
{
182202
"filename": "sdk/keyvault/keyvault-keys/review/**/*.md",
183-
"words": ["ECHSM", "OKPHSM", "RSAHSM", "RSNULL", "Rsnull"]
203+
"words": [
204+
"ECHSM",
205+
"OKPHSM",
206+
"RSAHSM",
207+
"RSNULL",
208+
"Rsnull"
209+
]
184210
},
185211
{
186212
"filename": "sdk/keyvault/keyvault-certificates/review/**/*.md",
187-
"words": ["ECHSM", "ekus", "RSAHSM", "upns"]
213+
"words": [
214+
"ECHSM",
215+
"ekus",
216+
"RSAHSM",
217+
"upns"
218+
]
188219
},
189220
{
190221
"filename": "sdk/digitaltwins/digital-twins-core/review/**/*.md",
191-
"words": ["dtdl"]
222+
"words": [
223+
"dtdl"
224+
]
192225
},
193226
{
194227
"filename": "sdk/cosmosdb/cosmos/review/**/*.md",
@@ -218,7 +251,9 @@
218251
},
219252
{
220253
"filename": "sdk/formrecognizer/ai-form-recognizer/README.md",
221-
"words": ["iddocument"]
254+
"words": [
255+
"iddocument"
256+
]
222257
},
223258
{
224259
"filename": "sdk/formrecognizer/ai-form-recognizer/review/**/*.md",
@@ -235,95 +270,158 @@
235270
},
236271
{
237272
"filename": "sdk/core/core-amqp/review/**/*.md",
238-
"words": ["EHOSTDOWN", "ENONET", "sastoken"]
273+
"words": [
274+
"EHOSTDOWN",
275+
"ENONET",
276+
"sastoken"
277+
]
239278
},
240279
{
241280
"filename": "sdk/containerregistry/container-registry/review/**/*.md",
242-
"words": ["illumos", "Illumos", "mipsle", "riscv"]
281+
"words": [
282+
"illumos",
283+
"Illumos",
284+
"mipsle",
285+
"riscv"
286+
]
243287
},
244288
{
245289
"filename": "sdk/communication/communication-call-automation/review/**/*.md",
246-
"words": ["ssml", "Ssml"]
290+
"words": [
291+
"ssml",
292+
"Ssml"
293+
]
247294
},
248295
{
249296
"filename": "sdk/communication/communication-common/review/**/*.md",
250-
"words": ["gcch"]
297+
"words": [
298+
"gcch"
299+
]
251300
},
252301
{
253302
"filename": "sdk/communication/communication-email/review/**/*.md",
254-
"words": ["rpmsg", "xlsb"]
303+
"words": [
304+
"rpmsg",
305+
"xlsb"
306+
]
255307
},
256308
{
257309
"filename": "sdk/eventgrid/eventgrid/review/**/*.md",
258-
"words": ["Dicom"]
310+
"words": [
311+
"Dicom"
312+
]
259313
},
260314
{
261315
"filename": "sdk/iot/iot-modelsrepository/review/**/*.md",
262-
"words": ["Dtmi", "dtmis"]
316+
"words": [
317+
"Dtmi",
318+
"dtmis"
319+
]
263320
},
264321
{
265322
"filename": "sdk/storage/storage-blob/review/storage-blob.api.md",
266-
"words": ["Uncommited"]
323+
"words": [
324+
"Uncommited"
325+
]
267326
},
268327
{
269328
"filename": "sdk/search/search-documents/review/search-documents.api.md",
270-
"words": ["Createor"]
329+
"words": [
330+
"Createor"
331+
]
271332
},
272333
{
273334
"filename": "sdk/monitor/monitor-query/review/monitor-query.api.md",
274-
"words": ["fourty"]
335+
"words": [
336+
"fourty",
337+
"Milli"
338+
]
275339
},
276340
{
277341
"filename": "sdk/digitaltwins/digital-twins-core/review/digital-twins-core.api.md",
278-
"words": ["dependecies"]
342+
"words": [
343+
"dependecies"
344+
]
279345
},
280346
{
281347
"filename": "sdk/cosmosdb/cosmos/review/cosmos.api.md",
282-
"words": ["Funtion"]
348+
"words": [
349+
"Funtion"
350+
]
283351
},
284352
{
285353
"filename": "sdk/apimanagement/api-management-custom-widgets-scaffolder/review/api-management-custom-widgets-scaffolder.api.md",
286-
"words": ["scaffolder", "APIM"]
354+
"words": [
355+
"scaffolder",
356+
"APIM"
357+
]
287358
},
288359
{
289360
"filename": "sdk/apimanagement/api-management-custom-widgets-tools/review/api-management-custom-widgets-tools.api.md",
290-
"words": ["MSAPIM", "APIM"]
361+
"words": [
362+
"MSAPIM",
363+
"APIM"
364+
]
291365
},
292366
{
293367
"filename": "sdk/maps/maps-common/review/maps-common.api.md",
294-
"words": ["bbox"]
368+
"words": [
369+
"bbox"
370+
]
295371
},
296372
{
297373
"filename": "sdk/maps/maps-search/review/maps-search.api.md",
298-
"words": ["bbox", "Neighbourhood", "Xstr"]
374+
"words": [
375+
"bbox",
376+
"Neighbourhood",
377+
"Xstr"
378+
]
299379
},
300380
{
301381
"filename": "sdk/maps/maps-route-rest/review/maps-route.api.md",
302-
"words": ["bbox", "UTURN", "Hundredkm"]
382+
"words": [
383+
"bbox",
384+
"UTURN",
385+
"Hundredkm"
386+
]
303387
},
304388
{
305389
"filename": "sdk/maps/maps-render-rest/review/maps-render.api.md",
306-
"words": ["bbox"]
390+
"words": [
391+
"bbox"
392+
]
307393
},
308394
{
309395
"filename": "sdk/maps/maps-search-rest/review/maps-search.api.md",
310-
"words": ["Neighbourhood", "Xstr"]
396+
"words": [
397+
"Neighbourhood",
398+
"Xstr"
399+
]
311400
},
312401
{
313402
"filename": "sdk/apimanagement/api-management-custom-widgets-scaffolder/review/api-management-custom-widgets-scaffolder.api.md",
314-
"words": ["scaffolder", "APIM"]
403+
"words": [
404+
"scaffolder",
405+
"APIM"
406+
]
315407
},
316408
{
317409
"filename": "sdk/loadtestservice/load-testing-rest/review/load-testing.api.md",
318-
"words": ["vusers"]
410+
"words": [
411+
"vusers"
412+
]
319413
},
320414
{
321415
"filename": "sdk/web-pubsub/web-pubsub-client/review/web-pubsub-client.api.md",
322-
"words": ["protobuf"]
416+
"words": [
417+
"protobuf"
418+
]
323419
},
324420
{
325421
"filename": "sdk/web-pubsub/web-pubsub-client-protobuf/review/web-pubsub-client-protobuf.api.md",
326-
"words": ["protobuf"]
422+
"words": [
423+
"protobuf"
424+
]
327425
}
328426
]
329427
}

0 commit comments

Comments
 (0)