Skip to content

Commit a6fe3ff

Browse files
authored
Jiriburant/siprouting ga version (Azure#25166)
# Description SIP routing GA version. Regenerated SIP routing functionality in PhoneNumbers SDK to accomodate for GA version. Rest API swagger: Azure/azure-rest-api-specs#22747 If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. ### Packages impacted by this PR PhoneNumbers SDK ### Issues associated with this PR ### Describe the problem that is addressed by this PR Updating the underlying API to GA version. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
1 parent 30c703f commit a6fe3ff

File tree

145 files changed

+4630
-4501
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

145 files changed

+4630
-4501
lines changed

sdk/communication/communication-phone-numbers/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
## 1.2.0-beta.5 (Unreleased)
44

55
### Features Added
6+
- Added support for SIP routing API version `2023-03-01`, releasing SIP routing functionality from public preview to GA.
7+
- Added environment variable `AZURE_TEST_DOMAIN` for SIP routing tests to support domain verification.
68

79
### Breaking Changes
810
- Changed public methods `getTrunks` to `listTrunks` and `getRoutes` to `listRoutes`.

sdk/communication/communication-phone-numbers/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -347,13 +347,13 @@ const connectionString = "endpoint=<endpoint>;accessKey=<accessKey>";
347347
const client = new SipRoutingClient(connectionString);
348348

349349
async function main() {
350-
const trunks = await client.getTrunks();
351-
const routes = await client.getRoutes();
352-
for (const trunk of trunks) {
350+
const trunks = await client.listTrunks();
351+
const routes = await client.listRoutes();
352+
for await(const trunk of trunks) {
353353
console.log(`Trunk ${trunk.fqdn}:${trunk.sipSignalingPort}`);
354354
}
355355

356-
for (const route of routes) {
356+
for await(const route of routes) {
357357
console.log(`Route ${route.name} with pattern ${route.numberPattern}`);
358358
console.log(`Route's trunks: ${route.trunks?.join()}`);
359359
}

sdk/communication/communication-phone-numbers/karma.conf.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ module.exports = function (config) {
6464
"AZURE_TEST_AGENT",
6565
"AZURE_USERAGENT_OVERRIDE",
6666
"RECORDINGS_RELATIVE_PATH",
67+
"AZURE_TEST_DOMAIN",
6768
...getPhoneNumberPoolEnvVars(),
6869
],
6970

sdk/communication/communication-phone-numbers/recordings/browsers/siproutingclient__delete_trunk/recording_can_delete_an_existing_trunk.json

Lines changed: 49 additions & 49 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/communication/communication-phone-numbers/recordings/browsers/siproutingclient__delete_trunk/recording_cannot_delete_a_not_existing_trunk_but_succeeds.json

Lines changed: 31 additions & 31 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)