[EventHub] Fix a regression in token renewal (Azure#26297)

In our previous refactoring, we accidentally dropped the `getToken()`
calls when renewing token. This PR adds the calls back.

The internal `TokenInfo` property `timeoutInMs` is renamed to
`timeToLiveInMs` to avoid confusion with operation timeout parameter
`timeoutInMs`.

Author: jeremymeng

sdk/eventhub/event-hubs/CHANGELOG.md

@@ -8,6 +8,8 @@
 
 ### Bugs Fixed
 
+- Fix a regression of missing `getToken` calls when renewing tokens.
+
 ### Other Changes
 
 ## 5.11.0 (2023-06-08)

sdk/eventhub/event-hubs/src/withAuth.ts

@@ -41,17 +41,18 @@ export async function withAuth(
   await callback();
   async function createTask() {
     try {
-      await setupClaimNegotiation(context, audience, info, timeoutInMs, logger, options);
+      const info2 = await getTokenInfo(context.tokenCredential, audience);
+      await setupClaimNegotiation(context, audience, info2, timeoutInMs, logger, options);
       logger.verbose(
-        `next token renewal is in ${info.timeoutInMs} milliseconds @(${new Date(
-          Date.now() + info.timeoutInMs
+        `next token renewal is in ${info2.timeToLiveInMs} milliseconds @(${new Date(
+          Date.now() + info2.timeToLiveInMs
         ).toString()}).`
       );
     } catch (err) {
       logger.verbose(`an error occurred while renewing the token: ${logObj(err)}`);
     }
   }
-  const loop = createTimerLoop(info.timeoutInMs, createTask);
+  const loop = createTimerLoop(info.timeToLiveInMs, createTask);
   loop.start();
   return loop;
 }
@@ -88,7 +89,7 @@ interface TokenInfo {
   /** The type of the token */
   type: TokenType;
   /** The time duration after which the token should be refreshed */
-  timeoutInMs: number;
+  timeToLiveInMs: number;
 }
 
 async function getAadToken(cred: TokenCredential): Promise<TokenInfo> {
@@ -99,15 +100,15 @@ async function getAadToken(cred: TokenCredential): Promise<TokenInfo> {
   return {
     token,
     type: TokenType.CbsTokenTypeJwt,
-    timeoutInMs: token.expiresOnTimestamp - Date.now() - 2 * 60 * 1000,
+    timeToLiveInMs: token.expiresOnTimestamp - Date.now() - 2 * 60 * 1000,
   };
 }
 
 function getSharedKeyBasedToken(cred: SasTokenProvider, audience: string): TokenInfo {
   return {
     token: cred.getToken(audience),
     type: TokenType.CbsTokenTypeSas,
-    timeoutInMs: 45 * 60 * 1000,
+    timeToLiveInMs: 45 * 60 * 1000,
   };
 }