Skip to content

Commit 402226d

Browse files
Mhang/pstn dial out feature (Azure#27189)
### Packages impacted by this PR communication-rooms ### Issues associated with this PR ### Describe the problem that is addressed by this PR Added support for PSTN Dial-Out Feature in ACS Rooms ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ Yes ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [X] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [X] Added a changelog (if necessary)
1 parent 9841a8a commit 402226d

File tree

85 files changed

+4904
-2607
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

85 files changed

+4904
-2607
lines changed

.vscode/cspell.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "0.1",
2+
"version": "0.2",
33
"language": "en",
44
"languageId": "typescript,javascript",
55
"dictionaries": [
@@ -108,6 +108,7 @@
108108
"PLREGON",
109109
"pnpm",
110110
"prettierrc",
111+
"pstn",
111112
"pwsh",
112113
"Rasterize",
113114
"reoffer",

sdk/communication/communication-rooms/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Release History
22

3+
## 1.1.0-beta.1 (2023-09-21)
4+
5+
### Features Added
6+
7+
- Added support for PSTN dial-out capability
8+
39
## 1.0.0 (2023-06-12)
410

511
General Availability version of the Azure Communication Services Rooms JavaScript SDK.

sdk/communication/communication-rooms/README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ If `validFrom` is not provided, it is defaulted to the current datetime. If `val
8383

8484
When defining `participants`, if `role` is not specified, then it will be `attendee` by default.
8585

86+
Starting in 1.1.0-beta.1 release, `PstnDialOutEnabled` property is added to enable or disable PSTN Dial-Out feature in a room. The `PstnDialOutEnabled` is an optional property. If `PstnDialOutEnabled` is not provided, then the default for `PstnDialOutEnabled` is false.
87+
8688
```js
8789
// create users with CommunicationIdentityClient
8890
const identityClient = new CommunicationIdentityClient(connectionString);
@@ -95,11 +97,13 @@ const validFrom = new Date(Date.now());
9597
let validForDays = 10;
9698
let validUntil = new Date(validFrom.getTime());
9799
validUntil.setDate(validFrom.getDate() + validForDays);
100+
const pstnDialOutEnabled = true;
98101

99102
// options payload to create a room
100103
const createRoomOptions: CreateRoomOptions = {
101104
validFrom,
102105
validUntil,
106+
pstnDialOutEnabled,
103107
participants: [
104108
{
105109
id: user1.user,
@@ -118,12 +122,17 @@ const room = await roomsClient.createRoom(createRoomOptions);
118122

119123
To update the `validFrom` and `validUntil` settings of a room use the `updateRoom` method.
120124

125+
Starting in 1.1.0-beta.1 release, `PstnDialOutEnabled` property is added to enable or disable PSTN Dial-Out feature in a room.
126+
121127
```js
122128
validForDays = 60;
123129
validUntil.setDate(validFrom.getDate() + validForDays);
130+
pstnDialOutEnabled = false;
131+
124132
const updateRoomOptions: UpdateRoomOptions = {
125133
validFrom,
126134
validUntil,
135+
pstnDialOutEnabled,
127136
};
128137

129138
// update the room using the room id from the creation operation

sdk/communication/communication-rooms/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"sdk-type": "client",
44
"author": "Microsoft Corporation",
55
"description": "Azure client library for Azure Communication Rooms services",
6-
"version": "1.0.0",
6+
"version": "1.1.0-beta.1",
77
"engines": {
88
"node": ">=14.0.0"
99
},

sdk/communication/communication-rooms/recordings/browsers/participants_operations/recording_successfully_adds_participants_to_the_room.json

Lines changed: 56 additions & 51 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)