Skip to content

Commit 31cf443

Browse files
authored
[engsys] upgrade eslint-config-prettier version to ^9.0.0 (Azure#26725)
The breaking change in v9 is related to how BOM is handled. It doesn't affect our usage. While validating the change I found some false-positive linter errors in dev-tool and suppressed them.
1 parent 91ab54d commit 31cf443

File tree

5 files changed

+46
-42
lines changed

5 files changed

+46
-42
lines changed

common/config/rush/pnpm-lock.yaml

Lines changed: 35 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common/tools/dev-tool/src/commands/migrate.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ async function runMigrations(pending: Migration[], project: ProjectInfo): Promis
354354
async function onMigrationSuccess(
355355
project: ProjectInfo,
356356
migration: Migration,
357-
quiet: boolean = false
357+
quiet: boolean = false // eslint-disable-line @typescript-eslint/no-inferrable-types
358358
): Promise<void> {
359359
await updateMigrationDate(project, migration);
360360

@@ -370,7 +370,7 @@ async function onMigrationSuccess(
370370
async function onMigrationSkipped(
371371
project: ProjectInfo,
372372
migration: Migration,
373-
quiet: boolean = false
373+
quiet: boolean = false // eslint-disable-line @typescript-eslint/no-inferrable-types
374374
): Promise<void> {
375375
await updateMigrationDate(project, migration);
376376

@@ -447,7 +447,10 @@ function printMigrationSuspendedWarning(migration: Migration, status: MigrationS
447447
* @param project - the working project
448448
* @returns true on success, otherwise false
449449
*/
450-
async function abortMigration(project: ProjectInfo, quiet: boolean = false): Promise<boolean> {
450+
async function abortMigration(
451+
project: ProjectInfo,
452+
quiet: boolean = false // eslint-disable-line @typescript-eslint/no-inferrable-types
453+
): Promise<boolean> {
451454
const suspendedMigration = await validateSuspendedState(project);
452455
if (!suspendedMigration) return false;
453456

common/tools/dev-tool/src/util/resolveProject.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ declare global {
3737
require?: string;
3838
types?: string;
3939
[extraTypes: `types@${string}`]: string;
40-
}
41-
},
40+
};
41+
};
4242
typesVersions?: {
4343
[k: string]: {
4444
[k: string]: string[];

common/tools/dev-tool/src/util/testProxyUtils.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,8 @@ export async function isProxyToolActive(): Promise<boolean> {
219219
await axios.get(`http://localhost:${process.env.TEST_PROXY_HTTP_PORT ?? 5000}/info/available`);
220220

221221
log.info(
222-
`Proxy tool seems to be active at http://localhost:${process.env.TEST_PROXY_HTTP_PORT ?? 5000
222+
`Proxy tool seems to be active at http://localhost:${
223+
process.env.TEST_PROXY_HTTP_PORT ?? 5000
223224
}\n`
224225
);
225226
return true;

common/tools/eslint-plugin-azure-sdk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
"@typescript-eslint/typescript-estree": "~5.57.0",
7272
"@types/eslint": "~8.4.0",
7373
"@types/estree": "~1.0.0",
74-
"eslint-config-prettier": "^8.0.0",
74+
"eslint-config-prettier": "^9.0.0",
7575
"glob": "^9.0.0",
7676
"json-schema": "^0.4.0",
7777
"typescript": "~5.0.0",

0 commit comments

Comments
 (0)