Skip to content

Commit 0fcefa7

Browse files
[DO NOT MERGE]updated per-action callback URI override naming (Azure#26623)
### Packages impacted by this PR ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
1 parent 65e9a17 commit 0fcefa7

File tree

6 files changed

+22
-22
lines changed

6 files changed

+22
-22
lines changed

sdk/communication/communication-call-automation/review/communication-call-automation.api.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export interface AddParticipantFailed extends Omit<RestAddParticipantFailed, "ca
2727

2828
// @public
2929
export interface AddParticipantOptions extends OperationOptions {
30-
callbackUrlOverride?: string;
30+
callbackUrl?: string;
3131
invitationTimeoutInSeconds?: number;
3232
operationContext?: string;
3333
}
@@ -600,7 +600,7 @@ export interface RemoveParticipantResult {
600600

601601
// @public
602602
export interface RemoveParticipantsOption extends OperationOptions {
603-
callbackUrlOverride?: string;
603+
callbackUrl?: string;
604604
operationContext?: string;
605605
}
606606

@@ -940,7 +940,7 @@ export interface TransferCallResult {
940940

941941
// @public
942942
export interface TransferCallToParticipantOptions extends OperationOptions {
943-
callbackUrlOverride?: string;
943+
callbackUrl?: string;
944944
customContext?: CustomContext;
945945
operationContext?: string;
946946
transferee?: CommunicationIdentifier;

sdk/communication/communication-call-automation/src/callConnection.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ export class CallConnection {
186186
sipHeaders: targetParticipant.customContext?.sipHeaders,
187187
voipHeaders: targetParticipant.customContext?.voipHeaders,
188188
},
189-
callbackUriOverride: options.callbackUrlOverride,
189+
callbackUri: options.callbackUrl,
190190
};
191191
const optionsInternal = {
192192
...options,
@@ -226,7 +226,7 @@ export class CallConnection {
226226
sipHeaders: options.customContext?.sipHeaders,
227227
voipHeaders: options.customContext?.voipHeaders,
228228
},
229-
callbackUriOverride: options.callbackUrlOverride,
229+
callbackUri: options.callbackUrl,
230230
transferee: options.transferee && communicationIdentifierModelConverter(options.transferee),
231231
};
232232
const optionsInternal = {
@@ -255,7 +255,7 @@ export class CallConnection {
255255
const removeParticipantRequest: RemoveParticipantRequest = {
256256
participantToRemove: communicationIdentifierModelConverter(participant),
257257
operationContext: options.operationContext,
258-
callbackUriOverride: options.callbackUrlOverride,
258+
callbackUri: options.callbackUrl,
259259
};
260260
const optionsInternal = {
261261
...options,

sdk/communication/communication-call-automation/src/generated/src/models/index.ts

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/communication/communication-call-automation/src/generated/src/models/mappers.ts

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/communication/communication-call-automation/src/models/options.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export interface TransferCallToParticipantOptions extends OperationOptions {
124124
/** The Custom Context. */
125125
customContext?: CustomContext;
126126
/** Call back URI override for this request */
127-
callbackUrlOverride?: string;
127+
callbackUrl?: string;
128128
/** Participant that is being transferred away */
129129
transferee?: CommunicationIdentifier;
130130
}
@@ -139,7 +139,7 @@ export interface AddParticipantOptions extends OperationOptions {
139139
/** Used by customers when calling mid-call actions to correlate the request to the response event. */
140140
operationContext?: string;
141141
/** Call back URI override for this request */
142-
callbackUrlOverride?: string;
142+
callbackUrl?: string;
143143
}
144144

145145
/**
@@ -149,7 +149,7 @@ export interface RemoveParticipantsOption extends OperationOptions {
149149
/** Used by customers when calling mid-call actions to correlate the request to the response event. */
150150
operationContext?: string;
151151
/** Call back URI override for this request */
152-
callbackUrlOverride?: string;
152+
callbackUrl?: string;
153153
}
154154

155155
/**

sdk/communication/communication-call-automation/swagger/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ generate-metadata: false
1212
license-header: MICROSOFT_MIT_NO_VERSION
1313
output-folder: ../src/generated
1414
tag: V2023-01-15-preview
15-
input-file: https://github.com/juntuchen-msft/azure-rest-api-specs/blob/0a316f5346cf6dc37200403d6b20e2400157721c/specification/communication/data-plane/CallAutomation/preview/2023-01-15-preview/communicationservicescallautomation.json
15+
input-file: https://github.com/williamzhao87/azure-rest-api-specs/blob/b496fbaf1cef0d9a8d31cfb11c3fc301d4c328ef/specification/communication/data-plane/CallAutomation/preview/2023-01-15-preview/communicationservicescallautomation.json
1616
package-version: 1.0.0-beta.1
1717
model-date-time-as-string: false
1818
optional-response-headers: true

0 commit comments

Comments
 (0)