[eslint] enable allowDeclarations option for typescript-eslint/no-namespace rule (Azure#21212)

* Updating ESLint to fix errors

* Reverting tsconfig change

Author: mpodwysocki

common/tools/eslint-plugin-azure-sdk/.eslintrc.json

@@ -23,6 +23,7 @@
     "@typescript-eslint/indent": "off",
     "@typescript-eslint/no-magic-numbers": ["error", { "ignore": [0], "ignoreArrayIndexes": true }],
     "@typescript-eslint/no-explicit-any": "off",
+    "@typescript-eslint/no-namespace": ["error", { "allowDeclarations": true }],
     "@typescript-eslint/no-non-null-assertion": "off",
     "arrow-body-style": ["error", "as-needed"],
     "curly": "error",

sdk/attestation/attestation/src/jsrsasign.d.ts

@@ -1,5 +1,4 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-// eslint-disable-next-line @typescript-eslint/no-namespace
 declare module 'jsrsasign';

sdk/containerregistry/container-registry/src/utils/base64.browser.ts

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-// eslint-disable-next-line @typescript-eslint/no-namespace
 declare global {
   function atob(input: string): string;
 }

sdk/core/core-client/src/base64.browser.ts

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-// eslint-disable-next-line @typescript-eslint/no-namespace
 declare global {
   // stub these out for the browser
   function btoa(input: string): string;

sdk/core/core-http/src/httpOperationResponse.ts

@@ -24,7 +24,6 @@ export interface HttpResponse {
   headers: HttpHeadersLike;
 }
 
-// eslint-disable-next-line @typescript-eslint/no-namespace
 declare global {
   /**
    * Stub declaration of the browser-only Blob type.

sdk/keyvault/keyvault-keys/src/cryptography/aesCryptographyProvider.ts

@@ -4,21 +4,21 @@
 import { OperationOptions } from "@azure/core-http";
 import * as crypto from "crypto";
 import {
-  EncryptOptions,
-  EncryptResult,
+  AesCbcEncryptParameters,
   DecryptOptions,
   DecryptResult,
+  EncryptOptions,
+  EncryptResult,
+  JsonWebKey,
   KeyWrapAlgorithm,
-  WrapKeyOptions,
-  WrapResult,
-  UnwrapKeyOptions,
-  UnwrapResult,
   SignOptions,
   SignResult,
+  UnwrapKeyOptions,
+  UnwrapResult,
   VerifyOptions,
   VerifyResult,
-  AesCbcEncryptParameters,
-  JsonWebKey,
+  WrapKeyOptions,
+  WrapResult,
 } from "..";
 import { AesCbcDecryptParameters } from "../cryptographyClientModels";
 import {

sdk/keyvault/keyvault-keys/src/cryptography/crypto.ts

@@ -2,9 +2,9 @@
 // Licensed under the MIT license.
 
 import {
+  Verify,
   createHash as cryptoCreateHash,
   createVerify as cryptoCreateVerify,
-  Verify,
   randomBytes as cryptoRandomBytes,
 } from "crypto";
 

sdk/keyvault/keyvault-keys/src/cryptography/models.ts

@@ -10,9 +10,9 @@ import {
   EncryptParameters,
   EncryptResult,
   KeyWrapAlgorithm,
-  SignatureAlgorithm,
   SignOptions,
   SignResult,
+  SignatureAlgorithm,
   UnwrapKeyOptions,
   UnwrapResult,
   VerifyOptions,

sdk/keyvault/keyvault-keys/src/cryptography/remoteCryptographyProvider.ts

@@ -2,26 +2,26 @@
 // Licensed under the MIT license.
 
 import {
+  TokenCredential,
   createPipelineFromOptions,
   isTokenCredential,
-  TokenCredential,
   signingPolicy,
 } from "@azure/core-http";
 import {
-  EncryptParameters,
+  DecryptOptions,
+  DecryptParameters,
+  DecryptResult,
   EncryptOptions,
+  EncryptParameters,
   EncryptResult,
   KeyWrapAlgorithm,
-  WrapKeyOptions,
-  WrapResult,
-  VerifyOptions,
-  VerifyResult,
-  DecryptParameters,
-  DecryptOptions,
-  DecryptResult,
-  UnwrapKeyOptions,
   SignOptions,
   SignResult,
+  UnwrapKeyOptions,
+  VerifyOptions,
+  VerifyResult,
+  WrapKeyOptions,
+  WrapResult,
 } from "../cryptographyClientModels";
 import { SDK_VERSION } from "../constants";
 import { UnwrapResult } from "../cryptographyClientModels";

sdk/keyvault/keyvault-keys/src/cryptography/rsaCryptographyProvider.ts

@@ -5,22 +5,22 @@ import { RSA_PKCS1_OAEP_PADDING, RSA_PKCS1_PADDING } from "constants";
 import { publicEncrypt } from "crypto";
 import { createVerify } from "./crypto";
 import {
-  JsonWebKey,
   DecryptOptions,
+  DecryptParameters,
+  DecryptResult,
   EncryptOptions,
   EncryptParameters,
   EncryptResult,
+  JsonWebKey,
   KeyWrapAlgorithm,
+  SignOptions,
+  SignResult,
+  SignatureAlgorithm,
   UnwrapKeyOptions,
+  UnwrapResult,
   VerifyOptions,
   VerifyResult,
   WrapKeyOptions,
-  DecryptParameters,
-  DecryptResult,
-  SignatureAlgorithm,
-  SignOptions,
-  SignResult,
-  UnwrapResult,
   WrapResult,
 } from "..";
 import { convertJWKtoPEM } from "./conversions";