[AutoPR azure-resourcemanager-servicefabric] Add x-ms-pageable to generate API's that support using nextlink to return resources

sdk/servicefabric/azure-resourcemanager-servicefabric/CHANGELOG.md

@@ -1,6 +1,8 @@
 # Release History
 
-## 1.0.0-beta.4 (Unreleased)
+## 1.0.0-beta.1 (2023-10-25)
+
+- Azure Resource Manager ServiceFabric client library for Java. This package contains Microsoft Azure SDK for ServiceFabric Management SDK. Service Fabric Management Client. Package tag package-2021-06. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt).
 
 ### Features Added
 

sdk/servicefabric/azure-resourcemanager-servicefabric/README.md

@@ -32,7 +32,7 @@ Various documentation is available to help you get started
 <dependency>
     <groupId>com.azure.resourcemanager</groupId>
     <artifactId>azure-resourcemanager-servicefabric</artifactId>
-    <version>1.0.0-beta.3</version>
+    <version>1.0.0-beta.4</version>
 </dependency>
 ```
 [//]: # ({x-version-update-end})
@@ -45,7 +45,7 @@ Azure Management Libraries require a `TokenCredential` implementation for authen
 
 ### Authentication
 
-By default, Azure Active Directory token authentication depends on correct configuration of the following environment variables.
+By default, Microsoft Entra ID token authentication depends on correct configuration of the following environment variables.
 
 - `AZURE_CLIENT_ID` for Azure client ID.
 - `AZURE_TENANT_ID` for Azure tenant ID.
@@ -94,7 +94,7 @@ This project has adopted the [Microsoft Open Source Code of Conduct][coc]. For m
 <!-- LINKS -->
 [survey]: https://microsoft.qualtrics.com/jfe/form/SV_ehN0lIk2FKEBkwd?Q_CHL=DOCS
 [docs]: https://azure.github.io/azure-sdk-for-java/
-[jdk]: https://docs.microsoft.com/java/azure/jdk/
+[jdk]: https://learn.microsoft.com/azure/developer/java/fundamentals/
 [azure_subscription]: https://azure.microsoft.com/free/
 [azure_identity]: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/identity/azure-identity
 [azure_core_http_netty]: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/core/azure-core-http-netty
@@ -103,3 +103,5 @@ This project has adopted the [Microsoft Open Source Code of Conduct][coc]. For m
 [cg]: https://github.com/Azure/azure-sdk-for-java/blob/main/CONTRIBUTING.md
 [coc]: https://opensource.microsoft.com/codeofconduct/
 [coc_faq]: https://opensource.microsoft.com/codeofconduct/faq/
+
+![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-java%2Fsdk%2Fservicefabric%2Fazure-resourcemanager-servicefabric%2FREADME.png)

sdk/servicefabric/azure-resourcemanager-servicefabric/SAMPLE.md

@@ -78,6 +78,7 @@ public final class ApplicationTypeVersionsCreateOrUpdateSamples {
             .create();
     }
 
+    // Use "Map.of" if available
     @SuppressWarnings("unchecked")
     private static <T> Map<String, T> mapOf(Object... inputs) {
         Map<String, T> map = new HashMap<>();
@@ -150,9 +151,7 @@ public final class ApplicationTypeVersionsListSamples {
      */
     public static void getAListOfApplicationTypeVersionResources(
         com.azure.resourcemanager.servicefabric.ServiceFabricManager manager) {
-        manager
-            .applicationTypeVersions()
-            .listWithResponse("resRg", "myCluster", "myAppType", com.azure.core.util.Context.NONE);
+        manager.applicationTypeVersions().list("resRg", "myCluster", "myAppType", com.azure.core.util.Context.NONE);
     }
 }
 ```
@@ -182,6 +181,7 @@ public final class ApplicationTypesCreateOrUpdateSamples {
             .create();
     }
 
+    // Use "Map.of" if available
     @SuppressWarnings("unchecked")
     private static <T> Map<String, T> mapOf(Object... inputs) {
         Map<String, T> map = new HashMap<>();
@@ -248,7 +248,7 @@ public final class ApplicationTypesListSamples {
      */
     public static void getAListOfApplicationTypeNameResources(
         com.azure.resourcemanager.servicefabric.ServiceFabricManager manager) {
-        manager.applicationTypes().listWithResponse("resRg", "myCluster", com.azure.core.util.Context.NONE);
+        manager.applicationTypes().list("resRg", "myCluster", com.azure.core.util.Context.NONE);
     }
 }
 ```
@@ -367,6 +367,7 @@ public final class ApplicationsCreateOrUpdateSamples {
             .create();
     }
 
+    // Use "Map.of" if available
     @SuppressWarnings("unchecked")
     private static <T> Map<String, T> mapOf(Object... inputs) {
         Map<String, T> map = new HashMap<>();
@@ -433,7 +434,7 @@ public final class ApplicationsListSamples {
      */
     public static void getAListOfApplicationResources(
         com.azure.resourcemanager.servicefabric.ServiceFabricManager manager) {
-        manager.applications().listWithResponse("resRg", "myCluster", com.azure.core.util.Context.NONE);
+        manager.applications().list("resRg", "myCluster", com.azure.core.util.Context.NONE);
     }
 }
 ```
@@ -837,6 +838,7 @@ public final class ClustersCreateOrUpdateSamples {
             .create();
     }
 
+    // Use "Map.of" if available
     @SuppressWarnings("unchecked")
     private static <T> Map<String, T> mapOf(Object... inputs) {
         Map<String, T> map = new HashMap<>();
@@ -902,7 +904,7 @@ public final class ClustersListSamples {
      * @param manager Entry point to ServiceFabricManager.
      */
     public static void listClusters(com.azure.resourcemanager.servicefabric.ServiceFabricManager manager) {
-        manager.clusters().listWithResponse(com.azure.core.util.Context.NONE);
+        manager.clusters().list(com.azure.core.util.Context.NONE);
     }
 }
 ```
@@ -922,7 +924,7 @@ public final class ClustersListByResourceGroupSamples {
      */
     public static void listClusterByResourceGroup(
         com.azure.resourcemanager.servicefabric.ServiceFabricManager manager) {
-        manager.clusters().listByResourceGroupWithResponse("resRg", com.azure.core.util.Context.NONE);
+        manager.clusters().listByResourceGroup("resRg", com.azure.core.util.Context.NONE);
     }
 }
 ```
@@ -1034,6 +1036,7 @@ public final class ClustersUpdateSamples {
             .apply();
     }
 
+    // Use "Map.of" if available
     @SuppressWarnings("unchecked")
     private static <T> Map<String, T> mapOf(Object... inputs) {
         Map<String, T> map = new HashMap<>();
@@ -1146,6 +1149,7 @@ public final class ServicesCreateOrUpdateSamples {
             .create();
     }
 
+    // Use "Map.of" if available
     @SuppressWarnings("unchecked")
     private static <T> Map<String, T> mapOf(Object... inputs) {
         Map<String, T> map = new HashMap<>();
@@ -1214,7 +1218,7 @@ public final class ServicesListSamples {
      */
     public static void getAListOfServiceResources(
         com.azure.resourcemanager.servicefabric.ServiceFabricManager manager) {
-        manager.services().listWithResponse("resRg", "myCluster", "myApp", com.azure.core.util.Context.NONE);
+        manager.services().list("resRg", "myCluster", "myApp", com.azure.core.util.Context.NONE);
     }
 }
 ```

sdk/servicefabric/azure-resourcemanager-servicefabric/pom.xml

@@ -1,3 +1,8 @@
+<!--
+ ~ Copyright (c) Microsoft Corporation. All rights reserved.
+ ~ Licensed under the MIT License.
+ ~ Code generated by Microsoft (R) AutoRest Code Generator.
+ -->
 <project xmlns="http://maven.apache.org/POM/4.0.0" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
   <modelVersion>4.0.0</modelVersion>
   <parent>
@@ -38,7 +43,9 @@
   </developers>
   <properties>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    <jacoco.skip>true</jacoco.skip>
+    <jacoco.min.linecoverage>0</jacoco.min.linecoverage>
+    <jacoco.min.branchcoverage>0</jacoco.min.branchcoverage>
+    <revapi.skip>true</revapi.skip>
   </properties>
   <dependencies>
     <dependency>

sdk/servicefabric/azure-resourcemanager-servicefabric/src/main/java/com/azure/resourcemanager/servicefabric/ServiceFabricManager.java

@@ -227,7 +227,7 @@ public ServiceFabricManager authenticate(TokenCredential credential, AzureProfil
                 .append("-")
                 .append("com.azure.resourcemanager.servicefabric")
                 .append("/")
-                .append("1.0.0-beta.3");
+                .append("1.0.0-beta.1");
             if (!Configuration.getGlobalConfiguration().get("AZURE_TELEMETRY_DISABLED", false)) {
                 userAgentBuilder
                     .append(" (")
@@ -370,8 +370,10 @@ public Services services() {
     }
 
     /**
-     * @return Wrapped service client ServiceFabricManagementClient providing direct access to the underlying
-     *     auto-generated API implementation, based on Azure REST API.
+     * Gets wrapped service client ServiceFabricManagementClient providing direct access to the underlying
+     * auto-generated API implementation, based on Azure REST API.
+     *
+     * @return Wrapped service client ServiceFabricManagementClient.
      */
     public ServiceFabricManagementClient serviceClient() {
         return this.clientObject;

sdk/servicefabric/azure-resourcemanager-servicefabric/src/main/java/com/azure/resourcemanager/servicefabric/fluent/ApplicationTypeVersionsClient.java

@@ -6,12 +6,12 @@
 
 import com.azure.core.annotation.ReturnType;
 import com.azure.core.annotation.ServiceMethod;
+import com.azure.core.http.rest.PagedIterable;
 import com.azure.core.http.rest.Response;
 import com.azure.core.management.polling.PollResult;
 import com.azure.core.util.Context;
 import com.azure.core.util.polling.SyncPoller;
 import com.azure.resourcemanager.servicefabric.fluent.models.ApplicationTypeVersionResourceInner;
-import com.azure.resourcemanager.servicefabric.fluent.models.ApplicationTypeVersionResourceListInner;
 
 /** An instance of this class provides access to all the operations defined in ApplicationTypeVersionsClient. */
 public interface ApplicationTypeVersionsClient {
@@ -237,16 +237,15 @@ void delete(
      * @param resourceGroupName The name of the resource group.
      * @param clusterName The name of the cluster resource.
      * @param applicationTypeName The name of the application type name resource.
-     * @param context The context to associate with this operation.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
      * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
      * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
      * @return all application type version resources created or in the process of being created in the Service Fabric
-     *     application type name resource along with {@link Response}.
+     *     application type name resource as paginated response with {@link PagedIterable}.
      */
-    @ServiceMethod(returns = ReturnType.SINGLE)
-    Response<ApplicationTypeVersionResourceListInner> listWithResponse(
-        String resourceGroupName, String clusterName, String applicationTypeName, Context context);
+    @ServiceMethod(returns = ReturnType.COLLECTION)
+    PagedIterable<ApplicationTypeVersionResourceInner> list(
+        String resourceGroupName, String clusterName, String applicationTypeName);
 
     /**
      * Gets the list of application type version resources created in the specified Service Fabric application type name
@@ -258,13 +257,14 @@ Response<ApplicationTypeVersionResourceListInner> listWithResponse(
      * @param resourceGroupName The name of the resource group.
      * @param clusterName The name of the cluster resource.
      * @param applicationTypeName The name of the application type name resource.
+     * @param context The context to associate with this operation.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
      * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
      * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
      * @return all application type version resources created or in the process of being created in the Service Fabric
-     *     application type name resource.
+     *     application type name resource as paginated response with {@link PagedIterable}.
      */
-    @ServiceMethod(returns = ReturnType.SINGLE)
-    ApplicationTypeVersionResourceListInner list(
-        String resourceGroupName, String clusterName, String applicationTypeName);
+    @ServiceMethod(returns = ReturnType.COLLECTION)
+    PagedIterable<ApplicationTypeVersionResourceInner> list(
+        String resourceGroupName, String clusterName, String applicationTypeName, Context context);
 }

sdk/servicefabric/azure-resourcemanager-servicefabric/src/main/java/com/azure/resourcemanager/servicefabric/fluent/ApplicationTypesClient.java

@@ -6,12 +6,12 @@
 
 import com.azure.core.annotation.ReturnType;
 import com.azure.core.annotation.ServiceMethod;
+import com.azure.core.http.rest.PagedIterable;
 import com.azure.core.http.rest.Response;
 import com.azure.core.management.polling.PollResult;
 import com.azure.core.util.Context;
 import com.azure.core.util.polling.SyncPoller;
 import com.azure.resourcemanager.servicefabric.fluent.models.ApplicationTypeResourceInner;
-import com.azure.resourcemanager.servicefabric.fluent.models.ApplicationTypeResourceListInner;
 
 /** An instance of this class provides access to all the operations defined in ApplicationTypesClient. */
 public interface ApplicationTypesClient {
@@ -171,16 +171,14 @@ SyncPoller<PollResult<Void>, Void> beginDelete(
      *
      * @param resourceGroupName The name of the resource group.
      * @param clusterName The name of the cluster resource.
-     * @param context The context to associate with this operation.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
      * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
      * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
      * @return all application type name resources created or in the process of being created in the Service Fabric
-     *     cluster resource along with {@link Response}.
+     *     cluster resource as paginated response with {@link PagedIterable}.
      */
-    @ServiceMethod(returns = ReturnType.SINGLE)
-    Response<ApplicationTypeResourceListInner> listWithResponse(
-        String resourceGroupName, String clusterName, Context context);
+    @ServiceMethod(returns = ReturnType.COLLECTION)
+    PagedIterable<ApplicationTypeResourceInner> list(String resourceGroupName, String clusterName);
 
     /**
      * Gets the list of application type name resources created in the specified Service Fabric cluster resource.
@@ -190,12 +188,13 @@ Response<ApplicationTypeResourceListInner> listWithResponse(
      *
      * @param resourceGroupName The name of the resource group.
      * @param clusterName The name of the cluster resource.
+     * @param context The context to associate with this operation.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
      * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
      * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
      * @return all application type name resources created or in the process of being created in the Service Fabric
-     *     cluster resource.
+     *     cluster resource as paginated response with {@link PagedIterable}.
      */
-    @ServiceMethod(returns = ReturnType.SINGLE)
-    ApplicationTypeResourceListInner list(String resourceGroupName, String clusterName);
+    @ServiceMethod(returns = ReturnType.COLLECTION)
+    PagedIterable<ApplicationTypeResourceInner> list(String resourceGroupName, String clusterName, Context context);
 }

sdk/servicefabric/azure-resourcemanager-servicefabric/src/main/java/com/azure/resourcemanager/servicefabric/fluent/ApplicationsClient.java

@@ -6,12 +6,12 @@
 
 import com.azure.core.annotation.ReturnType;
 import com.azure.core.annotation.ServiceMethod;
+import com.azure.core.http.rest.PagedIterable;
 import com.azure.core.http.rest.Response;
 import com.azure.core.management.polling.PollResult;
 import com.azure.core.util.Context;
 import com.azure.core.util.polling.SyncPoller;
 import com.azure.resourcemanager.servicefabric.fluent.models.ApplicationResourceInner;
-import com.azure.resourcemanager.servicefabric.fluent.models.ApplicationResourceListInner;
 import com.azure.resourcemanager.servicefabric.models.ApplicationResourceUpdate;
 
 /** An instance of this class provides access to all the operations defined in ApplicationsClient. */
@@ -292,16 +292,14 @@ SyncPoller<PollResult<Void>, Void> beginDelete(
      *
      * @param resourceGroupName The name of the resource group.
      * @param clusterName The name of the cluster resource.
-     * @param context The context to associate with this operation.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
      * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
      * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
      * @return all application resources created or in the process of being created in the Service Fabric cluster
-     *     resource along with {@link Response}.
+     *     resource as paginated response with {@link PagedIterable}.
      */
-    @ServiceMethod(returns = ReturnType.SINGLE)
-    Response<ApplicationResourceListInner> listWithResponse(
-        String resourceGroupName, String clusterName, Context context);
+    @ServiceMethod(returns = ReturnType.COLLECTION)
+    PagedIterable<ApplicationResourceInner> list(String resourceGroupName, String clusterName);
 
     /**
      * Gets the list of application resources created in the specified Service Fabric cluster resource.
@@ -311,12 +309,13 @@ Response<ApplicationResourceListInner> listWithResponse(
      *
      * @param resourceGroupName The name of the resource group.
      * @param clusterName The name of the cluster resource.
+     * @param context The context to associate with this operation.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
      * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
      * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
      * @return all application resources created or in the process of being created in the Service Fabric cluster
-     *     resource.
+     *     resource as paginated response with {@link PagedIterable}.
      */
-    @ServiceMethod(returns = ReturnType.SINGLE)
-    ApplicationResourceListInner list(String resourceGroupName, String clusterName);
+    @ServiceMethod(returns = ReturnType.COLLECTION)
+    PagedIterable<ApplicationResourceInner> list(String resourceGroupName, String clusterName, Context context);
 }