Unsupported basic tier for Service Bus JMS (Azure#38164)

* Unsupported basic tier

Author: Netyyyy

sdk/spring/CHANGELOG.md

@@ -8,6 +8,9 @@ This section includes changes in `spring-cloud-azure-autoconfigure` module.
 #### Bugs Fixed
 - Fix CVE-2023-34062 [#38066](https://github.com/Azure/azure-sdk-for-java/issues/38066).
 
+#### Other Changes
+- Unsupported basic tier for Service Bus JMS because of the [limitation of Azure Service Bus](https://learn.microsoft.com/azure/service-bus-messaging/jms-developer-guide?tabs=JMS-20%2Csystem-assigned-managed-identity-backed-authentication#java-message-service-jms-programming-model) [#38164](https://github.com/Azure/azure-sdk-for-java/pull/38164).
+
 ## 5.8.0 (2023-12-14)
 - This release is compatible with Spring Boot 3.0.0-3.0.13, 3.1.0-3.1.6, 3.2.0-3.2.0. (Note: 3.0.x (x>13), 3.1.y (y>6) and 3.2.z (z>0) should be supported, but they aren't tested with this release.)
 - This release is compatible with Spring Cloud 2022.0.0-2022.0.4, 2023.0.0-2023.0.0. (Note: 2022.0.x (x>4) and 2023.0.y (y>0) should be supported, but they aren't tested with this release.)

sdk/spring/spring-cloud-azure-autoconfigure/src/main/java/com/azure/spring/cloud/autoconfigure/jms/properties/AzureServiceBusJmsProperties.java

@@ -310,8 +310,14 @@ public void afterPropertiesSet() throws Exception {
             }
         }
 
-        if (null == pricingTier || !pricingTier.matches("(?i)premium|standard|basic")) {
-            throw new IllegalArgumentException("'spring.jms.servicebus.pricing-tier' is not valid");
+        if (null == pricingTier || !pricingTier.matches("(?i)premium|standard")) {
+            String errMessage = null;
+            if ("basic".equalsIgnoreCase(pricingTier)) {
+                errMessage = "The basic tier is not supported by Service Bus JMS. Please use standard or premium tier instead.";
+            } else {
+                errMessage = "'spring.jms.servicebus.pricing-tier' is not valid.";
+            }
+            throw new IllegalArgumentException(errMessage);
         }
     }
 

sdk/spring/spring-cloud-azure-autoconfigure/src/test/java/com/azure/spring/cloud/autoconfigure/jms/ServiceBusJmsAutoConfigurationTests.java

@@ -44,7 +44,7 @@ class ServiceBusJmsAutoConfigurationTests {
         + "SharedAccessKey=sasKey";
 
     private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
-        .withBean(AzureGlobalProperties.class, () -> new AzureGlobalProperties())
+        .withBean(AzureGlobalProperties.class, AzureGlobalProperties::new)
         .withConfiguration(AutoConfigurations.of(JmsAutoConfiguration.class, ServiceBusJmsAutoConfiguration.class));
 
     private void testQueueJmsListenerContainerFactoryWithCustomSettings(AssertableApplicationContext loaded) {
@@ -104,7 +104,7 @@ void contextFailedByConnectionStringNotConfigured() {
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "Ba", " " })
+    @ValueSource(strings = { "Ba", " ", "basic" })
     void contextFailedByPricingTierNotCorrectlyConfigured(String pricingTier) {
         this.contextRunner
             .withPropertyValues(
@@ -118,8 +118,8 @@ void contextFailedByPricingTierNotCorrectlyConfigured(String pricingTier) {
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "basic", "premium" })
-    void autoconfigurationEnabledAndContextSuccessWithNonstandardTier(String pricingTier) {
+    @ValueSource(strings = { "premium" })
+    void autoconfigurationEnabledAndContextSuccessWithPremiumTier(String pricingTier) {
         this.contextRunner
             .withPropertyValues(
                 "spring.jms.servicebus.pricing-tier=" + pricingTier,
@@ -156,7 +156,7 @@ void autoconfigurationEnabledAndContextSuccessWithStandardTier(String pricingTie
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "basic", "standard", "premium" })
+    @ValueSource(strings = { "standard", "premium" })
     void autoconfigurationDisabled(String pricingTier) {
         this.contextRunner
             .withPropertyValues(
@@ -179,8 +179,8 @@ void autoconfigurationDisabledCase2() {
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "basic", "standard", "premium" })
-    void doesnotHaveBeanOfAzureServiceBusJmsPropertiesBeanPostProcessor(String pricingTier) {
+    @ValueSource(strings = { "standard", "premium" })
+    void doesNotHaveBeanOfAzureServiceBusJmsPropertiesBeanPostProcessor(String pricingTier) {
         this.contextRunner
             .withPropertyValues(
                 "spring.jms.servicebus.pricing-tier=" + pricingTier,
@@ -191,7 +191,7 @@ void doesnotHaveBeanOfAzureServiceBusJmsPropertiesBeanPostProcessor(String prici
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "basic" })
+    @ValueSource(strings = { "standard", "premium" })
     void doesHaveBeanOfAzureServiceBusJmsPropertiesBeanPostProcessor(String pricingTier) {
         this.contextRunner
             .withPropertyValues(
@@ -213,7 +213,7 @@ StaticConnectionStringProvider<AzureServiceType.ServiceBus> connectionStringProv
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "basic", "standard", "premium" })
+    @ValueSource(strings = { "standard", "premium" })
     void connectionFactoryIsAutowiredIntoJmsTemplateBean(String pricingTier) {
         this.contextRunner
             .withPropertyValues(
@@ -226,7 +226,7 @@ void connectionFactoryIsAutowiredIntoJmsTemplateBean(String pricingTier) {
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "basic", "standard", "premium" })
+    @ValueSource(strings = { "standard", "premium" })
     void jmsPropertiesConfiguredCorrectly(String pricingTier) {
         this.contextRunner
             .withPropertyValues(
@@ -250,7 +250,7 @@ void jmsPropertiesConfiguredCorrectly(String pricingTier) {
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "basic", "standard", "premium" })
+    @ValueSource(strings = { "standard", "premium" })
     void jmsServiceBusPropertiesConfigured(String pricingTier) {
         this.contextRunner
             .withPropertyValues(
@@ -267,7 +267,7 @@ void jmsServiceBusPropertiesConfigured(String pricingTier) {
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "basic", "standard", "premium" })
+    @ValueSource(strings = { "standard", "premium" })
     void jmsListenerContainerFactoryConfiguredCorrectly(String pricingTier) {
         this.contextRunner
             .withPropertyValues(
@@ -290,7 +290,7 @@ void jmsListenerContainerFactoryConfiguredCorrectly(String pricingTier) {
 
 
     @ParameterizedTest
-    @ValueSource(strings = { "basic", "standard", "premium" })
+    @ValueSource(strings = { "standard", "premium" })
     void cachingConnectionFactoryBeanConfiguredAsDefault(String pricingTier) {
         this.contextRunner
             .withPropertyValues(
@@ -304,7 +304,7 @@ void cachingConnectionFactoryBeanConfiguredAsDefault(String pricingTier) {
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "basic", "standard", "premium" })
+    @ValueSource(strings = { "standard", "premium" })
     void cachingConnectionFactoryBeanConfiguredExplicitly(String pricingTier) {
         this.contextRunner
             .withPropertyValues(
@@ -319,8 +319,8 @@ void cachingConnectionFactoryBeanConfiguredExplicitly(String pricingTier) {
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "basic", "standard", "premium" })
-    void nativeConnectionFactoryBeanConfiguredByProperteyCondition(String pricingTier) {
+    @ValueSource(strings = { "standard", "premium" })
+    void nativeConnectionFactoryBeanConfiguredByPropertyCondition(String pricingTier) {
         this.contextRunner
             .withPropertyValues(
                 "spring.jms.servicebus.pricing-tier=" + pricingTier,
@@ -336,7 +336,7 @@ void nativeConnectionFactoryBeanConfiguredByProperteyCondition(String pricingTie
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "basic", "standard", "premium" })
+    @ValueSource(strings = { "standard", "premium" })
     void jmsPoolConnectionFactoryBeanConfiguredByPropertyCondition(String pricingTier) {
         this.contextRunner
             .withPropertyValues(