Modify tests to pass coverage (Azure#37234)

* Modify testGoal to verify

* Remove skip of sip tests

* Remove models from coverage

* Add new tests

* Fix format

* Remove new tests

* Remove unused imports

* Update test

* Update test

* Add new tests

* Modify assets

* Exclude models

* Include models

* Add tests for models

* Modify assets

* Modify assets

* Modify assets

* Skip live tests

* Update assert

* Add converter tests

* Update converter tests

* Skip annotation

* Add tests

* Fix format

* Remove unused import

* Update assets

* Remove unwanted changes

* Add tests with Context

* Remove unwanted test

* Remove unwanted import

* Fix tests

* Test adding ppe to our service

* Update tests.yml

Author: sofiar-msft

sdk/communication/azure-communication-phonenumbers/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "java",
   "TagPrefix": "java/communication/azure-communication-phonenumbers",
-  "Tag": "java/communication/azure-communication-phonenumbers_3083b8b6c8"
+  "Tag": "java/communication/azure-communication-phonenumbers_154a5685d1"
 }

sdk/communication/azure-communication-phonenumbers/src/test/java/com/azure/communication/phonenumbers/PhoneNumbersAsyncClientIntegrationTest.java

@@ -2,11 +2,16 @@
 // Licensed under the MIT License.
 package com.azure.communication.phonenumbers;
 
+import com.azure.communication.phonenumbers.implementation.converters.PhoneNumberErrorConverter;
+import com.azure.communication.phonenumbers.implementation.models.CommunicationError;
+import com.azure.communication.phonenumbers.models.BillingFrequency;
+import com.azure.communication.phonenumbers.models.PhoneNumberAdministrativeDivision;
 import com.azure.communication.phonenumbers.models.PhoneNumberAreaCode;
 import com.azure.communication.phonenumbers.models.PhoneNumberAssignmentType;
 import com.azure.communication.phonenumbers.models.PhoneNumberCapabilities;
 import com.azure.communication.phonenumbers.models.PhoneNumberCapabilityType;
 import com.azure.communication.phonenumbers.models.PhoneNumberCountry;
+import com.azure.communication.phonenumbers.models.PhoneNumberError;
 import com.azure.communication.phonenumbers.models.PhoneNumberLocality;
 import com.azure.communication.phonenumbers.models.PhoneNumberOffering;
 import com.azure.communication.phonenumbers.models.PhoneNumberOperation;
@@ -29,6 +34,8 @@
 import reactor.test.StepVerifier;
 
 import java.time.Duration;
+import java.util.ArrayList;
+import java.util.List;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -273,6 +280,7 @@ public void getGeographicAreaCodesWithAAD(HttpClient httpClient) {
                         .next())
                 .assertNext((PhoneNumberAreaCode areaCodes) -> {
                     assertNotNull(areaCodes);
+                    assertNotNull(areaCodes.getAreaCode());
                 })
                 .verifyComplete();
     }
@@ -311,6 +319,7 @@ public void getLocalitiesAdministrativeDivisionWithAAD(HttpClient httpClient) {
                 .assertNext((PhoneNumberLocality localityWithAD) -> {
                     assertNotNull(localityWithAD);
                     assertEquals(localityWithAD.getAdministrativeDivision().getAbbreviatedName(), locality.getAdministrativeDivision().getAbbreviatedName());
+                    assertEquals(localityWithAD.getAdministrativeDivision().getLocalizedName(), locality.getAdministrativeDivision().getLocalizedName());
                 })
                 .verifyComplete();
     }
@@ -323,6 +332,10 @@ public void getOfferingsWithAAD(HttpClient httpClient) {
                         .listAvailableOfferings("US", null, null).next())
                 .assertNext((PhoneNumberOffering offering) -> {
                     assertNotNull(offering);
+                    offering.getCost().getBillingFrequency();
+                    assertNotNull(BillingFrequency.values());
+                    assertNotNull(offering.getCost().getCurrencyCode());
+                    assertNotNull(offering.getCost().getAmount());
                 })
                 .verifyComplete();
     }
@@ -336,6 +349,15 @@ public void getTollFreeAreaCodes(HttpClient httpClient) {
                 .expectAccessibleContext();
     }
 
+    @ParameterizedTest
+    @MethodSource("com.azure.core.test.TestBase#getHttpClients")
+    public void getTollFreeAreaCodesWrongCountryCode(HttpClient httpClient) {
+        StepVerifier.create(
+                this.getClientWithConnectionString(httpClient, "listAvailableTollFreeAreaCodes")
+                        .listAvailableTollFreeAreaCodes("XX", PhoneNumberAssignmentType.APPLICATION).next())
+                .expectError();
+    }
+
     @ParameterizedTest
     @MethodSource("com.azure.core.test.TestBase#getHttpClients")
     public void getGeographicAreaCodes(HttpClient httpClient) {
@@ -348,10 +370,22 @@ public void getGeographicAreaCodes(HttpClient httpClient) {
                         .next())
                 .assertNext((PhoneNumberAreaCode areaCodes) -> {
                     assertNotNull(areaCodes);
+                    assertNotNull(areaCodes.getAreaCode());
                 })
                 .verifyComplete();
     }
 
+    @ParameterizedTest
+    @MethodSource("com.azure.core.test.TestBase#getHttpClients")
+    public void getGeographicAreaCodesWronglocality(HttpClient httpClient) {
+        StepVerifier.create(
+                this.getClientWithConnectionString(httpClient, "listAvailableGeographicAreaCodes")
+                        .listAvailableGeographicAreaCodes("US", PhoneNumberAssignmentType.PERSON,
+                                "XX", "XX")
+                        .next())
+                .expectError();
+    }
+
     @ParameterizedTest
     @MethodSource("com.azure.core.test.TestBase#getHttpClients")
     public void getCountries(HttpClient httpClient) {
@@ -379,19 +413,30 @@ public void getLocalities(HttpClient httpClient) {
     @ParameterizedTest
     @MethodSource("com.azure.core.test.TestBase#getHttpClients")
     public void getLocalitiesAdministrativeDivision(HttpClient httpClient) {
-        String localityAdministraiveDivision = this.getClientWithConnectionString(httpClient, "listAvailableLocalities")
-                .listAvailableLocalities("US", null).blockFirst().getAdministrativeDivision().getAbbreviatedName();
+        PhoneNumberAdministrativeDivision localityAdministraiveDivision = this.getClientWithConnectionString(httpClient, "listAvailableLocalities")
+                .listAvailableLocalities("US", null).blockFirst().getAdministrativeDivision();
         StepVerifier.create(
                 this.getClientWithConnectionString(httpClient, "listAvailableLocalities")
-                        .listAvailableLocalities("US", localityAdministraiveDivision).next())
+                        .listAvailableLocalities("US", localityAdministraiveDivision.getAbbreviatedName()).next())
                 .assertNext((PhoneNumberLocality locality) -> {
                     assertNotNull(locality);
                     assertEquals(locality.getAdministrativeDivision().getAbbreviatedName(),
-                            localityAdministraiveDivision);
+                            localityAdministraiveDivision.getAbbreviatedName());
+                    assertEquals(locality.getAdministrativeDivision().getLocalizedName(),
+                            localityAdministraiveDivision.getLocalizedName());
                 })
                 .verifyComplete();
     }
 
+    @ParameterizedTest
+    @MethodSource("com.azure.core.test.TestBase#getHttpClients")
+    public void getLocalitiesInvalidAdministrativeDivision(HttpClient httpClient) {
+        StepVerifier.create(
+                this.getClientWithConnectionString(httpClient, "listAvailableLocalities")
+                        .listAvailableLocalities("US", "null").next())
+                .expectError();
+    }
+
     @ParameterizedTest
     @MethodSource("com.azure.core.test.TestBase#getHttpClients")
     public void getOfferings(HttpClient httpClient) {
@@ -400,10 +445,41 @@ public void getOfferings(HttpClient httpClient) {
                         .listAvailableOfferings("US", null, null).next())
                 .assertNext((PhoneNumberOffering offering) -> {
                     assertNotNull(offering);
+                    offering.getCost().getBillingFrequency();
+                    assertNotNull(BillingFrequency.values());
+                    assertNotNull(offering.getCost().getCurrencyCode());
+                    assertNotNull(offering.getCost().getAmount());
                 })
                 .verifyComplete();
     }
 
+    @ParameterizedTest
+    @MethodSource("com.azure.core.test.TestBase#getHttpClients")
+    public void convertCommunicationError(HttpClient httpClient) {
+        List<PhoneNumberError> details = new ArrayList<PhoneNumberError>();
+        CommunicationError communicationError = new CommunicationError();
+        communicationError.setCode("500");
+        communicationError.setMessage("Communication Error");
+
+        PhoneNumberError phoneNumberError = new PhoneNumberError(
+            communicationError.getMessage(),
+            communicationError.getCode(),
+            communicationError.getTarget(),
+            details
+        );
+        PhoneNumberError error = PhoneNumberErrorConverter.convert(communicationError);
+        assertEquals(phoneNumberError.getCode(), error.getCode());
+        assertEquals(phoneNumberError.getMessage(), error.getMessage());
+    }
+
+    @ParameterizedTest
+    @MethodSource("com.azure.core.test.TestBase#getHttpClients")
+    public void convertCommunicationErrorWithNull(HttpClient httpClient) {
+        CommunicationError communicationError = null;
+        PhoneNumberError error = PhoneNumberErrorConverter.convert(communicationError);
+        assertEquals(null, error);
+    }
+
     private PollerFlux<PhoneNumberOperation, PhoneNumberSearchResult> beginSearchAvailablePhoneNumbersHelper(
         PhoneNumbersAsyncClient client, boolean withOptions) {
         PhoneNumberCapabilities capabilities = new PhoneNumberCapabilities();