Skip to content

Commit a51007c

Browse files
authored
assign default endpoint (Azure#34278)
1 parent 70502c3 commit a51007c

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

sdk/appconfiguration/azure-data-appconfiguration/src/main/java/com/azure/data/appconfiguration/ConfigurationClientBuilder.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ public final class ConfigurationClientBuilder implements
138138

139139
private ClientOptions clientOptions;
140140
private String connectionString;
141-
private ConfigurationClientCredentials credential;
142141
private TokenCredential tokenCredential;
143142

144143
private String endpoint;
@@ -210,7 +209,7 @@ public ConfigurationAsyncClient buildAsyncClient() {
210209
* authentication per builder instance.
211210
*/
212211
private AzureAppConfigurationImpl buildInnerClient(SyncTokenPolicy syncTokenPolicy) {
213-
String endpointLocal = null;
212+
String endpointLocal = endpoint;
214213
ConfigurationClientCredentials credentialsLocal = null;
215214
TokenCredential tokenCredentialLocal = null;
216215
// validate the authentication setup

sdk/appconfiguration/azure-data-appconfiguration/src/test/java/com/azure/data/appconfiguration/ConfigurationClientBuilderTest.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,17 @@ public void missingEndpoint() {
5959
});
6060
}
6161

62+
@Test
63+
@DoNotRecord
64+
public void clientMissingEndpointButTokenCredentialProvided() {
65+
assertThrows(NullPointerException.class, () -> {
66+
final ConfigurationClientBuilder builder = new ConfigurationClientBuilder();
67+
TokenCredential credentials = request -> Mono.just(
68+
new AccessToken("this_is_a_token", OffsetDateTime.MAX));
69+
builder.credential(credentials).buildClient();
70+
});
71+
}
72+
6273
@Test
6374
@DoNotRecord
6475
public void malformedURLExceptionForEndpoint() {

0 commit comments

Comments
 (0)