support withLogicalSectorSize (Azure#35433)

Author: XiaofeiCao

sdk/resourcemanager/azure-resourcemanager-compute/CHANGELOG.md

@@ -4,6 +4,9 @@
 
 ### Features Added
 
+- Supported `withLogicalSectorSizeInBytes` in `Disk`.
+- Supported `PREMIUM_V2_LRS` in `DiskSkuTypes`.
+
 ### Breaking Changes
 
 ### Bugs Fixed

sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/implementation/DiskImpl.java

@@ -142,6 +142,11 @@ public boolean isHibernationSupported() {
         return ResourceManagerUtils.toPrimitiveBoolean(innerModel().supportsHibernation());
     }
 
+    @Override
+    public Integer logicalSectorSizeInBytes() {
+        return this.innerModel().creationData().logicalSectorSize();
+    }
+
     @Override
     public DiskImpl withLinuxFromVhd(String vhdUrl) {
         this
@@ -405,6 +410,13 @@ public DiskImpl withoutHibernationSupport() {
         return this;
     }
 
+    @Override
+    public DiskImpl withLogicalSectorSizeInBytes(int logicalSectorSizeInBytes) {
+        // creation data should already be initialized in previous mandatory stages, e.g. withData()
+        this.innerModel().creationData().withLogicalSectorSize(logicalSectorSizeInBytes);
+        return this;
+    }
+
     @Override
     public Mono<Disk> createResourceAsync() {
         return manager()

sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/models/Disk.java

@@ -86,6 +86,9 @@ public interface Disk extends GroupableResource<ComputeManager, DiskInner>, Refr
     /** @return whether the OS on a disk supports hibernation. */
     boolean isHibernationSupported();
 
+    /** @return logical sector size in bytes for Premium SSD v2 and Ultra disks. */
+    Integer logicalSectorSizeInBytes();
+
     /** The entirety of the managed disk definition. */
     interface Definition
         extends DefinitionStages.Blank,
@@ -430,6 +433,18 @@ interface WithHibernationSupport {
             WithCreate withHibernationSupport();
         }
 
+        /** The stage of the managed disk definition allowing to configure logical sector size for Premium SSD v2 and Ultra Disks. */
+        interface WithLogicalSectorSize {
+            /**
+             * Specifies the logical sector size in bytes for Premium SSD v2 and Ultra Disks.
+             * Supported values are 512 and 4096. 4096 is the default.
+             *
+             * @param logicalSectorSizeInBytes logical sector size in bytes
+             * @return the next stage of the definition
+             */
+            WithCreate withLogicalSectorSizeInBytes(int logicalSectorSizeInBytes);
+        }
+
         /**
          * The stage of the definition which contains all the minimum required inputs for the resource to be created,
          * but also allows for any other optional settings to be specified.
@@ -440,7 +455,8 @@ interface WithCreate
                 WithSku,
                 WithAvailabilityZone,
                 WithDiskEncryption,
-                WithHibernationSupport {
+                WithHibernationSupport,
+                WithLogicalSectorSize {
 
             /**
              * Begins creating the disk resource.

sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/models/DiskSkuTypes.java

@@ -26,6 +26,9 @@ public final class DiskSkuTypes {
     /** Static value ULTRA_SSD_LRS for DiskSkuTypes. */
     public static final DiskSkuTypes ULTRA_SSD_LRS = new DiskSkuTypes(DiskStorageAccountTypes.ULTRA_SSD_LRS);
 
+    /** Static value PREMIUM_V2_LRS for DiskSkuTypes. */
+    public static final DiskSkuTypes PREMIUM_V2_LRS = new DiskSkuTypes(DiskStorageAccountTypes.PREMIUM_V2_LRS);
+
     /** The actual serialized value for a DiskSkuTypes instance. */
     private final DiskStorageAccountTypes value;
 

sdk/resourcemanager/azure-resourcemanager-compute/src/test/java/com/azure/resourcemanager/compute/ManagedDiskOperationsTests.java

@@ -361,4 +361,43 @@ public void canCopyStartIncrementalSnapshot() {
         Assertions.assertEquals(fromSnapshotDisk.source().type(), CreationSourceType.COPIED_FROM_SNAPSHOT);
         Assertions.assertTrue(fromSnapshotDisk.source().sourceId().equalsIgnoreCase(snapshotNewRegion.id()));
     }
+
+    @Test
+    public void canCreateWithLogicalSectorSize() {
+        String diskName = generateRandomResourceName("disk", 15);
+
+        // logical sector size is null for standard SKU
+        Disk defaultDisk =
+            computeManager
+                .disks()
+                .define("default_disk")
+                .withRegion(Region.US_EAST)
+                .withNewResourceGroup(rgName)
+                .withData()
+                .withSizeInGB(1)
+                .withSku(DiskSkuTypes.STANDARD_LRS)
+                .create();
+
+        defaultDisk.refresh();
+
+        Assertions.assertNull(defaultDisk.logicalSectorSizeInBytes());
+
+        // can specify logical sector size on PREMIUM_V2_LRS
+        Disk disk =
+            computeManager
+                .disks()
+                .define(diskName)
+                .withRegion(Region.US_EAST)
+                .withExistingResourceGroup(rgName)
+                .withData()
+                .withSizeInGB(10)
+                .withSku(DiskSkuTypes.PREMIUM_V2_LRS)
+                .withLogicalSectorSizeInBytes(512)
+                .create();
+
+        disk.refresh();
+
+        Assertions.assertEquals(DiskSkuTypes.PREMIUM_V2_LRS, disk.sku());
+        Assertions.assertEquals(512, disk.logicalSectorSizeInBytes());
+    }
 }