Skip to content

Commit 9acda3f

Browse files
authored
[AppConfig] Address AppConfig Arch-board feedbacks (Azure#36945)
1 parent a3cce09 commit 9acda3f

34 files changed

+878
-872
lines changed

sdk/appconfiguration/azure-data-appconfiguration/CHANGELOG.md

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,19 @@
1111
Note: Below breaking changes only affect the version `1.5.0-beta.1`.
1212

1313
- Changed `listConfigurationSettingsForSnapshot` method's `SettingFields[] fields` parameter type to `List<SettingFields> fields`.
14-
- Renamed `ConfigurationSettingSnapshot` to `ConfigurationSettingsSnapshot`.
15-
- Renamed `ConfigurationSettingSnapshot`'s property name, `size` to `sizeInBytes`.
16-
14+
- Renamed `ConfigurationSettingSnapshot` to `ConfigurationSnapshot`.
15+
- Renamed `ConfigurationSettingSnapshot`'s properties name,
16+
- `size` to `sizeInBytes`,
17+
- `compositionType` to `snapshotComposition`.
18+
- Renamed `SnapshotSettingFilter` to `ConfigurationSettingsFilter`.
19+
- Added `azure-core-experimental` as a dependency and replaced usage of `CreateSnapshotOperationDetail` by `PollResult`
20+
and removed `CreateSnapshotOperationDetail` class.
21+
- Replaced
22+
- `archiveSnapshotWithResponse(ConfigurationSettingsSnapshot, boolean)` by `archiveSnapshotWithResponse(String, MatchConditions)`
23+
- `recoverSnapshotWithResponse(ConfigurationSettingsSnapshot, boolean)` by `recoverSnapshotWithResponse(String, MatchConditions)`
24+
- `archiveSnapshotWithResponse(ConfigurationSettingsSnapshot, boolean, Context)` by `archiveSnapshotWithResponse(String, MatchConditions, Context)`
25+
- `recoverSnapshotWithResponse(ConfigurationSettingsSnapshot, boolean, Context)` by `recoverSnapshotWithResponse(String, MatchConditions, Context)`
26+
1727
### Bugs Fixed
1828

1929
### Other Changes

sdk/appconfiguration/azure-data-appconfiguration/README.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -451,21 +451,21 @@ ConfigurationAsyncClient configurationAsyncClient = new ConfigurationClientBuild
451451

452452
### Create a Snapshot
453453

454-
To create a snapshot, you need to instantiate the `ConfigurationSettingsSnapshot` class and specify filters to determine
454+
To create a snapshot, you need to instantiate the `ConfigurationSnapshot` class and specify filters to determine
455455
which configuration settings should be included. The creation process is a Long-Running Operation (LRO) and can be
456456
achieved by calling the `beginCreateSnapshot` method.
457457

458458
```java readme-sample-createSnapshot
459459
String snapshotName = "{snapshotName}";
460460
// Prepare the snapshot filters
461-
List<SnapshotSettingFilter> filters = new ArrayList<>();
461+
List<ConfigurationSettingsFilter> filters = new ArrayList<>();
462462
// Key Name also supports RegExp but only support prefix end with "*", such as "k*" and is case-sensitive.
463-
filters.add(new SnapshotSettingFilter("Test*"));
464-
SyncPoller<CreateSnapshotOperationDetail, ConfigurationSettingsSnapshot> poller =
465-
configurationClient.beginCreateSnapshot(snapshotName, new ConfigurationSettingsSnapshot(filters), Context.NONE);
463+
filters.add(new ConfigurationSettingsFilter("Test*"));
464+
SyncPoller<PollResult, ConfigurationSnapshot> poller =
465+
configurationClient.beginCreateSnapshot(snapshotName, new ConfigurationSnapshot(filters), Context.NONE);
466466
poller.setPollInterval(Duration.ofSeconds(10));
467467
poller.waitForCompletion();
468-
ConfigurationSettingsSnapshot snapshot = poller.getFinalResult();
468+
ConfigurationSnapshot snapshot = poller.getFinalResult();
469469
System.out.printf("Snapshot name=%s is created at %s, snapshot status is %s.%n",
470470
snapshot.getName(), snapshot.getCreatedAt(), snapshot.getStatus());
471471
```
@@ -476,7 +476,7 @@ Once a configuration setting snapshot is created, you can retrieve it using the
476476

477477
```java readme-sample-getSnapshot
478478
String snapshotName = "{snapshotName}";
479-
ConfigurationSettingsSnapshot getSnapshot = configurationClient.getSnapshot(snapshotName);
479+
ConfigurationSnapshot getSnapshot = configurationClient.getSnapshot(snapshotName);
480480
System.out.printf("Snapshot name=%s is created at %s, snapshot status is %s.%n",
481481
getSnapshot.getName(), getSnapshot.getCreatedAt(), getSnapshot.getStatus());
482482
```
@@ -488,7 +488,7 @@ to `archived`.
488488

489489
```java readme-sample-archiveSnapshot
490490
String snapshotName = "{snapshotName}";
491-
ConfigurationSettingsSnapshot archivedSnapshot = configurationClient.archiveSnapshot(snapshotName);
491+
ConfigurationSnapshot archivedSnapshot = configurationClient.archiveSnapshot(snapshotName);
492492
System.out.printf("Archived snapshot name=%s is created at %s, snapshot status is %s.%n",
493493
archivedSnapshot.getName(), archivedSnapshot.getCreatedAt(), archivedSnapshot.getStatus());
494494
```
@@ -500,7 +500,7 @@ snapshot to `ready`.
500500

501501
```java readme-sample-recoverSnapshot
502502
String snapshotName = "{snapshotName}";
503-
ConfigurationSettingsSnapshot recoveredSnapshot = configurationClient.recoverSnapshot(snapshotName);
503+
ConfigurationSnapshot recoveredSnapshot = configurationClient.recoverSnapshot(snapshotName);
504504
System.out.printf("Recovered snapshot name=%s is created at %s, snapshot status is %s.%n",
505505
recoveredSnapshot.getName(), recoveredSnapshot.getCreatedAt(), recoveredSnapshot.getStatus());
506506
```
@@ -511,10 +511,10 @@ To retrieve all snapshots, you can use the `listSnapshots` method.
511511

512512
```java readme-sample-getAllSnapshots
513513
String snapshotNameProduct = "{snapshotNameInProduct}";
514-
SnapshotSelector snapshotSelector = new SnapshotSelector().setName(snapshotNameProduct);
515-
PagedIterable<ConfigurationSettingsSnapshot> configurationSettingsSnapshots =
514+
SnapshotSelector snapshotSelector = new SnapshotSelector().setNameFilter(snapshotNameProduct);
515+
PagedIterable<ConfigurationSnapshot> configurationSnapshots =
516516
configurationClient.listSnapshots(snapshotSelector);
517-
for (ConfigurationSettingsSnapshot snapshot : configurationSettingsSnapshots) {
517+
for (ConfigurationSnapshot snapshot : configurationSnapshots) {
518518
System.out.printf("Listed Snapshot name = %s is created at %s, snapshot status is %s.%n",
519519
snapshot.getName(), snapshot.getCreatedAt(), snapshot.getStatus());
520520
}

sdk/appconfiguration/azure-data-appconfiguration/assets.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"AssetsRepo": "Azure/azure-sdk-assets",
33
"AssetsRepoPrefixPath": "java",
44
"TagPrefix": "java/appconfiguration/azure-data-appconfiguration",
5-
"Tag": "java/appconfiguration/azure-data-appconfiguration_2cf918b584"
5+
"Tag": "java/appconfiguration/azure-data-appconfiguration_b0d3480df4"
66
}

sdk/appconfiguration/azure-data-appconfiguration/pom.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,11 @@
6363
<artifactId>azure-core-http-netty</artifactId>
6464
<version>1.13.7</version> <!-- {x-version-update;com.azure:azure-core-http-netty;dependency} -->
6565
</dependency>
66-
66+
<dependency>
67+
<groupId>com.azure</groupId>
68+
<artifactId>azure-core-experimental</artifactId>
69+
<version>1.0.0-beta.43</version> <!-- {x-version-update;com.azure:azure-core-experimental;dependency} -->
70+
</dependency>
6771
<!-- Test dependencies -->
6872
<dependency>
6973
<groupId>com.azure</groupId>

0 commit comments

Comments
 (0)