Skip to content

Commit 3b8efe1

Browse files
authored
Renaming in Azure Spring Monitor (Azure#36583)
1 parent 33bcb13 commit 3b8efe1

File tree

7 files changed

+31
-31
lines changed

7 files changed

+31
-31
lines changed

eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,9 @@
108108
<suppress checks="IllegalImport" files="com.azure.messaging.eventhubs.TracingIntegrationTests.java"/>
109109
<suppress checks="IllegalImport" files="com.azure.messaging.eventhubs.PublishEventsTracingWithCustomContextSample.java"/>
110110

111-
<!-- AzureTelemetryConfig defines Spring bean used in https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java-->
111+
<!-- AzureSpringMonitorConfig defines Spring bean used in https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java-->
112112
<suppress checks="com.azure.tools.checkstyle.checks.ExternalDependencyExposedCheck"
113-
files="com.azure.monitor.applicationinsights.spring.AzureTelemetryConfig.java"/>
113+
files="com.azure.monitor.applicationinsights.spring.AzureSpringMonitorConfig.java"/>
114114

115115
<!-- For the Application Insights Spring Boot starter for Spring native, users have only to declare the starter dependency. Users won't manipulate the Java classes of this Spring Boot starter. -->
116116
<suppress checks="Javadoc" files=".*[/\\]com[/\\]azure[/\\]monitor[/\\]applicationinsights[/\\]spring[/\\]*"/>
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@
44
package com.azure.monitor.applicationinsights.spring;
55

66
/**
7-
* Azure telemetry activation
7+
* Azure Azure Spring Monitor activation
88
*/
9-
public final class AzureTelemetryActivation {
9+
public final class AzureSpringMonitorActivation {
1010

11-
/** a flag to indicate if AzureTelemetry is activated or not. */
11+
/** a flag to indicate if Azure Spring Monitor is activated or not. */
1212
private final boolean activated;
1313

1414
/**
15-
* Creates an instance of {@link AzureTelemetryActivation}.
15+
* Creates an instance of {@link AzureSpringMonitorActivation}.
1616
*/
17-
public AzureTelemetryActivation() {
17+
public AzureSpringMonitorActivation() {
1818
this.activated = true; // We leave the AzureTelemetryActivation class because it could be used to provide the ability
1919
// to disable the starter features
2020
}
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,18 @@
77
import org.springframework.context.annotation.Configuration;
88

99
/**
10-
* Config for AzureTelemetryActivation
10+
* Config for AzureSpringMonitorActivation
1111
*/
1212
@Configuration(proxyBeanMethods = false)
13-
public class AzureTelemetryActivationConfig {
13+
public class AzureSpringMonitorActivationConfig {
1414

1515
/**
16-
* Declare an AzureTelemetryActivation bean
17-
* @return AzureTelemetryActivation
16+
* Declare an AzureSpringMonitorActivation bean
17+
* @return AzureSpringMonitorActivation
1818
*/
1919
@Bean
20-
public AzureTelemetryActivation azureTelemetryActivation() {
21-
return new AzureTelemetryActivation();
20+
public AzureSpringMonitorActivation azureSpringMonitorActivation() {
21+
return new AzureSpringMonitorActivation();
2222
}
2323

2424

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
import org.springframework.context.annotation.Import;
1010

1111
/**
12-
* Auto config for Azure Telemetry
12+
* Auto config for Azure Spring Monitor
1313
*/
1414
@Configuration(proxyBeanMethods = false)
1515
@AutoConfigureBefore(OpenTelemetryAutoConfiguration.class)
16-
@Import({AzureTelemetryConfig.class, AzureTelemetryActivationConfig.class})
17-
public class AzureTelemetryAutoConfig {
16+
@Import({AzureSpringMonitorConfig.class, AzureSpringMonitorActivationConfig.class})
17+
public class AzureSpringMonitorAutoConfig {
1818
}
Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,22 +19,22 @@
1919
* Config for Azure Telemetry
2020
*/
2121
@Configuration(proxyBeanMethods = false)
22-
public class AzureTelemetryConfig {
22+
public class AzureSpringMonitorConfig {
2323

24-
private static final ClientLogger LOGGER = new ClientLogger(AzureTelemetryConfig.class);
24+
private static final ClientLogger LOGGER = new ClientLogger(AzureSpringMonitorConfig.class);
2525

2626
private static final String CONNECTION_STRING_ERROR_MESSAGE = "Unable to find the Application Insights connection string.";
2727

2828
private final Optional<AzureMonitorExporterBuilder> azureMonitorExporterBuilderOpt;
2929

3030
/**
31-
* Create an instance of AzureTelemetryConfig
31+
* Create an instance of AzureSpringMonitorConfig
3232
* @param connectionStringSysProp connection string system property
33-
* @param azureTelemetryActivation a instance of AzureTelemetryActivation
33+
* @param azureSpringMonitorActivation a instance of AzureTelemetryActivation
3434
* @param httpPipeline an instance of HttpPipeline
3535
*/
36-
public AzureTelemetryConfig(@Value("${applicationinsights.connection.string:}") String connectionStringSysProp, AzureTelemetryActivation azureTelemetryActivation, ObjectProvider<HttpPipeline> httpPipeline) {
37-
if (azureTelemetryActivation.isTrue()) {
36+
public AzureSpringMonitorConfig(@Value("${applicationinsights.connection.string:}") String connectionStringSysProp, AzureSpringMonitorActivation azureSpringMonitorActivation, ObjectProvider<HttpPipeline> httpPipeline) {
37+
if (azureSpringMonitorActivation.isTrue()) {
3838
this.azureMonitorExporterBuilderOpt = createAzureMonitorExporterBuilder(connectionStringSysProp, httpPipeline);
3939
if (!isNativeRuntimeExecution()) {
4040
LOGGER.warning("You are using Application Insights for Spring in a non-native GraalVM runtime environment. We recommend using the Application Insights Java agent.");
@@ -77,7 +77,7 @@ private Optional<AzureMonitorExporterBuilder> createAzureMonitorExporterBuilder(
7777
* @return MetricExporter
7878
*/
7979
@Bean
80-
public MetricExporter metricExporter() {
80+
public MetricExporter azureSpringMonitorMetricExporter() {
8181
if (!azureMonitorExporterBuilderOpt.isPresent()) {
8282
return null;
8383
}
@@ -89,7 +89,7 @@ public MetricExporter metricExporter() {
8989
* @return SpanExporter
9090
*/
9191
@Bean
92-
public SpanExporter spanExporter() {
92+
public SpanExporter azureSpringMonitorSpanExporter() {
9393
if (!azureMonitorExporterBuilderOpt.isPresent()) {
9494
return null;
9595
}
@@ -101,7 +101,7 @@ public SpanExporter spanExporter() {
101101
* @return LogRecordExporter
102102
*/
103103
@Bean
104-
public LogRecordExporter logRecordExporter() {
104+
public LogRecordExporter azureSpringMonitorLogRecordExporter() {
105105
if (!azureMonitorExporterBuilderOpt.isPresent()) {
106106
return null;
107107
}

sdk/spring/spring-cloud-azure-starter-monitor/src/main/java/com/azure/monitor/applicationinsights/spring/JvmMetricsPostProcessor.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@
2020
// See https://github.com/Azure/azure-sdk-for-java/issues/35725
2121
public class JvmMetricsPostProcessor implements BeanPostProcessor, Ordered {
2222

23-
private final AzureTelemetryActivation azureTelemetryActivation;
23+
private final AzureSpringMonitorActivation azureSpringMonitorActivation;
2424

2525
/**
2626
* Create an instance of JvmMetricsPostProcessor
27-
* @param azureTelemetryActivation the azure telemetry activation
27+
* @param azureSpringMonitorActivation the azure telemetry activation
2828
*/
29-
public JvmMetricsPostProcessor(AzureTelemetryActivation azureTelemetryActivation) {
30-
this.azureTelemetryActivation = azureTelemetryActivation;
29+
public JvmMetricsPostProcessor(AzureSpringMonitorActivation azureSpringMonitorActivation) {
30+
this.azureSpringMonitorActivation = azureSpringMonitorActivation;
3131
}
3232

3333
/**
@@ -39,7 +39,7 @@ public JvmMetricsPostProcessor(AzureTelemetryActivation azureTelemetryActivation
3939
*/
4040
@Override
4141
public Object postProcessAfterInitialization(Object bean, String beanName) throws BeansException {
42-
if (azureTelemetryActivation.isTrue() && bean instanceof OpenTelemetry) {
42+
if (azureSpringMonitorActivation.isTrue() && bean instanceof OpenTelemetry) {
4343
OpenTelemetry openTelemetry = (OpenTelemetry) bean;
4444
BufferPools.registerObservers(openTelemetry);
4545
Classes.registerObservers(openTelemetry);
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
com.azure.monitor.applicationinsights.spring.AzureTelemetryAutoConfig
1+
com.azure.monitor.applicationinsights.spring.AzureSpringMonitorAutoConfig

0 commit comments

Comments
 (0)