Skip to content

Commit 1d790d3

Browse files
author
Liudmila Molkova
authored
[Sync stack] random improvements (Azure#31028)
* [Sync stack] random improvements
1 parent cbae516 commit 1d790d3

File tree

33 files changed

+1
-53
lines changed
  • sdk
    • communication
    • core/azure-core
    • formrecognizer/azure-ai-formrecognizer
    • identity/azure-identity
    • keyvault/azure-security-keyvault-secrets
    • monitor
    • personalizer/azure-ai-personalizer
    • resourcemanager
      • azure-resourcemanager-appservice
      • azure-resourcemanager-authorization
      • azure-resourcemanager-compute
      • azure-resourcemanager-containerservice
      • azure-resourcemanager-cosmos
      • azure-resourcemanager-keyvault
      • azure-resourcemanager-monitor
      • azure-resourcemanager-msi
      • azure-resourcemanager-network
      • azure-resourcemanager-privatedns
      • azure-resourcemanager-resources
      • azure-resourcemanager-servicebus
      • azure-resourcemanager-storage
      • azure-resourcemanager
    • storage
    • textanalytics/azure-ai-textanalytics

33 files changed

+1
-53
lines changed

sdk/communication/azure-communication-identity/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,6 @@
5555
<!-- Configures the Java 9+ run to perform the required module exports, opens, and reads that are necessary for testing but shouldn't be part of the module-info. -->
5656
<javaModulesSurefireArgLine>
5757
--add-opens com.azure.communication.identity/com.azure.communication.identity=ALL-UNNAMED
58-
<!-- azure-communication-identity uses Identity in tests which loads NettyAsyncHttpClient from unnamed module in "from source" core runs -->
59-
--add-opens com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
6058
</javaModulesSurefireArgLine>
6159
</properties>
6260

sdk/communication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsClientTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import org.junit.jupiter.params.ParameterizedTest;
1515
import org.junit.jupiter.params.provider.MethodSource;
1616

17-
import java.nio.charset.StandardCharsets;
1817
import java.util.Arrays;
1918

2019
import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -176,7 +175,7 @@ public void checkForRepeatabilityOptions(HttpClient httpClient) {
176175
client = setupSyncClient(builder, "checkForRepeatabilityOptions");
177176
// Action & Assert
178177
Response<Iterable<SmsSendResult>> response = client.sendWithResponse(FROM_PHONE_NUMBER, Arrays.asList(TO_PHONE_NUMBER, TO_PHONE_NUMBER), MESSAGE, null, Context.NONE);
179-
String bodyRequest = StandardCharsets.UTF_8.decode(response.getRequest().getBody().blockLast()).toString();
178+
String bodyRequest = response.getRequest().getBodyAsBinaryData().toString();
180179
assertTrue(bodyRequest.contains("repeatabilityRequestId"));
181180
assertTrue(bodyRequest.contains("repeatabilityFirstSent"));
182181
}

sdk/core/azure-core/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@
6666
--add-opens com.azure.core/com.azure.core.implementation.serializer=ALL-UNNAMED
6767
--add-opens com.azure.core/com.azure.core.implementation.jackson=ALL-UNNAMED
6868
--add-opens com.azure.core/com.azure.core.implementation.logging=ALL-UNNAMED
69-
--add-opens com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
7069
--add-opens com.azure.core/com.azure.core.models=ALL-UNNAMED
7170
--add-opens com.azure.core/com.azure.core.util=ALL-UNNAMED
7271
--add-opens com.azure.core/com.azure.core.util.logging=ALL-UNNAMED

sdk/formrecognizer/azure-ai-formrecognizer/pom.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@
3737
<javaModulesSurefireArgLine>
3838
--add-exports com.azure.core/com.azure.core.implementation.http=ALL-UNNAMED
3939

40-
--add-exports com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
41-
--add-opens com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
42-
4340
--add-opens com.azure.ai.formrecognizer/com.azure.ai.formrecognizer=ALL-UNNAMED
4441
--add-opens com.azure.ai.formrecognizer/com.azure.ai.formrecognizer.documentanalysis=ALL-UNNAMED
4542
--add-opens com.azure.ai.formrecognizer/com.azure.ai.formrecognizer.documentanalysis.administration=ALL-UNNAMED

sdk/identity/azure-identity/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
<!-- Configures the Java 9+ run to perform the required module exports, opens, and reads that are necessary for testing but shouldn't be part of the module-info. -->
1818
<javaModulesSurefireArgLine>
1919
--add-opens java.xml/jdk.xml.internal=ALL-UNNAMED
20-
<!-- Identity loads NettyAsyncHttpClient from unnamed module in "from source" core runs -->
21-
--add-opens com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
2220
</javaModulesSurefireArgLine>
2321
</properties>
2422

sdk/keyvault/azure-security-keyvault-secrets/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
<!-- Configures the Java 9+ run to perform the required module exports, opens, and reads that are necessary for testing but shouldn't be part of the module-info. -->
4848
<javaModulesSurefireArgLine>
4949
--add-exports com.azure.core/com.azure.core.implementation.http=ALL-UNNAMED
50-
--add-exports com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
5150

5251
--add-opens com.azure.security.keyvault.secrets/com.azure.security.keyvault.secrets=ALL-UNNAMED
5352
--add-opens com.azure.security.keyvault.secrets/com.azure.security.keyvault.secrets.implementation=ALL-UNNAMED

sdk/monitor/azure-monitor-ingestion/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@
4848
<javaModulesSurefireArgLine>
4949
--add-exports com.azure.core/com.azure.core.implementation.jackson=ALL-UNNAMED
5050
--add-opens com.azure.monitor.ingestion/com.azure.monitor.ingestion=ALL-UNNAMED
51-
--add-exports com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
52-
--add-opens com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
5351
</javaModulesSurefireArgLine>
5452
</properties>
5553

sdk/monitor/azure-monitor-query/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@
3232
<javaModulesSurefireArgLine>
3333
--add-exports com.azure.core/com.azure.core.implementation.jackson=ALL-UNNAMED
3434
--add-opens com.azure.monitor.query/com.azure.monitor.query=ALL-UNNAMED
35-
--add-exports com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
36-
--add-opens com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
3735
</javaModulesSurefireArgLine>
3836
<checkstyle.excludes>**/implementation/**/*.java</checkstyle.excludes>
3937
</properties>

sdk/personalizer/azure-ai-personalizer/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@
3737
<javaModulesSurefireArgLine>
3838
--add-exports com.azure.core/com.azure.core.implementation.http=ALL-UNNAMED
3939
--add-opens com.azure.ai.personalizer/com.azure.ai.personalizer=ALL-UNNAMED
40-
--add-exports com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
41-
--add-opens com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
4240
</javaModulesSurefireArgLine>
4341
</properties>
4442

sdk/resourcemanager/azure-resourcemanager-appservice/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@
4848
--add-opens com.azure.resourcemanager.resources/com.azure.resourcemanager.resources=ALL-UNNAMED
4949
--add-opens com.azure.resourcemanager.resources/com.azure.resourcemanager.resources.fluentcore.arm=ALL-UNNAMED
5050
--add-opens com.azure.resourcemanager.storage/com.azure.resourcemanager.storage=ALL-UNNAMED
51-
52-
--add-opens com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
5351
</javaModulesSurefireArgLine>
5452
</properties>
5553

0 commit comments

Comments
 (0)