mgmt, ACI upgrade 2023-05 (Azure#34480)

Author: weidongxu-microsoft

sdk/resourcemanager/api-specs.json

@@ -53,7 +53,7 @@
     "dir": "azure-resourcemanager-containerinstance",
     "source": "specification/containerinstance/resource-manager/readme.md",
     "package": "com.azure.resourcemanager.containerinstance",
-    "args": "--tag=package-2021-10 --remove-inner=Container,Operation,CachedImages,Capabilities"
+    "args": "--tag=package-2023-05 --remove-inner=Container,Operation,CachedImages,Capabilities --rename-model=ContainerGroupPropertiesProperties:ContainerGroupProperties,UserAssignedIdentities:ContainerGroupIdentityUserAssignedIdentities"
   },
   "containerregistry": {
     "dir": "azure-resourcemanager-containerregistry",

sdk/resourcemanager/azure-resourcemanager-containerinstance/CHANGELOG.md

@@ -2,14 +2,16 @@
 
 ## 2.26.0-beta.1 (Unreleased)
 
-### Features Added
-
 ### Breaking Changes
 
-### Bugs Fixed
+- Renamed `autoGeneratedDomainNameLabelScope` property to `dnsNameLabelReusePolicy` in `IpAddress`.
 
 ### Other Changes
 
+#### Dependency Updates
+
+- Updated `api-version` to `2023-05-01`.
+
 ## 2.25.0 (2023-03-24)
 
 ### Other Changes

sdk/resourcemanager/azure-resourcemanager-containerinstance/pom.xml

@@ -44,6 +44,7 @@
 
       --add-opens com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
     </javaModulesSurefireArgLine>
+    <revapi.skip>true</revapi.skip>
   </properties>
 
   <developers>

sdk/resourcemanager/azure-resourcemanager-containerinstance/src/main/java/com/azure/resourcemanager/containerinstance/fluent/ContainerGroupsClient.java

@@ -72,4 +72,11 @@ public interface ContainerInstanceManagementClient {
      * @return the ContainersClient object.
      */
     ContainersClient getContainers();
+
+    /**
+     * Gets the SubnetServiceAssociationLinksClient object to access its operations.
+     *
+     * @return the SubnetServiceAssociationLinksClient object.
+     */
+    SubnetServiceAssociationLinksClient getSubnetServiceAssociationLinks();
 }

sdk/resourcemanager/azure-resourcemanager-containerinstance/src/main/java/com/azure/resourcemanager/containerinstance/fluent/ContainerInstanceManagementClient.java

@@ -17,7 +17,9 @@
 /** An instance of this class provides access to all the operations defined in ContainersClient. */
 public interface ContainersClient {
     /**
-     * Get the logs for a specified container instance in a specified resource group and container group.
+     * Get the logs for a specified container instance.
+     *
+     * <p>Get the logs for a specified container instance in a specified resource group and container group.
      *
      * @param resourceGroupName The name of the resource group.
      * @param containerGroupName The name of the container group.
@@ -37,27 +39,9 @@ Mono<Response<LogsInner>> listLogsWithResponseAsync(
         String resourceGroupName, String containerGroupName, String containerName, Integer tail, Boolean timestamps);
 
     /**
-     * Get the logs for a specified container instance in a specified resource group and container group.
+     * Get the logs for a specified container instance.
      *
-     * @param resourceGroupName The name of the resource group.
-     * @param containerGroupName The name of the container group.
-     * @param containerName The name of the container instance.
-     * @param tail The number of lines to show from the tail of the container instance log. If not provided, all
-     *     available logs are shown up to 4mb.
-     * @param timestamps If true, adds a timestamp at the beginning of every line of log output. If not provided,
-     *     defaults to false.
-     * @throws IllegalArgumentException thrown if parameters fail the validation.
-     * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
-     * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
-     * @return the logs for a specified container instance in a specified resource group and container group on
-     *     successful completion of {@link Mono}.
-     */
-    @ServiceMethod(returns = ReturnType.SINGLE)
-    Mono<LogsInner> listLogsAsync(
-        String resourceGroupName, String containerGroupName, String containerName, Integer tail, Boolean timestamps);
-
-    /**
-     * Get the logs for a specified container instance in a specified resource group and container group.
+     * <p>Get the logs for a specified container instance in a specified resource group and container group.
      *
      * @param resourceGroupName The name of the resource group.
      * @param containerGroupName The name of the container group.
@@ -72,21 +56,9 @@ Mono<LogsInner> listLogsAsync(
     Mono<LogsInner> listLogsAsync(String resourceGroupName, String containerGroupName, String containerName);
 
     /**
-     * Get the logs for a specified container instance in a specified resource group and container group.
+     * Get the logs for a specified container instance.
      *
-     * @param resourceGroupName The name of the resource group.
-     * @param containerGroupName The name of the container group.
-     * @param containerName The name of the container instance.
-     * @throws IllegalArgumentException thrown if parameters fail the validation.
-     * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
-     * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
-     * @return the logs for a specified container instance in a specified resource group and container group.
-     */
-    @ServiceMethod(returns = ReturnType.SINGLE)
-    LogsInner listLogs(String resourceGroupName, String containerGroupName, String containerName);
-
-    /**
-     * Get the logs for a specified container instance in a specified resource group and container group.
+     * <p>Get the logs for a specified container instance in a specified resource group and container group.
      *
      * @param resourceGroupName The name of the resource group.
      * @param containerGroupName The name of the container group.
@@ -112,7 +84,25 @@ Response<LogsInner> listLogsWithResponse(
         Context context);
 
     /**
-     * Executes a command for a specific container instance in a specified resource group and container group.
+     * Get the logs for a specified container instance.
+     *
+     * <p>Get the logs for a specified container instance in a specified resource group and container group.
+     *
+     * @param resourceGroupName The name of the resource group.
+     * @param containerGroupName The name of the container group.
+     * @param containerName The name of the container instance.
+     * @throws IllegalArgumentException thrown if parameters fail the validation.
+     * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
+     * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
+     * @return the logs for a specified container instance in a specified resource group and container group.
+     */
+    @ServiceMethod(returns = ReturnType.SINGLE)
+    LogsInner listLogs(String resourceGroupName, String containerGroupName, String containerName);
+
+    /**
+     * Executes a command in a specific container instance.
+     *
+     * <p>Executes a command for a specific container instance in a specified resource group and container group.
      *
      * @param resourceGroupName The name of the resource group.
      * @param containerGroupName The name of the container group.
@@ -132,7 +122,9 @@ Mono<Response<ContainerExecResponseInner>> executeCommandWithResponseAsync(
         ContainerExecRequest containerExecRequest);
 
     /**
-     * Executes a command for a specific container instance in a specified resource group and container group.
+     * Executes a command in a specific container instance.
+     *
+     * <p>Executes a command for a specific container instance in a specified resource group and container group.
      *
      * @param resourceGroupName The name of the resource group.
      * @param containerGroupName The name of the container group.
@@ -151,47 +143,54 @@ Mono<ContainerExecResponseInner> executeCommandAsync(
         ContainerExecRequest containerExecRequest);
 
     /**
-     * Executes a command for a specific container instance in a specified resource group and container group.
+     * Executes a command in a specific container instance.
+     *
+     * <p>Executes a command for a specific container instance in a specified resource group and container group.
      *
      * @param resourceGroupName The name of the resource group.
      * @param containerGroupName The name of the container group.
      * @param containerName The name of the container instance.
      * @param containerExecRequest The request for the exec command.
+     * @param context The context to associate with this operation.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
      * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
      * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
-     * @return the information for the container exec command.
+     * @return the information for the container exec command along with {@link Response}.
      */
     @ServiceMethod(returns = ReturnType.SINGLE)
-    ContainerExecResponseInner executeCommand(
+    Response<ContainerExecResponseInner> executeCommandWithResponse(
         String resourceGroupName,
         String containerGroupName,
         String containerName,
-        ContainerExecRequest containerExecRequest);
+        ContainerExecRequest containerExecRequest,
+        Context context);
 
     /**
-     * Executes a command for a specific container instance in a specified resource group and container group.
+     * Executes a command in a specific container instance.
+     *
+     * <p>Executes a command for a specific container instance in a specified resource group and container group.
      *
      * @param resourceGroupName The name of the resource group.
      * @param containerGroupName The name of the container group.
      * @param containerName The name of the container instance.
      * @param containerExecRequest The request for the exec command.
-     * @param context The context to associate with this operation.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
      * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
      * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
-     * @return the information for the container exec command along with {@link Response}.
+     * @return the information for the container exec command.
      */
     @ServiceMethod(returns = ReturnType.SINGLE)
-    Response<ContainerExecResponseInner> executeCommandWithResponse(
+    ContainerExecResponseInner executeCommand(
         String resourceGroupName,
         String containerGroupName,
         String containerName,
-        ContainerExecRequest containerExecRequest,
-        Context context);
+        ContainerExecRequest containerExecRequest);
 
     /**
-     * Attach to the output stream of a specific container instance in a specified resource group and container group.
+     * Attach to the output of a specific container instance.
+     *
+     * <p>Attach to the output stream of a specific container instance in a specified resource group and container
+     * group.
      *
      * @param resourceGroupName The name of the resource group.
      * @param containerGroupName The name of the container group.
@@ -207,7 +206,10 @@ Mono<Response<ContainerAttachResponseInner>> attachWithResponseAsync(
         String resourceGroupName, String containerGroupName, String containerName);
 
     /**
-     * Attach to the output stream of a specific container instance in a specified resource group and container group.
+     * Attach to the output of a specific container instance.
+     *
+     * <p>Attach to the output stream of a specific container instance in a specified resource group and container
+     * group.
      *
      * @param resourceGroupName The name of the resource group.
      * @param containerGroupName The name of the container group.
@@ -222,32 +224,38 @@ Mono<ContainerAttachResponseInner> attachAsync(
         String resourceGroupName, String containerGroupName, String containerName);
 
     /**
-     * Attach to the output stream of a specific container instance in a specified resource group and container group.
+     * Attach to the output of a specific container instance.
+     *
+     * <p>Attach to the output stream of a specific container instance in a specified resource group and container
+     * group.
      *
      * @param resourceGroupName The name of the resource group.
      * @param containerGroupName The name of the container group.
      * @param containerName The name of the container instance.
+     * @param context The context to associate with this operation.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
      * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
      * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
-     * @return the information for the output stream from container attach.
+     * @return the information for the output stream from container attach along with {@link Response}.
      */
     @ServiceMethod(returns = ReturnType.SINGLE)
-    ContainerAttachResponseInner attach(String resourceGroupName, String containerGroupName, String containerName);
+    Response<ContainerAttachResponseInner> attachWithResponse(
+        String resourceGroupName, String containerGroupName, String containerName, Context context);
 
     /**
-     * Attach to the output stream of a specific container instance in a specified resource group and container group.
+     * Attach to the output of a specific container instance.
+     *
+     * <p>Attach to the output stream of a specific container instance in a specified resource group and container
+     * group.
      *
      * @param resourceGroupName The name of the resource group.
      * @param containerGroupName The name of the container group.
      * @param containerName The name of the container instance.
-     * @param context The context to associate with this operation.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
      * @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
      * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
-     * @return the information for the output stream from container attach along with {@link Response}.
+     * @return the information for the output stream from container attach.
      */
     @ServiceMethod(returns = ReturnType.SINGLE)
-    Response<ContainerAttachResponseInner> attachWithResponse(
-        String resourceGroupName, String containerGroupName, String containerName, Context context);
+    ContainerAttachResponseInner attach(String resourceGroupName, String containerGroupName, String containerName);
 }

sdk/resourcemanager/azure-resourcemanager-containerinstance/src/main/java/com/azure/resourcemanager/containerinstance/fluent/ContainersClient.java

@@ -53,7 +53,9 @@ public interface LocationsClient {
     PagedIterable<UsageInner> listUsage(String location, Context context);
 
     /**
-     * Get the list of cached images on specific OS type for a subscription in a region.
+     * Get the list of cached images.
+     *
+     * <p>Get the list of cached images on specific OS type for a subscription in a region.
      *
      * @param location The identifier for the physical azure location.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
@@ -66,7 +68,9 @@ public interface LocationsClient {
     PagedFlux<CachedImages> listCachedImagesAsync(String location);
 
     /**
-     * Get the list of cached images on specific OS type for a subscription in a region.
+     * Get the list of cached images.
+     *
+     * <p>Get the list of cached images on specific OS type for a subscription in a region.
      *
      * @param location The identifier for the physical azure location.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
@@ -79,7 +83,9 @@ public interface LocationsClient {
     PagedIterable<CachedImages> listCachedImages(String location);
 
     /**
-     * Get the list of cached images on specific OS type for a subscription in a region.
+     * Get the list of cached images.
+     *
+     * <p>Get the list of cached images on specific OS type for a subscription in a region.
      *
      * @param location The identifier for the physical azure location.
      * @param context The context to associate with this operation.
@@ -93,7 +99,9 @@ public interface LocationsClient {
     PagedIterable<CachedImages> listCachedImages(String location, Context context);
 
     /**
-     * Get the list of CPU/memory/GPU capabilities of a region.
+     * Get the list of capabilities of the location.
+     *
+     * <p>Get the list of CPU/memory/GPU capabilities of a region.
      *
      * @param location The identifier for the physical azure location.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
@@ -105,7 +113,9 @@ public interface LocationsClient {
     PagedFlux<Capabilities> listCapabilitiesAsync(String location);
 
     /**
-     * Get the list of CPU/memory/GPU capabilities of a region.
+     * Get the list of capabilities of the location.
+     *
+     * <p>Get the list of CPU/memory/GPU capabilities of a region.
      *
      * @param location The identifier for the physical azure location.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
@@ -117,7 +127,9 @@ public interface LocationsClient {
     PagedIterable<Capabilities> listCapabilities(String location);
 
     /**
-     * Get the list of CPU/memory/GPU capabilities of a region.
+     * Get the list of capabilities of the location.
+     *
+     * <p>Get the list of CPU/memory/GPU capabilities of a region.
      *
      * @param location The identifier for the physical azure location.
      * @param context The context to associate with this operation.