Skip to content

Commit dbfd8d0

Browse files
authored
upgrade azcore version and change test poller method (Azure#18465)
1 parent 569bfe9 commit dbfd8d0

File tree

4 files changed

+14
-29
lines changed

4 files changed

+14
-29
lines changed

sdk/resourcemanager/internal/CHANGELOG.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,9 @@
11
# Release History
22

3-
## 1.0.1 (Unreleased)
4-
5-
### Features Added
6-
7-
### Breaking Changes
8-
9-
### Bugs Fixed
3+
## 1.0.1 (2022-06-23)
104

115
### Other Changes
6+
* Upgrade `azcore` version and change test `poller` method
127

138
## 1.0.0 (2022-05-16)
149

sdk/resourcemanager/internal/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal
33
go 1.18
44

55
require (
6-
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.0.0
6+
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.1.0
77
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.0.0
88
github.com/Azure/azure-sdk-for-go/sdk/internal v1.0.0
99
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources v1.0.0

sdk/resourcemanager/internal/go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.0.0 h1:sVPhtT2qjO86rTUaWMr4WoES4TkjGnzcioXcnHV9s5k=
2-
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.0.0/go.mod h1:uGG2W01BaETf0Ozp+QxxKJdMBNRWPdstHG0Fmdwn1/U=
1+
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.1.0 h1:Ut0ZGdOwJDw0npYEg+TLlPls3Pq6JiZaP2/aGKir7Zw=
2+
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.1.0/go.mod h1:uGG2W01BaETf0Ozp+QxxKJdMBNRWPdstHG0Fmdwn1/U=
33
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.0.0 h1:Yoicul8bnVdQrhDMTHxdEckRGX01XvwXDHUT9zYZ3k0=
44
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.0.0/go.mod h1:+6sju8gk8FRmSajX3Oz4G5Gm7P+mbqE9FVaXXFYTkCM=
55
github.com/Azure/azure-sdk-for-go/sdk/internal v1.0.0 h1:jp0dGvZ7ZK0mgqnTSClMxa5xuRL7NZgHameVYF6BurY=

sdk/resourcemanager/internal/testutil/helper.go

Lines changed: 9 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -90,25 +90,15 @@ func CreateDeployment(ctx context.Context, subscriptionId string, cred azcore.To
9090
// Playback: customer poll loop until get result
9191
// Others: use original poll until done
9292
func PollForTest[T any](ctx context.Context, poller *runtime.Poller[T]) (*T, error) {
93+
pollOptions := runtime.PollUntilDoneOptions{
94+
Frequency: 0, // Pass zero to accept the default value (30s).
95+
}
9396
if recording.GetRecordMode() == recording.PlaybackMode {
94-
for {
95-
_, err := poller.Poll(ctx)
96-
if err != nil {
97-
return nil, err
98-
}
99-
if poller.Done() {
100-
res, err := poller.Result(ctx)
101-
if err != nil {
102-
return nil, err
103-
}
104-
return &res, nil
105-
}
106-
}
107-
} else {
108-
res, err := poller.PollUntilDone(ctx, nil)
109-
if err != nil {
110-
return nil, err
111-
}
112-
return &res, nil
97+
pollOptions.Frequency = time.Millisecond // If playback, do not wait
98+
}
99+
res, err := poller.PollUntilDone(ctx, &pollOptions)
100+
if err != nil {
101+
return nil, err
113102
}
103+
return &res, nil
114104
}

0 commit comments

Comments
 (0)