fix changelog function filter (Azure#20001)

* fix changelog function filter

* add test

* fix

* rename to BeginDelete

* add test...

Author: Alancere

eng/tools/generator/cmd/v2/common/changelogProcessor.go

@@ -305,7 +305,7 @@ func funcOperation(content *delta.Content) {
 				if funcValue.Returns != nil {
 					rs := strings.Split(*funcValue.Returns, ",")
 					clientFuncResponse := rs[0]
-					if strings.Contains(clientFunc[1], "runtime.Poller") {
+					if strings.Contains(clientFuncResponse, "runtime") {
 						re := regexp.MustCompile("\\[(?P<response>.*)\\]")
 						clientFuncResponse = re.FindString(clientFuncResponse)
 						clientFuncResponse = re.ReplaceAllString(clientFuncResponse, "${response}")
@@ -337,7 +337,7 @@ func LROFilter(changelog *model.Changelog) {
 			clientFunc := strings.Split(bFunc, ".")
 			if len(clientFunc) == 2 {
 				if strings.Contains(clientFunc[1], "Begin") {
-					clientFunc[1] = strings.ReplaceAll(clientFunc[1], "Being", "")
+					clientFunc[1] = strings.TrimPrefix(clientFunc[1], "Begin")
 					beginFunc = fmt.Sprintf("%s.%s", clientFunc[0], clientFunc[1])
 				} else {
 					beginFunc = fmt.Sprintf("%s.Begin%s", clientFunc[0], clientFunc[1])

eng/tools/generator/cmd/v2/common/changelogProcessor_test.go

@@ -53,7 +53,7 @@ func TestFuncFilter(t *testing.T) {
 
 	common.FilterChangelog(changelog, common.FuncFilter)
 
-	excepted := fmt.Sprint("### Breaking Changes\n\n- Function `*Client.Update` has been removed\n\n### Features Added\n\n- New function `*Client.BeginCreateOrUpdate(string, *ClientBeginCreateOrUpdateOptions) (ClientBeginCreateOrUpdateResponse, error)`\n")
+	excepted := fmt.Sprint("### Breaking Changes\n\n- Function `*Client.BeingDelete` has been removed\n- Function `*Client.NewListPager` has been removed\n- Function `*Client.Update` has been removed\n\n### Features Added\n\n- New function `*Client.BeginCreateOrUpdate(string, *ClientBeginCreateOrUpdateOptions) (ClientBeginCreateOrUpdateResponse, error)`\n- New function `*Client.NewListBySubscriptionPager(*ClientListBySubscriptionOptions) *runtime.Pager[ClientListBySubscriptionResponse]`\n")
 	assert.Equal(t, excepted, changelog.ToCompactMarkdown())
 }
 
@@ -75,7 +75,7 @@ func TestLROFilter(t *testing.T) {
 
 	common.FilterChangelog(changelog, common.FuncFilter, common.LROFilter)
 
-	excepted := fmt.Sprint("### Breaking Changes\n\n- Operation `*Client.CreateOrUpdate` has been changed to LRO, use `*Client.BeginCreateOrUpdate` instead.\n")
+	excepted := fmt.Sprint("### Breaking Changes\n\n- Operation `*Client.BeginDelete` has been changed to non-LRO, use `*Client.Delete` instead.\n- Operation `*Client.CreateOrUpdate` has been changed to LRO, use `*Client.BeginCreateOrUpdate` instead.\n")
 	assert.Equal(t, excepted, changelog.ToCompactMarkdown())
 }
 

eng/tools/generator/cmd/v2/common/testdata/new/lro/lrofilter.go

@@ -13,3 +13,12 @@ func (client *Client) BeginCreateOrUpdate(resourceGroupName string, options *Cli
 type ClientBeginCreateOrUpdateOptions struct{}
 
 type ClientBeginCreateOrUpdateResponse struct{}
+
+func (client *Client) Delete(resourceGroupName string, options *ClientDeleteOptions) (ClientDeleteResponse, error) {
+
+	return ClientDeleteResponse{}, nil
+}
+
+type ClientDeleteOptions struct{}
+
+type ClientDeleteResponse struct{}

eng/tools/generator/cmd/v2/common/testdata/new/operation/funcfilter.go

@@ -13,3 +13,11 @@ func (client *Client) BeginCreateOrUpdate(resourceGroupName string, options *Cli
 type ClientBeginCreateOrUpdateOptions struct{}
 
 type ClientBeginCreateOrUpdateResponse struct{}
+
+func (client *Client) NewListBySubscriptionPager(options *ClientListBySubscriptionOptions) *runtime.Pager[ClientListBySubscriptionResponse] {
+	return &runtime.Pager[ClientListBySubscriptionResponse]
+}
+
+type ClientListBySubscriptionOptions struct{}
+
+type ClientListBySubscriptionResponse struct{}

eng/tools/generator/cmd/v2/common/testdata/old/lro/lrofilter.go

@@ -13,3 +13,12 @@ func (client *Client) CreateOrUpdate(resourceGroupName string, options *ClientCr
 type ClientCreateOrUpdateOptions struct{}
 
 type ClientCreateOrUpdateResponse struct{}
+
+func (client *Client) BeginDelete(resourceGroupName string, options *ClientBeginDeleteOptions) (ClientBeginDeleteResponse, error) {
+
+	return ClientBeginDeleteResponse{}, nil
+}
+
+type ClientBeginDeleteOptions struct{}
+
+type ClientBeginDeleteResponse struct{}

eng/tools/generator/cmd/v2/common/testdata/old/operation/funcfilter.go

@@ -13,3 +13,20 @@ func (client *Client) Update(resourceGroupName string, options *ClientUpdateOpti
 type ClientUpdateOptions struct{}
 
 type ClientUpdateResponse struct{}
+
+func (client *Client) BeingDelete(resourceGroupName string, options *ClientBeginDeleteOptions) (*runtime.Poller[ClientBeginDeleteResponse], error) {
+
+	return &runtime.Poller[ClientBeginDeleteResponse]{}, nil
+}
+
+type ClientBeginDeleteOptions struct{}
+
+type ClientBeginDeleteResponse struct{}
+
+func (client *Client) NewListPager(resourceGroupName string, options *ClientListOptions) *runtime.Pager[ClientListResponse] {
+	return &runtime.Pager[ClientListResponse]
+}
+
+type ClientListOptions struct{}
+
+type ClientListResponse struct{}