Skip to content

Commit 912f496

Browse files
tadeleshtadelesh
authored
update generator to add type alias change to changelog (Azure#18894)
1 parent 03952f8 commit 912f496

File tree

3 files changed

+30
-14
lines changed

3 files changed

+30
-14
lines changed

‎eng/tools/generator/autorest/model/changelog.go‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,12 @@ func getNewContents(c *delta.Content) []string {
129129
items = append(items, line)
130130
}
131131
}
132+
if len(c.TypeAliases) > 0 {
133+
for k := range c.TypeAliases {
134+
line := fmt.Sprintf("New type alias `%s`", k)
135+
items = append(items, line)
136+
}
137+
}
132138
if len(c.Funcs) > 0 {
133139
for k, v := range c.Funcs {
134140
params := ""
@@ -199,6 +205,13 @@ func getSignatureChangeItems(b *report.BreakingChanges) []string {
199205
}
200206
// TODO -- sort?
201207
}
208+
// write type alias changes
209+
if len(b.TypeAliases) > 0 {
210+
for k, v := range b.TypeAliases {
211+
line := fmt.Sprintf("Type alias `%s` type has been changed from `%s` to `%s`", k, v.From, v.To)
212+
items = append(items, line)
213+
}
214+
}
202215
// write function changes
203216
if len(b.Funcs) > 0 {
204217
for k, v := range b.Funcs {
@@ -239,6 +252,13 @@ func getRemovedContent(removed *delta.Content) []string {
239252
items = append(items, line)
240253
}
241254
}
255+
// write type alias
256+
if len(removed.TypeAliases) > 0 {
257+
for k := range removed.TypeAliases {
258+
line := fmt.Sprintf("Type alias `%s` has been removed", k)
259+
items = append(items, line)
260+
}
261+
}
242262
// write functions
243263
if len(removed.Funcs) > 0 {
244264
for k := range removed.Funcs {

‎eng/tools/generator/go.mod‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module github.com/Azure/azure-sdk-for-go/eng/tools/generator
33
go 1.18
44

55
require (
6-
github.com/Azure/azure-sdk-for-go/eng/tools/internal v0.0.0-20220614215044-0a110946e756
6+
github.com/Azure/azure-sdk-for-go/eng/tools/internal v0.0.0-20220818052413-721290d54e79
77
github.com/Masterminds/semver v1.5.0
88
github.com/ahmetb/go-linq/v3 v3.2.0
99
github.com/go-git/go-git/v5 v5.4.2
@@ -24,7 +24,7 @@ require (
2424
github.com/go-git/gcfg v1.5.0 // indirect
2525
github.com/go-git/go-billy/v5 v5.3.1 // indirect
2626
github.com/golang/protobuf v1.4.2 // indirect
27-
github.com/google/go-querystring v1.1.0 // indirect
27+
github.com/google/go-querystring v1.0.0 // indirect
2828
github.com/hashicorp/errwrap v1.0.0 // indirect
2929
github.com/imdario/mergo v0.3.12 // indirect
3030
github.com/inconshreveable/mousetrap v1.0.0 // indirect
@@ -34,10 +34,10 @@ require (
3434
github.com/pmezard/go-difflib v1.0.0 // indirect
3535
github.com/sergi/go-diff v1.1.0 // indirect
3636
github.com/xanzy/ssh-agent v0.3.0 // indirect
37-
golang.org/x/crypto v0.0.0-20210817164053-32db794688a5 // indirect
37+
golang.org/x/crypto v0.0.0-20210421170649-83a5a9bb288b // indirect
3838
golang.org/x/net v0.0.0-20220127200216-cd36cc0744dd // indirect
3939
golang.org/x/sys v0.0.0-20211216021012-1d35b9e2eb4e // indirect
40-
google.golang.org/appengine v1.6.7 // indirect
40+
google.golang.org/appengine v1.6.6 // indirect
4141
google.golang.org/protobuf v1.25.0 // indirect
4242
gopkg.in/warnings.v0 v0.1.2 // indirect
4343
gopkg.in/yaml.v3 v3.0.1 // indirect

‎eng/tools/generator/go.sum‎

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ cloud.google.com/go/storage v1.6.0/go.mod h1:N7U0C8pVQ/+NIKOBQyamJIeKQKkZ+mxpohl
3131
cloud.google.com/go/storage v1.8.0/go.mod h1:Wv1Oy7z6Yz3DshWRJFhqM/UCfaWIRTdp0RXyy7KQOVs=
3232
cloud.google.com/go/storage v1.10.0/go.mod h1:FLPqc6j+Ki4BU591ie1oL6qBQGu2Bl/tZ9ullr3+Kg0=
3333
dmitri.shuralyov.com/gpu/mtl v0.0.0-20190408044501-666a987793e9/go.mod h1:H6x//7gZCb22OMCxBHrMx7a5I7Hp++hsVxbQ4BYO7hU=
34-
github.com/Azure/azure-sdk-for-go/eng/tools/internal v0.0.0-20220614215044-0a110946e756 h1:I0EYX4mEqd1awbnwCKM0N/GpiUDVcy3i9opbPyAeJu0=
35-
github.com/Azure/azure-sdk-for-go/eng/tools/internal v0.0.0-20220614215044-0a110946e756/go.mod h1:o10ccRC1wnNEL7uLpQUTfuF4aYjkEvDkAP/pdVbw+7M=
34+
github.com/Azure/azure-sdk-for-go/eng/tools/internal v0.0.0-20220818052413-721290d54e79 h1:Wdn3plqhHEowOpVKVeWaUjJRB0Rke1kPA5I+vLx72fo=
35+
github.com/Azure/azure-sdk-for-go/eng/tools/internal v0.0.0-20220818052413-721290d54e79/go.mod h1:o10ccRC1wnNEL7uLpQUTfuF4aYjkEvDkAP/pdVbw+7M=
3636
github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
3737
github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo=
3838
github.com/Masterminds/semver v1.5.0 h1:H65muMkzWKEuNDnfl9d70GUjFniHKHRbFPGBuZ3QEww=
@@ -115,14 +115,12 @@ github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMyw
115115
github.com/google/go-cmp v0.4.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
116116
github.com/google/go-cmp v0.4.1/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
117117
github.com/google/go-cmp v0.5.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
118+
github.com/google/go-cmp v0.5.1 h1:JFrFEBb2xKufg6XkJsJr+WbKb4FQlURi5RUcBveYu9k=
118119
github.com/google/go-cmp v0.5.1/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
119-
github.com/google/go-cmp v0.5.2 h1:X2ev0eStA3AbceY54o37/0PQ/UWqKEiiO2dKL5OPaFM=
120-
github.com/google/go-cmp v0.5.2/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
121120
github.com/google/go-github/v32 v32.1.0 h1:GWkQOdXqviCPx7Q7Fj+KyPoGm4SwHRh8rheoPhd27II=
122121
github.com/google/go-github/v32 v32.1.0/go.mod h1:rIEpZD9CTDQwDK9GDrtMTycQNA4JU3qBsCizh3q2WCI=
122+
github.com/google/go-querystring v1.0.0 h1:Xkwi/a1rcvNg1PPYe5vI8GbeBY/jrVuDX5ASuANWTrk=
123123
github.com/google/go-querystring v1.0.0/go.mod h1:odCYkC5MyYFN7vkCjXpyrEuKhc/BUO6wN/zVPAxq5ck=
124-
github.com/google/go-querystring v1.1.0 h1:AnCroh3fv4ZBgVIf1Iwtovgjaw/GiKJo8M8yD/fhyJ8=
125-
github.com/google/go-querystring v1.1.0/go.mod h1:Kcdr2DB4koayq7X8pmAG4sNG59So17icRSOU623lUBU=
126124
github.com/google/martian v2.1.0+incompatible/go.mod h1:9I4somxYTbIHy5NJKHRl3wXiIaQGbYVAs8BPL6v8lEs=
127125
github.com/google/martian/v3 v3.0.0/go.mod h1:y5Zk1BBys9G+gd6Jrk0W3cC1+ELVxBWuIGO+w/tUAp0=
128126
github.com/google/pprof v0.0.0-20181206194817-3ea8567a2e57/go.mod h1:zfwlbNMJ+OItoe0UupaVj+oy1omPYYDuagoSzA8v9mc=
@@ -206,9 +204,8 @@ golang.org/x/crypto v0.0.0-20190605123033-f99c8df09eb5/go.mod h1:yigFU9vqHzYiE8U
206204
golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
207205
golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
208206
golang.org/x/crypto v0.0.0-20210322153248-0c34fe9e7dc2/go.mod h1:T9bdIzuCu7OtxOm1hfPfRQxPLYneinmdGuTeoZ9dtd4=
207+
golang.org/x/crypto v0.0.0-20210421170649-83a5a9bb288b h1:7mWr3k41Qtv8XlltBkDkl8LoP3mpSgBW8BUoxtEdbXg=
209208
golang.org/x/crypto v0.0.0-20210421170649-83a5a9bb288b/go.mod h1:T9bdIzuCu7OtxOm1hfPfRQxPLYneinmdGuTeoZ9dtd4=
210-
golang.org/x/crypto v0.0.0-20210817164053-32db794688a5 h1:HWj/xjIHfjYU5nVXpTM0s39J9CbLn7Cc5a7IC5rwsMQ=
211-
golang.org/x/crypto v0.0.0-20210817164053-32db794688a5/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
212209
golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
213210
golang.org/x/exp v0.0.0-20190306152737-a1d7652674e8/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
214211
golang.org/x/exp v0.0.0-20190510132918-efd6b22b2522/go.mod h1:ZjyILWgesfNpC6sMxTJOJm9Kp84zZh5NQWvqDGG3Qr8=
@@ -397,9 +394,8 @@ google.golang.org/appengine v1.4.0/go.mod h1:xpcJRLb0r/rnEns0DIKYYv+WjYCduHsrkT7
397394
google.golang.org/appengine v1.5.0/go.mod h1:xpcJRLb0r/rnEns0DIKYYv+WjYCduHsrkT7/EB5XEv4=
398395
google.golang.org/appengine v1.6.1/go.mod h1:i06prIuMbXzDqacNJfV5OdTW448YApPu5ww/cMBSeb0=
399396
google.golang.org/appengine v1.6.5/go.mod h1:8WjMMxjGQR8xUklV/ARdw2HLXBOI7O7uCIDZVag1xfc=
397+
google.golang.org/appengine v1.6.6 h1:lMO5rYAqUxkmaj76jAkRUvt5JZgFymx/+Q5Mzfivuhc=
400398
google.golang.org/appengine v1.6.6/go.mod h1:8WjMMxjGQR8xUklV/ARdw2HLXBOI7O7uCIDZVag1xfc=
401-
google.golang.org/appengine v1.6.7 h1:FZR1q0exgwxzPzp/aF+VccGrSfxfPpkBqjIIEq3ru6c=
402-
google.golang.org/appengine v1.6.7/go.mod h1:8WjMMxjGQR8xUklV/ARdw2HLXBOI7O7uCIDZVag1xfc=
403399
google.golang.org/genproto v0.0.0-20180817151627-c66870c02cf8/go.mod h1:JiN7NxoALGmiZfu7CAH4rXhgtRTLTxftemlI0sWmxmc=
404400
google.golang.org/genproto v0.0.0-20190307195333-5fe7a883aa19/go.mod h1:VzzqZJRnGkLBvHegQrXjBqPurQTc5/KpmUdxsrq26oE=
405401
google.golang.org/genproto v0.0.0-20190418145605-e7d98fc518a7/go.mod h1:VzzqZJRnGkLBvHegQrXjBqPurQTc5/KpmUdxsrq26oE=

0 commit comments

Comments
 (0)