[azeventhubs] Fixed bug where AMQP sessions weren't being closed. (Azure#24198)

Fixes Azure#24195

Author: richardpark-msft

sdk/messaging/azeventhubs/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Release History
 
+## 1.3.1 (TBD)
+
+### Bugs Fixed
+
+- Removed a memory leak that could occur when the ConsumerClient was unable to open a partition. (PR#24198)
+
 ## 1.3.0 (2025-02-11)
 
 ### Features Added

sdk/messaging/azeventhubs/internal/constants.go

@@ -4,4 +4,4 @@
 package internal
 
 // Version is the semantic version number
-const Version = "v1.3.0"
+const Version = "v1.3.1"

sdk/messaging/azeventhubs/internal/links.go

@@ -365,11 +365,19 @@ func (ls *linkState[LinkT]) Close(ctx context.Context) error {
 		ls.cancelAuth()
 	}
 
+	var linkCloseErr error
+
 	if ls.link != nil {
-		return ls.Link().Close(ctx)
+		// we're more interested in a link failing to close than we are in
+		// the session.
+		linkCloseErr = ls.Link().Close(ctx)
 	}
 
-	return nil
+	if ls.session != nil {
+		_ = ls.session.Close(ctx)
+	}
+
+	return linkCloseErr
 }
 
 func (ls *linkState[LinkT]) PartitionID() string {

sdk/messaging/azeventhubs/internal/links_unit_test.go

@@ -134,6 +134,8 @@ func TestLinks_ConnectionRecovery(t *testing.T) {
 	ns.EXPECT().NegotiateClaim(test.NotCancelled, gomock.Any()).Return(cancelNegotiateClaim, negotiateClaimCtx.Done(), nil)
 	ns.EXPECT().NewAMQPSession(test.NotCancelled).Return(session, uint64(1), nil)
 
+	session.EXPECT().Close(gomock.Any())
+
 	receiver.EXPECT().LinkName().Return("link1").AnyTimes()
 
 	links := NewLinks(ns, "managementPath", func(partitionID string) string {
@@ -226,6 +228,8 @@ func TestLinks_closeWithTimeout(t *testing.T) {
 			ns.EXPECT().NegotiateClaim(test.NotCancelled, gomock.Any()).Return(cancelNegotiateClaim, negotiateClaimCtx.Done(), nil)
 			ns.EXPECT().NewAMQPSession(test.NotCancelled).Return(session, uint64(1), nil)
 
+			session.EXPECT().Close(gomock.Any())
+
 			receiver.EXPECT().LinkName().Return("link1").AnyTimes()
 
 			links := NewLinks(ns, "managementPath", func(partitionID string) string {
@@ -271,6 +275,7 @@ func TestLinks_linkRecoveryOnly(t *testing.T) {
 		cancelNegotiateClaim, negotiateClaimCtx.Done(), nil,
 	)
 	fakeNS.EXPECT().NewAMQPSession(test.NotCancelled).Return(session, uint64(1), nil)
+	session.EXPECT().Close(gomock.Any())
 
 	fakeReceiver.EXPECT().LinkName().Return("link1").AnyTimes()
 
@@ -306,6 +311,7 @@ func TestLinks_linkRecoveryFailsWithLinkFailure(t *testing.T) {
 		cancelNegotiateClaim, negotiateClaimCtx.Done(), nil,
 	)
 	fakeNS.EXPECT().NewAMQPSession(test.NotCancelled).Return(session, uint64(1), nil)
+	session.EXPECT().Close(gomock.Any())
 
 	fakeReceiver.EXPECT().LinkName().Return("link1").AnyTimes()