Begin moving tests to their applicable packages (Azure#18903)

* Begin moving tests to their applicable packages

Moved various test files out of the azblob package and into their
respective client packages.
Added internal/testcommon package for shared test helpers.
No functional or test changes.

* shuffle around more tests, linter clean

* update to latest internal module

* disambiguate invalid encryption scope

Author: jhendrixMSFT

sdk/storage/azblob/appendblob/client_test.go

@@ -5,7 +5,7 @@ go 1.18
 require (
 	github.com/Azure/azure-sdk-for-go/sdk/azcore v1.1.2
 	github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.1.0
-	github.com/Azure/azure-sdk-for-go/sdk/internal v1.0.0
+	github.com/Azure/azure-sdk-for-go/sdk/internal v1.0.1
 	github.com/stretchr/testify v1.7.1
 )
 

sdk/storage/azblob/blob/client_test.go

@@ -2,8 +2,8 @@ github.com/Azure/azure-sdk-for-go/sdk/azcore v1.1.2 h1:lneMk5qtUMulXa/eVxjVd+/bD
 github.com/Azure/azure-sdk-for-go/sdk/azcore v1.1.2/go.mod h1:uGG2W01BaETf0Ozp+QxxKJdMBNRWPdstHG0Fmdwn1/U=
 github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.1.0 h1:QkAcEIAKbNL4KoFr4SathZPhDhF4mVwpBMFlYjyAqy8=
 github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.1.0/go.mod h1:bhXu1AjYL+wutSL/kpSq6s7733q2Rb0yuot9Zgfqa/0=
-github.com/Azure/azure-sdk-for-go/sdk/internal v1.0.0 h1:jp0dGvZ7ZK0mgqnTSClMxa5xuRL7NZgHameVYF6BurY=
-github.com/Azure/azure-sdk-for-go/sdk/internal v1.0.0/go.mod h1:eWRD7oawr1Mu1sLCawqVc0CUiF43ia3qQMxLscsKQ9w=
+github.com/Azure/azure-sdk-for-go/sdk/internal v1.0.1 h1:XUNQ4mw+zJmaA2KXzP9JlQiecy1SI+Eog7xVkPiqIbg=
+github.com/Azure/azure-sdk-for-go/sdk/internal v1.0.1/go.mod h1:eWRD7oawr1Mu1sLCawqVc0CUiF43ia3qQMxLscsKQ9w=
 github.com/AzureAD/microsoft-authentication-library-for-go v0.5.1 h1:BWe8a+f/t+7KY7zH2mqygeUD0t8hNFXe08p1Pb3/jKE=
 github.com/AzureAD/microsoft-authentication-library-for-go v0.5.1/go.mod h1:Vt9sXTKwMyGcOxSmLDMnGPgqsUg7m8pe215qMLrDXw4=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=

sdk/storage/azblob/blockblob/client_test.go

@@ -4,17 +4,16 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
-package azblob_test
+package exported
 
 import (
 	"fmt"
-	"github.com/Azure/azure-sdk-for-go/sdk/storage/azblob"
+	"testing"
 
 	"github.com/stretchr/testify/require"
 )
 
-func (s *azblobTestSuite) TestURLParsing() {
-	_require := require.New(s.T())
+func TestParseURL(t *testing.T) {
 	testStorageAccount := "fakestorageaccount"
 	host := fmt.Sprintf("%s.blob.core.windows.net", testStorageAccount)
 	testContainer := "fakecontainer"
@@ -26,34 +25,33 @@ func (s *azblobTestSuite) TestURLParsing() {
 		snapshotID, versionID := "", "2021-10-25T05:41:32.5526810Z"
 		sasWithVersionID := "?versionId=" + versionID + "&" + sas
 		urlWithVersion := fmt.Sprintf("https://%s.blob.core.windows.net/%s%s%s", testStorageAccount, testContainer, fileName, sasWithVersionID)
-		blobURLParts, err := azblob.ParseURL(urlWithVersion)
-		_require.Nil(err)
+		blobURLParts, err := ParseURL(urlWithVersion)
+		require.NoError(t, err)
 
-		_require.Equal(blobURLParts.Scheme, "https")
-		_require.Equal(blobURLParts.Host, host)
-		_require.Equal(blobURLParts.ContainerName, testContainer)
-		_require.Equal(blobURLParts.VersionID, versionID)
-		_require.Equal(blobURLParts.Snapshot, snapshotID)
+		require.Equal(t, blobURLParts.Scheme, "https")
+		require.Equal(t, blobURLParts.Host, host)
+		require.Equal(t, blobURLParts.ContainerName, testContainer)
+		require.Equal(t, blobURLParts.VersionID, versionID)
+		require.Equal(t, blobURLParts.Snapshot, snapshotID)
 
-		validateSAS(_require, sas, blobURLParts.SAS)
+		validateSAS(t, sas, blobURLParts.SAS)
 	}
 
 	for _, fileName := range fileNames {
 		snapshotID, versionID := "2011-03-09T01:42:34Z", ""
 		sasWithSnapshotID := "?snapshot=" + snapshotID + "&" + sas
 		urlWithVersion := fmt.Sprintf("https://%s.blob.core.windows.net/%s%s%s", testStorageAccount, testContainer, fileName, sasWithSnapshotID)
-		blobURLParts, err := azblob.ParseURL(urlWithVersion)
-		_require.Nil(err)
+		blobURLParts, err := ParseURL(urlWithVersion)
+		require.NoError(t, err)
 
-		_require.Equal(blobURLParts.Scheme, "https")
-		_require.Equal(blobURLParts.Host, host)
-		_require.Equal(blobURLParts.ContainerName, testContainer)
-		_require.Equal(blobURLParts.VersionID, versionID)
-		_require.Equal(blobURLParts.Snapshot, snapshotID)
+		require.Equal(t, blobURLParts.Scheme, "https")
+		require.Equal(t, blobURLParts.Host, host)
+		require.Equal(t, blobURLParts.ContainerName, testContainer)
+		require.Equal(t, blobURLParts.VersionID, versionID)
+		require.Equal(t, blobURLParts.Snapshot, snapshotID)
 
-		validateSAS(_require, sas, blobURLParts.SAS)
+		validateSAS(t, sas, blobURLParts.SAS)
 	}
 
 	//urlWithIP := "https://127.0.0.1:5000/"
-
 }

…orage/azblob/zt_container_client_test.go …/storage/azblob/container/client_test.gosdk/storage/azblob/zt_container_client_test.go renamed to sdk/storage/azblob/container/client_test.go sdk/storage/azblob/zt_container_client_test.go renamed to sdk/storage/azblob/container/client_test.go

@@ -0,0 +1,90 @@
+//go:build go1.18
+// +build go1.18
+
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+package exported
+
+import (
+	"fmt"
+	"net/url"
+	"strings"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestSAS(t *testing.T) {
+	const sas = "sv=2019-12-12&sr=b&st=2111-01-09T01:42:34.936Z&se=2222-03-09T01:42:34.936Z&sp=rw&sip=168.1.5.60-168.1.5.70&spr=https,http&si=myIdentifier&ss=bf&srt=s&sig=clNxbtnkKSHw7f3KMEVVc4agaszoRFdbZr%2FWBmPNsrw%3D"
+	_url := fmt.Sprintf("https://teststorageaccount.blob.core.windows.net/testcontainer/testpath?%s", sas)
+	_uri, err := url.Parse(_url)
+	require.NoError(t, err)
+	sasQueryParams := NewSASQueryParameters(_uri.Query(), true)
+	validateSAS(t, sas, sasQueryParams)
+}
+
+func validateSAS(t *testing.T, sas string, parameters SASQueryParameters) {
+	sasCompMap := make(map[string]string)
+	for _, sasComp := range strings.Split(sas, "&") {
+		comp := strings.Split(sasComp, "=")
+		sasCompMap[comp[0]] = comp[1]
+	}
+
+	require.Equal(t, parameters.Version(), sasCompMap["sv"])
+	require.Equal(t, parameters.Services(), sasCompMap["ss"])
+	require.Equal(t, parameters.ResourceTypes(), sasCompMap["srt"])
+	require.Equal(t, string(parameters.Protocol()), sasCompMap["spr"])
+	if _, ok := sasCompMap["st"]; ok {
+		startTime, _, err := ParseSASTimeString(sasCompMap["st"])
+		require.NoError(t, err)
+		require.Equal(t, parameters.StartTime(), startTime)
+	}
+	if _, ok := sasCompMap["se"]; ok {
+		endTime, _, err := ParseSASTimeString(sasCompMap["se"])
+		require.NoError(t, err)
+		require.Equal(t, parameters.ExpiryTime(), endTime)
+	}
+
+	if _, ok := sasCompMap["snapshot"]; ok {
+		snapshotTime, _, err := ParseSASTimeString(sasCompMap["snapshot"])
+		require.NoError(t, err)
+		require.Equal(t, parameters.SnapshotTime(), snapshotTime)
+	}
+	ipRange := parameters.IPRange()
+	require.Equal(t, ipRange.String(), sasCompMap["sip"])
+	require.Equal(t, parameters.Identifier(), sasCompMap["si"])
+	require.Equal(t, parameters.Resource(), sasCompMap["sr"])
+	require.Equal(t, parameters.Permissions(), sasCompMap["sp"])
+
+	sign, err := url.QueryUnescape(sasCompMap["sig"])
+	require.NoError(t, err)
+
+	require.Equal(t, parameters.Signature(), sign)
+	require.Equal(t, parameters.CacheControl(), sasCompMap["rscc"])
+	require.Equal(t, parameters.ContentDisposition(), sasCompMap["rscd"])
+	require.Equal(t, parameters.ContentEncoding(), sasCompMap["rsce"])
+	require.Equal(t, parameters.ContentLanguage(), sasCompMap["rscl"])
+	require.Equal(t, parameters.ContentType(), sasCompMap["rsct"])
+	require.Equal(t, parameters.SignedOID(), sasCompMap["skoid"])
+	require.Equal(t, parameters.SignedTID(), sasCompMap["sktid"])
+
+	if _, ok := sasCompMap["skt"]; ok {
+		signedStart, _, err := ParseSASTimeString(sasCompMap["skt"])
+		require.NoError(t, err)
+		require.Equal(t, parameters.SignedStart(), signedStart)
+	}
+	require.Equal(t, parameters.SignedService(), sasCompMap["sks"])
+
+	if _, ok := sasCompMap["ske"]; ok {
+		signedExpiry, _, err := ParseSASTimeString(sasCompMap["ske"])
+		require.NoError(t, err)
+		require.Equal(t, parameters.SignedExpiry(), signedExpiry)
+	}
+
+	require.Equal(t, parameters.SignedVersion(), sasCompMap["skv"])
+	require.Equal(t, parameters.SignedDirectoryDepth(), sasCompMap["sdd"])
+	require.Equal(t, parameters.PreauthorizedAgentObjectID(), sasCompMap["saoid"])
+	require.Equal(t, parameters.AgentObjectID(), sasCompMap["suoid"])
+	require.Equal(t, parameters.SignedCorrelationID(), sasCompMap["scid"])
+}