Skip to content

Commit 71b4e49

Browse files
authored
Fix live tests for azappconfig (Azure#19921)
Recent feature introduced some bugs in a live test.
1 parent ae2eb9b commit 71b4e49

File tree

2 files changed

+9
-15
lines changed

2 files changed

+9
-15
lines changed

sdk/data/azappconfig/client.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ func fromGeneratedAdd(g generated.AzureAppConfigurationClientPutKeyValueResponse
150150
type AddSettingOptions struct {
151151
// Configuration setting label.
152152
Label *string
153+
153154
// Configuration setting content type.
154155
ContentType *string
155156
}
@@ -397,6 +398,7 @@ func fromGeneratedSet(g generated.AzureAppConfigurationClientPutKeyValueResponse
397398
type SetSettingOptions struct {
398399
// Configuration setting label.
399400
Label *string
401+
400402
// Configuration setting content type.
401403
ContentType *string
402404

sdk/data/azappconfig/client_test.go

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,10 @@ func TestClient(t *testing.T) {
9292
require.NotEmpty(t, setResp2)
9393
require.NotNil(t, setResp2.Key)
9494
require.NotNil(t, setResp2.Label)
95-
require.NotNil(t, setResp2.ContentType)
95+
require.Nil(t, setResp2.ContentType)
9696
require.NotNil(t, setResp2.Value)
9797
require.Equal(t, key, *setResp2.Key)
9898
require.Equal(t, label, *setResp2.Label)
99-
require.Equal(t, contentType, *setResp2.ContentType)
10099
require.Equal(t, value, *setResp2.Value)
101100

102101
setResp3, err8 := client.SetSetting(context.TODO(), key, &value, &SetSettingOptions{Label: &label, OnlyIfUnchanged: etag})
@@ -108,12 +107,11 @@ func TestClient(t *testing.T) {
108107
require.NotEmpty(t, roResp)
109108
require.NotNil(t, roResp.Key)
110109
require.NotNil(t, roResp.Label)
111-
require.NotNil(t, roResp.ContentType)
110+
require.Nil(t, roResp.ContentType)
112111
require.NotNil(t, roResp.Value)
113112
require.NotNil(t, roResp.IsReadOnly)
114113
require.Equal(t, key, *roResp.Key)
115114
require.Equal(t, label, *roResp.Label)
116-
require.Equal(t, contentType, *roResp.ContentType)
117115
require.Equal(t, value, *roResp.Value)
118116
require.True(t, *roResp.IsReadOnly)
119117

@@ -122,12 +120,11 @@ func TestClient(t *testing.T) {
122120
require.NotEmpty(t, roResp2)
123121
require.NotNil(t, roResp2.Key)
124122
require.NotNil(t, roResp2.Label)
125-
require.NotNil(t, roResp2.ContentType)
123+
require.Nil(t, roResp2.ContentType)
126124
require.NotNil(t, roResp2.Value)
127125
require.NotNil(t, roResp2.IsReadOnly)
128126
require.Equal(t, key, *roResp2.Key)
129127
require.Equal(t, label, *roResp2.Label)
130-
require.Equal(t, contentType, *roResp2.ContentType)
131128
require.Equal(t, value, *roResp2.Value)
132129
require.False(t, *roResp2.IsReadOnly)
133130

@@ -141,12 +138,11 @@ func TestClient(t *testing.T) {
141138
require.NotEmpty(t, roResp4)
142139
require.NotNil(t, roResp4.Key)
143140
require.NotNil(t, roResp4.Label)
144-
require.NotNil(t, roResp4.ContentType)
141+
require.Nil(t, roResp4.ContentType)
145142
require.NotNil(t, roResp4.Value)
146143
require.NotNil(t, roResp4.IsReadOnly)
147144
require.Equal(t, key, *roResp4.Key)
148145
require.Equal(t, label, *roResp4.Label)
149-
require.Equal(t, contentType, *roResp4.ContentType)
150146
require.Equal(t, value, *roResp4.Value)
151147
require.True(t, *roResp4.IsReadOnly)
152148

@@ -160,12 +156,11 @@ func TestClient(t *testing.T) {
160156
require.NotEmpty(t, roResp6)
161157
require.NotNil(t, roResp6.Key)
162158
require.NotNil(t, roResp6.Label)
163-
require.NotNil(t, roResp6.ContentType)
159+
require.Nil(t, roResp6.ContentType)
164160
require.NotNil(t, roResp6.Value)
165161
require.NotNil(t, roResp6.IsReadOnly)
166162
require.Equal(t, key, *roResp6.Key)
167163
require.Equal(t, label, *roResp6.Label)
168-
require.Equal(t, contentType, *roResp6.ContentType)
169164
require.Equal(t, value, *roResp6.Value)
170165
require.False(t, *roResp6.IsReadOnly)
171166

@@ -179,7 +174,6 @@ func TestClient(t *testing.T) {
179174
require.NotEmpty(t, revResp)
180175
require.Equal(t, key, *revResp.Settings[0].Key)
181176
require.Equal(t, label, *revResp.Settings[0].Label)
182-
require.Equal(t, contentType, *revResp.Settings[0].ContentType)
183177

184178
settsPgr := client.NewListSettingsPager(SettingSelector{KeyFilter: &any, LabelFilter: &any, Fields: AllSettingFields()}, nil)
185179
require.NotEmpty(t, settsPgr)
@@ -190,7 +184,6 @@ func TestClient(t *testing.T) {
190184
require.NotEmpty(t, settsResp)
191185
require.Equal(t, key, *settsResp.Settings[0].Key)
192186
require.Equal(t, label, *settsResp.Settings[0].Label)
193-
require.Equal(t, contentType, *settsResp.Settings[0].ContentType)
194187
require.Equal(t, value, *settsResp.Settings[0].Value)
195188
require.False(t, *settsResp.Settings[0].IsReadOnly)
196189

@@ -199,14 +192,13 @@ func TestClient(t *testing.T) {
199192
require.NotEmpty(t, delResp)
200193
require.NotNil(t, delResp.Key)
201194
require.NotNil(t, delResp.Label)
202-
require.NotNil(t, delResp.ContentType)
195+
require.Nil(t, delResp.ContentType)
203196
require.NotNil(t, delResp.Value)
204197
require.Equal(t, key, *delResp.Key)
205198
require.Equal(t, label, *delResp.Label)
206-
require.Equal(t, contentType, *delResp.ContentType)
207199
require.Equal(t, value, *delResp.Value)
208200

209-
addResp2, err18 := client.AddSetting(context.TODO(), key, &value, &AddSettingOptions{Label: &label})
201+
addResp2, err18 := client.AddSetting(context.TODO(), key, &value, &AddSettingOptions{Label: &label, ContentType: &contentType})
210202
require.NoError(t, err18)
211203
require.NotEmpty(t, addResp2)
212204
require.NotNil(t, addResp2.Key)

0 commit comments

Comments
 (0)