Skip to content

Commit 6027bec

Browse files
authored
test generation should align with code generation flag (Azure#19831)
* test generation should align with code generation flag * add flags in build.go * upgrade gotest version * Update build.go
1 parent cfc268e commit 6027bec

File tree

5 files changed

+9
-12
lines changed

5 files changed

+9
-12
lines changed

eng/scripts/Invoke-MgmtTestgen.ps1

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ param(
99
[switch]$cleanGenerated,
1010
[switch]$format,
1111
[switch]$tidy,
12-
[switch]$alwaysSetBodyParamRequired,
1312
[string]$config,
1413
[string]$autorestVersion,
1514
[string]$goExtension,

eng/scripts/MgmtTestLib.ps1

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,11 @@ function Invoke-MgmtTestgen ()
1616
[switch]$cleanGenerated,
1717
[switch]$format,
1818
[switch]$tidy,
19-
[switch]$alwaysSetBodyParamRequired,
20-
[switch]$removeUnreferencedTypes,
2119
[string]$autorestPath = "",
2220
[string]$config = "autorest.md",
2321
[string]$autorestVersion = "3.8.2",
2422
[string]$goExtension = "@autorest/go@4.0.0-preview.45",
25-
[string]$testExtension = "@autorest/gotest@4.5.1",
23+
[string]$testExtension = "@autorest/gotest@4.5.2",
2624
[string]$outputFolder
2725
)
2826
if ($clean)
@@ -63,14 +61,14 @@ function Invoke-MgmtTestgen ()
6361
$mockTestFlag = "false"
6462
}
6563

66-
$honorBodyPlacement = "false"
67-
if (-not $alwaysSetBodyParamRequired)
64+
$honorBodyPlacement = "true"
65+
if (Get-ChildItem "build.go" | Select-String -Pattern "alwaysSetBodyParamRequired")
6866
{
69-
$honorBodyPlacement = "true"
67+
$honorBodyPlacement = "false"
7068
}
7169

7270
$removeUnreferencedTypesFlag = "false"
73-
if ($removeUnreferencedTypes)
71+
if (Get-ChildItem "build.go" | Select-String -Pattern "removeUnreferencedTypes")
7472
{
7573
$removeUnreferencedTypesFlag = "true"
7674
}
@@ -378,4 +376,4 @@ function ExecuteSingleTest($sdk, $needRunMockServer = $true)
378376
{
379377
StopMockServer
380378
}
381-
}
379+
}

sdk/resourcemanager/dashboard/armdashboard/build.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
// Licensed under the MIT License. See License.txt in the project root for license information.
33

44
// This file enables 'go generate' to regenerate this specific SDK
5-
//go:generate pwsh ../../../../eng/scripts/build.ps1 -skipBuild -cleanGenerated -format -tidy -generate resourcemanager/dashboard/armdashboard
5+
//go:generate pwsh ../../../../eng/scripts/build.ps1 -skipBuild -cleanGenerated -format -tidy -generate -alwaysSetBodyParamRequired resourcemanager/dashboard/armdashboard
66

77
package armdashboard

sdk/resourcemanager/storagecache/armstoragecache/build.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
// Licensed under the MIT License. See License.txt in the project root for license information.
33

44
// This file enables 'go generate' to regenerate this specific SDK
5-
//go:generate pwsh ../../../../eng/scripts/build.ps1 -skipBuild -cleanGenerated -format -tidy -generate resourcemanager/storagecache/armstoragecache
5+
//go:generate pwsh ../../../../eng/scripts/build.ps1 -skipBuild -cleanGenerated -format -tidy -generate -alwaysSetBodyParamRequired resourcemanager/storagecache/armstoragecache
66

77
package armstoragecache

sdk/resourcemanager/workloads/armworkloads/build.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
// Licensed under the MIT License. See License.txt in the project root for license information.
33

44
// This file enables 'go generate' to regenerate this specific SDK
5-
//go:generate pwsh ../../../../eng/scripts/build.ps1 -skipBuild -cleanGenerated -format -tidy -generate resourcemanager/workloads/armworkloads
5+
//go:generate pwsh ../../../../eng/scripts/build.ps1 -skipBuild -cleanGenerated -format -tidy -generate -alwaysSetBodyParamRequired resourcemanager/workloads/armworkloads
66

77
package armworkloads

0 commit comments

Comments
 (0)