feat: change logic of fetching previous version's exports (Azure#17691)

Author: tadelesh

eng/tools/generator/cmd/v2/common/changlogProcessor.go

@@ -0,0 +1,137 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+package common
+
+import (
+	"encoding/json"
+	"fmt"
+	"io/ioutil"
+	"log"
+	"net/http"
+	"path"
+	"sort"
+	"strings"
+
+	"github.com/Azure/azure-sdk-for-go/eng/tools/generator/repo"
+	"github.com/Azure/azure-sdk-for-go/eng/tools/internal/exports"
+	"github.com/go-git/go-git/v5/plumbing"
+)
+
+const (
+	sdk_tag_fetch_url = "https://api.github.com/repos/Azure/azure-sdk-for-go/git/refs/tags"
+)
+
+func GetAllVersionTags(rpName, namespaceName string) ([]string, error) {
+	log.Printf("Fetching all release tags from GitHub for RP: '%s' Package: '%s' ...", rpName, namespaceName)
+	client := http.Client{}
+	res, err := client.Get(sdk_tag_fetch_url)
+	if err != nil {
+		return nil, err
+	}
+	body, err := ioutil.ReadAll(res.Body)
+	if err != nil {
+		return nil, err
+	}
+	result := []map[string]interface{}{}
+	err = json.Unmarshal(body, &result)
+	if err != nil {
+		return nil, err
+	}
+	var tags []string
+	for _, tag := range result {
+		tagName := tag["ref"].(string)
+		if strings.Contains(tagName, "sdk/resourcemanager/"+rpName+"/"+namespaceName) {
+			tags = append(tags, tag["ref"].(string))
+		}
+	}
+	sort.Sort(sort.Reverse(sort.StringSlice(tags)))
+
+	return tags, nil
+}
+
+func GetCurrentAPIVersion(packagePath string) (string, error) {
+	log.Printf("Get current release API version from '%s' ...", packagePath)
+
+	files, err := ioutil.ReadDir(packagePath)
+	if err != nil {
+		return "", err
+	}
+
+	for _, file := range files {
+		if strings.HasSuffix(file.Name(), ".go") {
+			b, err := ioutil.ReadFile(path.Join(packagePath, file.Name()))
+			if err != nil {
+				return "", err
+			}
+
+			lines := strings.Split(string(b), "\n")
+			for _, line := range lines {
+				if strings.Contains(line, "api-version") {
+					return strings.Split(line, "\"")[3], nil
+				}
+			}
+		}
+	}
+
+	return "", fmt.Errorf("Cannot find API version for current release")
+}
+
+func GetPreviousVersionTag(apiVersion string, allReleases []string) string {
+	if strings.Contains(apiVersion, "preview") {
+		// for preview api, always compare with latest release
+		return allReleases[0]
+	} else {
+		// for stable api, always compare with previous stable, if no stable, then latest release
+		for _, release := range allReleases {
+			if !strings.Contains(release, "beta") {
+				return release
+			}
+		}
+		return allReleases[0]
+	}
+}
+
+func GetExportsFromTag(sdkRepo repo.SDKRepository, packagePath, tag string) (*exports.Content, error) {
+	log.Printf("Get exports from specific tag '%s' ...", tag)
+
+	// get current head branch name
+	currentRef, err := sdkRepo.Head()
+	if err != nil {
+		return nil, err
+	}
+
+	// stash current change
+	err = sdkRepo.Stash()
+	if err != nil {
+		return nil, err
+	}
+
+	// checkout to the specific tag
+	err = sdkRepo.CheckoutTag(strings.TrimPrefix(tag, "ref/tags/"))
+	if err != nil {
+		return nil, err
+	}
+
+	// get exports
+	result, err := exports.Get(packagePath)
+	if err != nil {
+		return nil, err
+	}
+
+	// checkout back to head branch
+	err = sdkRepo.Checkout(&repo.CheckoutOptions{
+		Branch: plumbing.ReferenceName(currentRef.Name()),
+	})
+	if err != nil {
+		return nil, err
+	}
+
+	// restore current change
+	err = sdkRepo.StashPop()
+	if err != nil {
+		return nil, err
+	}
+
+	return &result, nil
+}

eng/tools/generator/cmd/v2/common/fileProcessor.go

@@ -11,6 +11,7 @@ import (
 	"path"
 	"path/filepath"
 	"regexp"
+	"strconv"
 	"strings"
 	"time"
 
@@ -239,8 +240,8 @@ func ReplaceVersion(packageRootPath string, newVersion string) error {
 }
 
 // calculate new version by changelog using semver package
-func CalculateNewVersion(changelog *model.Changelog, packageRootPath string) (*semver.Version, error) {
-	version, err := GetLatestVersion(packageRootPath)
+func CalculateNewVersion(changelog *model.Changelog, previousVersion string, isCurrentPreview bool) (*semver.Version, error) {
+	version, err := semver.NewVersion(previousVersion)
 	if err != nil {
 		return nil, err
 	}
@@ -255,13 +256,41 @@ func CalculateNewVersion(changelog *model.Changelog, packageRootPath string) (*s
 			newVersion = version.IncPatch()
 		}
 	} else {
-		// release version calculation
-		if changelog.HasBreakingChanges() {
-			newVersion = version.IncMajor()
-		} else if changelog.Modified.HasAdditiveChanges() {
-			newVersion = version.IncMinor()
+		if isCurrentPreview {
+			if strings.Contains(previousVersion, "beta") {
+				betaNumber, err := strconv.Atoi(strings.Split(version.Prerelease(), "beta.")[1])
+				if err != nil {
+					return nil, err
+				}
+				newVersion, err = version.SetPrerelease("beta." + strconv.Itoa(betaNumber+1))
+				if err != nil {
+					return nil, err
+				}
+			} else {
+				if changelog.HasBreakingChanges() {
+					newVersion = version.IncMajor()
+				} else if changelog.Modified.HasAdditiveChanges() {
+					newVersion = version.IncMinor()
+				} else {
+					newVersion = version.IncPatch()
+				}
+				newVersion, err = newVersion.SetPrerelease("beta.1")
+				if err != nil {
+					return nil, err
+				}
+			}
 		} else {
-			newVersion = version.IncPatch()
+			if strings.Contains(previousVersion, "beta") {
+				return nil, fmt.Errorf("must have stable previous version")
+			}
+			// release version calculation
+			if changelog.HasBreakingChanges() {
+				newVersion = version.IncMajor()
+			} else if changelog.Modified.HasAdditiveChanges() {
+				newVersion = version.IncMinor()
+			} else {
+				newVersion = version.IncPatch()
+			}
 		}
 	}
 

eng/tools/generator/cmd/v2/common/fileProcessor_test.go

@@ -0,0 +1,110 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+package common
+
+import (
+	"testing"
+
+	"github.com/Azure/azure-sdk-for-go/eng/tools/generator/autorest/model"
+	"github.com/Azure/azure-sdk-for-go/eng/tools/internal/delta"
+	"github.com/Azure/azure-sdk-for-go/eng/tools/internal/exports"
+	"github.com/Azure/azure-sdk-for-go/eng/tools/internal/report"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestCalculateNewVersion(t *testing.T) {
+	fixChange := &model.Changelog{Modified: &report.Package{}}
+	breakingChange := &model.Changelog{RemovedPackage: true, Modified: &report.Package{}}
+	additiveChange := &model.Changelog{Modified: &report.Package{AdditiveChanges: &delta.Content{Content: exports.Content{Consts: map[string]exports.Const{"test": {}}}}}}
+
+	// previous 0.x.x
+	// fix with stable
+	newVersion, err := CalculateNewVersion(fixChange, "0.5.0", false)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "0.5.1")
+
+	// fix with beat
+	newVersion, err = CalculateNewVersion(fixChange, "0.5.0", true)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "0.5.1")
+
+	// breaking with stable
+	newVersion, err = CalculateNewVersion(breakingChange, "0.5.0", false)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "0.6.0")
+
+	// breaking with beta
+	newVersion, err = CalculateNewVersion(breakingChange, "0.5.0", true)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "0.6.0")
+
+	// additive with stable
+	newVersion, err = CalculateNewVersion(additiveChange, "0.5.0", false)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "0.6.0")
+
+	// additive with beta
+	newVersion, err = CalculateNewVersion(additiveChange, "0.5.0", true)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "0.6.0")
+
+	// previous 1.2.0
+	// fix with stable
+	newVersion, err = CalculateNewVersion(fixChange, "1.2.0", false)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "1.2.1")
+
+	// fix with beat
+	newVersion, err = CalculateNewVersion(fixChange, "1.2.0", true)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "1.2.1-beta.1")
+
+	// breaking with stable
+	newVersion, err = CalculateNewVersion(breakingChange, "1.2.0", false)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "2.0.0")
+
+	// breaking with beta
+	newVersion, err = CalculateNewVersion(breakingChange, "1.2.0", true)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "2.0.0-beta.1")
+
+	// additive with stable
+	newVersion, err = CalculateNewVersion(additiveChange, "1.2.0", false)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "1.3.0")
+
+	// additive with beta
+	newVersion, err = CalculateNewVersion(additiveChange, "1.2.0", true)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "1.3.0-beta.1")
+
+	// previous 1.2.0-beta.1
+	// fix with stable
+	newVersion, err = CalculateNewVersion(fixChange, "1.2.0-beta.1", false)
+	assert.NotEmpty(t, err)
+
+	// fix with beat
+	newVersion, err = CalculateNewVersion(fixChange, "1.2.0-beta.1", true)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "1.2.0-beta.2")
+
+	// breaking with stable
+	newVersion, err = CalculateNewVersion(breakingChange, "1.2.0-beta.1", false)
+	assert.NotEmpty(t, err)
+
+	// breaking with beta
+	newVersion, err = CalculateNewVersion(breakingChange, "1.2.0-beta.1", true)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "1.2.0-beta.2")
+
+	// additive with stable
+	newVersion, err = CalculateNewVersion(additiveChange, "1.2.0-beta.1", false)
+	assert.NotEmpty(t, err)
+
+	// additive with beta
+	newVersion, err = CalculateNewVersion(additiveChange, "1.2.0-beta.1", true)
+	assert.NoError(t, err)
+	assert.Equal(t, newVersion.String(), "1.2.0-beta.2")
+}