Skip to content

Commit 4b0d1c3

Browse files
tadeleshtadelesh
authored
upgrade core lib version for ACR preview (Azure#19950)
* upgrade core lib version * add basic config for live test * update test and recording to support live test * use mgmt. package to import images for test * fix live test env problem * fix env bug and run go mod tidy * add new line
1 parent 82c2aec commit 4b0d1c3

File tree

11 files changed

+288
-178
lines changed

11 files changed

+288
-178
lines changed

‎sdk/containers/azcontainerregistry/assets.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"AssetsRepo": "Azure/azure-sdk-assets",
33
"AssetsRepoPrefixPath": "go",
44
"TagPrefix": "go/containers/azcontainerregistry",
5-
"Tag": "go/containers/azcontainerregistry_c8ca813cd9"
5+
"Tag": "go/containers/azcontainerregistry_36bdeb68b8"
66
}

‎sdk/containers/azcontainerregistry/authentication_client_test.go‎

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,30 @@ package azcontainerregistry
88

99
import (
1010
"context"
11+
"github.com/Azure/azure-sdk-for-go/sdk/azcore/cloud"
1112
"github.com/Azure/azure-sdk-for-go/sdk/azcore/policy"
1213
"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
1314
"github.com/stretchr/testify/require"
15+
"reflect"
16+
"strings"
1417
"testing"
1518
)
1619

1720
func Test_authenticationClient_ExchangeAADAccessTokenForACRRefreshToken(t *testing.T) {
1821
startRecording(t)
19-
cred, options := getCredAndClientOptions(t)
20-
client := newAuthenticationClient("https://azacrlivetest.azurecr.io", &authenticationClientOptions{ClientOptions: options})
22+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
23+
client := newAuthenticationClient(endpoint, &authenticationClientOptions{ClientOptions: options})
2124
ctx := context.Background()
25+
if reflect.ValueOf(options.Cloud).IsZero() {
26+
options.Cloud = cloud.AzurePublic
27+
}
2228
accessToken, err := cred.GetToken(
2329
ctx,
2430
policy.TokenRequestOptions{
25-
Scopes: []string{"https://management.core.windows.net/.default"},
31+
Scopes: []string{options.Cloud.Services[ServiceName].Audience + "/.default"},
2632
})
2733
require.NoError(t, err)
28-
resp, err := client.ExchangeAADAccessTokenForACRRefreshToken(ctx, postContentSchemaGrantTypeAccessToken, "azacrlivetest.azurecr.io", &authenticationClientExchangeAADAccessTokenForACRRefreshTokenOptions{
34+
resp, err := client.ExchangeAADAccessTokenForACRRefreshToken(ctx, postContentSchemaGrantTypeAccessToken, strings.TrimPrefix(endpoint, "https://"), &authenticationClientExchangeAADAccessTokenForACRRefreshTokenOptions{
2935
AccessToken: &accessToken.Token,
3036
})
3137
require.NoError(t, err)
@@ -34,21 +40,24 @@ func Test_authenticationClient_ExchangeAADAccessTokenForACRRefreshToken(t *testi
3440

3541
func Test_authenticationClient_ExchangeACRRefreshTokenForACRAccessToken(t *testing.T) {
3642
startRecording(t)
37-
cred, options := getCredAndClientOptions(t)
38-
client := newAuthenticationClient("https://azacrlivetest.azurecr.io", &authenticationClientOptions{ClientOptions: options})
43+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
44+
client := newAuthenticationClient(endpoint, &authenticationClientOptions{ClientOptions: options})
3945
ctx := context.Background()
46+
if reflect.ValueOf(options.Cloud).IsZero() {
47+
options.Cloud = cloud.AzurePublic
48+
}
4049
accessToken, err := cred.GetToken(
4150
ctx,
4251
policy.TokenRequestOptions{
43-
Scopes: []string{"https://management.core.windows.net/.default"},
52+
Scopes: []string{options.Cloud.Services[ServiceName].Audience + "/.default"},
4453
})
4554
require.NoError(t, err)
46-
refreshResp, err := client.ExchangeAADAccessTokenForACRRefreshToken(ctx, postContentSchemaGrantTypeAccessToken, "azacrlivetest.azurecr.io", &authenticationClientExchangeAADAccessTokenForACRRefreshTokenOptions{
55+
refreshResp, err := client.ExchangeAADAccessTokenForACRRefreshToken(ctx, postContentSchemaGrantTypeAccessToken, strings.TrimPrefix(endpoint, "https://"), &authenticationClientExchangeAADAccessTokenForACRRefreshTokenOptions{
4756
AccessToken: &accessToken.Token,
4857
})
4958
require.NoError(t, err)
5059
require.NotEmpty(t, *refreshResp.acrRefreshToken.RefreshToken)
51-
accessResp, err := client.ExchangeACRRefreshTokenForACRAccessToken(ctx, "azacrlivetest.azurecr.io", "registry:catalog:*", *refreshResp.acrRefreshToken.RefreshToken, &authenticationClientExchangeACRRefreshTokenForACRAccessTokenOptions{GrantType: to.Ptr(tokenGrantTypeRefreshToken)})
60+
accessResp, err := client.ExchangeACRRefreshTokenForACRAccessToken(ctx, strings.TrimPrefix(endpoint, "https://"), "registry:catalog:*", *refreshResp.acrRefreshToken.RefreshToken, &authenticationClientExchangeACRRefreshTokenForACRAccessTokenOptions{GrantType: to.Ptr(tokenGrantTypeRefreshToken)})
5261
require.NoError(t, err)
5362
require.NotEmpty(t, *accessResp.acrAccessToken.AccessToken)
5463
}

‎sdk/containers/azcontainerregistry/authentication_policy_test.go‎

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,14 @@ package azcontainerregistry
99
import (
1010
"context"
1111
"fmt"
12+
"github.com/Azure/azure-sdk-for-go/sdk/azcore/cloud"
1213
"github.com/Azure/azure-sdk-for-go/sdk/azcore/runtime"
1314
"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
1415
"github.com/Azure/azure-sdk-for-go/sdk/internal/temporal"
1516
"github.com/stretchr/testify/require"
1617
"net/http"
18+
"reflect"
19+
"strings"
1720
"testing"
1821
"time"
1922
)
@@ -109,14 +112,17 @@ func Test_authenticationPolicy_findServiceAndScope(t *testing.T) {
109112

110113
func Test_authenticationPolicy_getAccessToken_live(t *testing.T) {
111114
startRecording(t)
112-
cred, options := getCredAndClientOptions(t)
113-
authClient := newAuthenticationClient("https://azacrlivetest.azurecr.io", &authenticationClientOptions{options})
115+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
116+
if reflect.ValueOf(options.Cloud).IsZero() {
117+
options.Cloud = cloud.AzurePublic
118+
}
119+
authClient := newAuthenticationClient(endpoint, &authenticationClientOptions{options})
114120
p := &authenticationPolicy{
115121
temporal.NewResource(acquire),
116122
cred,
117-
[]string{"https://management.core.windows.net/.default"},
123+
[]string{options.Cloud.Services[ServiceName].Audience + "/.default"},
118124
"registry:catalog:*",
119-
"azacrlivetest.azurecr.io",
125+
strings.TrimPrefix(endpoint, "https://"),
120126
authClient,
121127
}
122128
request, err := runtime.NewRequest(context.Background(), http.MethodGet, "https://test.com")
@@ -128,14 +134,14 @@ func Test_authenticationPolicy_getAccessToken_live(t *testing.T) {
128134

129135
func Test_authenticationPolicy_getAccessToken_live_anonymous(t *testing.T) {
130136
startRecording(t)
131-
_, options := getCredAndClientOptions(t)
132-
authClient := newAuthenticationClient("https://azacrlivetest.azurecr.io", &authenticationClientOptions{options})
137+
endpoint, _, options := getEndpointCredAndClientOptions(t)
138+
authClient := newAuthenticationClient(endpoint, &authenticationClientOptions{options})
133139
p := &authenticationPolicy{
134140
temporal.NewResource(acquire),
135141
nil,
136142
nil,
137143
"registry:catalog:*",
138-
"azacrlivetest.azurecr.io",
144+
strings.TrimPrefix(endpoint, "https://"),
139145
authClient,
140146
}
141147
request, err := runtime.NewRequest(context.Background(), http.MethodGet, "https://test.com")
@@ -147,8 +153,8 @@ func Test_authenticationPolicy_getAccessToken_live_anonymous(t *testing.T) {
147153

148154
func Test_authenticationPolicy_anonymousAccess(t *testing.T) {
149155
startRecording(t)
150-
_, options := getCredAndClientOptions(t)
151-
client, err := NewClient("https://azacrlivetest.azurecr.io", nil, &ClientOptions{ClientOptions: options})
156+
endpoint, _, options := getEndpointCredAndClientOptions(t)
157+
client, err := NewClient(endpoint, nil, &ClientOptions{ClientOptions: options})
152158
require.NoError(t, err)
153159
ctx := context.Background()
154160
pager := client.NewListRepositoriesPager(nil)

‎sdk/containers/azcontainerregistry/blob_client_test.go‎

Lines changed: 39 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -17,52 +17,52 @@ import (
1717

1818
func TestBlobClient_CancelUpload(t *testing.T) {
1919
startRecording(t)
20-
cred, options := getCredAndClientOptions(t)
20+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
2121
ctx := context.Background()
22-
client, err := NewBlobClient("https://azacrlivetest.azurecr.io", cred, &BlobClientOptions{ClientOptions: options})
22+
client, err := NewBlobClient(endpoint, cred, &BlobClientOptions{ClientOptions: options})
2323
require.NoError(t, err)
24-
startRes, err := client.StartUpload(ctx, "hello-world-test", nil)
24+
startRes, err := client.StartUpload(ctx, "hello-world", nil)
2525
require.NoError(t, err)
2626
_, err = client.CancelUpload(ctx, *startRes.Location, nil)
2727
require.NoError(t, err)
2828
}
2929

3030
func TestBlobClient_CheckBlobExists(t *testing.T) {
3131
startRecording(t)
32-
cred, options := getCredAndClientOptions(t)
32+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
3333
ctx := context.Background()
34-
client, err := NewBlobClient("https://azacrlivetest.azurecr.io", cred, &BlobClientOptions{ClientOptions: options})
34+
client, err := NewBlobClient(endpoint, cred, &BlobClientOptions{ClientOptions: options})
3535
require.NoError(t, err)
36-
digest := "sha256:2db29710123e3e53a794f2694094b9b4338aa9ee5c40b930cb8063a1be392c54"
37-
res, err := client.CheckBlobExists(ctx, "hello-world", digest, nil)
36+
digest := "sha256:042a816809aac8d0f7d7cacac7965782ee2ecac3f21bcf9f24b1de1a7387b769"
37+
res, err := client.CheckBlobExists(ctx, "alpine", digest, nil)
3838
require.NoError(t, err)
3939
require.Equal(t, digest, *res.DockerContentDigest)
4040
}
4141

4242
func TestBlobClient_CheckChunkExists(t *testing.T) {
4343
startRecording(t)
44-
cred, options := getCredAndClientOptions(t)
44+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
4545
ctx := context.Background()
46-
client, err := NewBlobClient("https://azacrlivetest.azurecr.io", cred, &BlobClientOptions{ClientOptions: options})
46+
client, err := NewBlobClient(endpoint, cred, &BlobClientOptions{ClientOptions: options})
4747
require.NoError(t, err)
48-
digest := "sha256:2db29710123e3e53a794f2694094b9b4338aa9ee5c40b930cb8063a1be392c54"
49-
res, err := client.CheckChunkExists(ctx, "hello-world", digest, "bytes=0-299", nil)
48+
digest := "sha256:042a816809aac8d0f7d7cacac7965782ee2ecac3f21bcf9f24b1de1a7387b769"
49+
res, err := client.CheckChunkExists(ctx, "alpine", digest, "bytes=0-299", nil)
5050
require.NoError(t, err)
5151
require.NotEmpty(t, *res.ContentLength)
5252
}
5353

5454
func TestBlobClient_completeUpload_wrongDigest(t *testing.T) {
5555
startRecording(t)
56-
cred, options := getCredAndClientOptions(t)
56+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
5757
ctx := context.Background()
58-
client, err := NewBlobClient("https://azacrlivetest.azurecr.io", cred, &BlobClientOptions{ClientOptions: options})
58+
client, err := NewBlobClient(endpoint, cred, &BlobClientOptions{ClientOptions: options})
5959
require.NoError(t, err)
60-
digest := "sha256:2db29710123e3e53a794f2694094b9b4338aa9ee5c40b930cb8063a1be392c54"
61-
getRes, err := client.GetBlob(ctx, "hello-world", digest, nil)
60+
digest := "sha256:042a816809aac8d0f7d7cacac7965782ee2ecac3f21bcf9f24b1de1a7387b769"
61+
getRes, err := client.GetBlob(ctx, "alpine", digest, nil)
6262
require.NoError(t, err)
6363
blob, err := io.ReadAll(getRes.BlobData)
6464
require.NoError(t, err)
65-
startRes, err := client.StartUpload(ctx, "hello-world-test", nil)
65+
startRes, err := client.StartUpload(ctx, "hello-world", nil)
6666
require.NoError(t, err)
6767
uploadResp, err := client.uploadChunk(ctx, *startRes.Location, streaming.NopCloser(bytes.NewReader(blob)), nil)
6868
require.NoError(t, err)
@@ -72,46 +72,46 @@ func TestBlobClient_completeUpload_wrongDigest(t *testing.T) {
7272

7373
func TestBlobClient_DeleteBlob(t *testing.T) {
7474
startRecording(t)
75-
cred, options := getCredAndClientOptions(t)
75+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
7676
ctx := context.Background()
77-
client, err := NewBlobClient("https://azacrlivetest.azurecr.io", cred, &BlobClientOptions{ClientOptions: options})
77+
client, err := NewBlobClient(endpoint, cred, &BlobClientOptions{ClientOptions: options})
7878
require.NoError(t, err)
79-
digest := "sha256:2db29710123e3e53a794f2694094b9b4338aa9ee5c40b930cb8063a1be392c54"
80-
_, err = client.DeleteBlob(ctx, "hello-world-test", digest, nil)
79+
digest := "sha256:042a816809aac8d0f7d7cacac7965782ee2ecac3f21bcf9f24b1de1a7387b769"
80+
_, err = client.DeleteBlob(ctx, "alpine", digest, nil)
8181
require.NoError(t, err)
8282
}
8383

8484
func TestBlobClient_GetBlob(t *testing.T) {
8585
startRecording(t)
86-
cred, options := getCredAndClientOptions(t)
86+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
8787
ctx := context.Background()
88-
client, err := NewBlobClient("https://azacrlivetest.azurecr.io", cred, &BlobClientOptions{ClientOptions: options})
88+
client, err := NewBlobClient(endpoint, cred, &BlobClientOptions{ClientOptions: options})
8989
require.NoError(t, err)
90-
digest := "sha256:2db29710123e3e53a794f2694094b9b4338aa9ee5c40b930cb8063a1be392c54"
91-
res, err := client.GetBlob(ctx, "hello-world", digest, nil)
90+
digest := "sha256:042a816809aac8d0f7d7cacac7965782ee2ecac3f21bcf9f24b1de1a7387b769"
91+
res, err := client.GetBlob(ctx, "alpine", digest, nil)
9292
require.NoError(t, err)
9393
require.NotEmpty(t, *res.ContentLength)
9494
}
9595

9696
func TestBlobClient_GetChunk(t *testing.T) {
9797
startRecording(t)
98-
cred, options := getCredAndClientOptions(t)
98+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
9999
ctx := context.Background()
100-
client, err := NewBlobClient("https://azacrlivetest.azurecr.io", cred, &BlobClientOptions{ClientOptions: options})
100+
client, err := NewBlobClient(endpoint, cred, &BlobClientOptions{ClientOptions: options})
101101
require.NoError(t, err)
102-
digest := "sha256:feac5306138255e28a9862d3f3d29025d0a4d0648855afe1acd6131af07138ac"
103-
res, err := client.GetChunk(ctx, "ubuntu", digest, "bytes=0-1000", nil)
102+
digest := "sha256:042a816809aac8d0f7d7cacac7965782ee2ecac3f21bcf9f24b1de1a7387b769"
103+
res, err := client.GetChunk(ctx, "alpine", digest, "bytes=0-999", nil)
104104
require.NoError(t, err)
105-
require.NotEmpty(t, *res.ContentLength)
105+
require.Equal(t, *res.ContentLength, int64(1000))
106106
}
107107

108108
func TestBlobClient_GetUploadStatus(t *testing.T) {
109109
startRecording(t)
110-
cred, options := getCredAndClientOptions(t)
110+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
111111
ctx := context.Background()
112-
client, err := NewBlobClient("https://azacrlivetest.azurecr.io", cred, &BlobClientOptions{ClientOptions: options})
112+
client, err := NewBlobClient(endpoint, cred, &BlobClientOptions{ClientOptions: options})
113113
require.NoError(t, err)
114-
startRes, err := client.StartUpload(ctx, "hello-world-test", nil)
114+
startRes, err := client.StartUpload(ctx, "hello-world", nil)
115115
require.NoError(t, err)
116116
checkResp, err := client.GetUploadStatus(ctx, *startRes.Location, nil)
117117
require.NoError(t, err)
@@ -122,23 +122,23 @@ func TestBlobClient_GetUploadStatus(t *testing.T) {
122122

123123
func TestBlobClient_MountBlob(t *testing.T) {
124124
startRecording(t)
125-
cred, options := getCredAndClientOptions(t)
125+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
126126
ctx := context.Background()
127-
client, err := NewBlobClient("https://azacrlivetest.azurecr.io", cred, &BlobClientOptions{ClientOptions: options})
127+
client, err := NewBlobClient(endpoint, cred, &BlobClientOptions{ClientOptions: options})
128128
require.NoError(t, err)
129-
digest := "sha256:2db29710123e3e53a794f2694094b9b4338aa9ee5c40b930cb8063a1be392c54"
130-
res, err := client.MountBlob(ctx, "hello-world", "hello-world-test", digest, nil)
129+
digest := "sha256:042a816809aac8d0f7d7cacac7965782ee2ecac3f21bcf9f24b1de1a7387b769"
130+
res, err := client.MountBlob(ctx, "hello-world", "alpine", digest, nil)
131131
require.NoError(t, err)
132132
require.NotEmpty(t, res.Location)
133133
}
134134

135135
func TestBlobClient_StartUpload(t *testing.T) {
136136
startRecording(t)
137-
cred, options := getCredAndClientOptions(t)
137+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
138138
ctx := context.Background()
139-
client, err := NewBlobClient("https://azacrlivetest.azurecr.io", cred, &BlobClientOptions{ClientOptions: options})
139+
client, err := NewBlobClient(endpoint, cred, &BlobClientOptions{ClientOptions: options})
140140
require.NoError(t, err)
141-
startRes, err := client.StartUpload(ctx, "hello-world-test", nil)
141+
startRes, err := client.StartUpload(ctx, "hello-world", nil)
142142
require.NoError(t, err)
143143
require.NotEmpty(t, *startRes.Location)
144144
_, err = client.CancelUpload(ctx, *startRes.Location, nil)

‎sdk/containers/azcontainerregistry/blob_custom_client_test.go‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,16 @@ import (
1919

2020
func TestBlobClient_CompleteUpload(t *testing.T) {
2121
startRecording(t)
22-
cred, options := getCredAndClientOptions(t)
22+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
2323
ctx := context.Background()
24-
client, err := NewBlobClient("https://azacrlivetest.azurecr.io", cred, &BlobClientOptions{ClientOptions: options})
24+
client, err := NewBlobClient(endpoint, cred, &BlobClientOptions{ClientOptions: options})
2525
require.NoError(t, err)
26-
digest := "sha256:2db29710123e3e53a794f2694094b9b4338aa9ee5c40b930cb8063a1be392c54"
27-
getRes, err := client.GetBlob(ctx, "hello-world", digest, nil)
26+
digest := "sha256:042a816809aac8d0f7d7cacac7965782ee2ecac3f21bcf9f24b1de1a7387b769"
27+
getRes, err := client.GetBlob(ctx, "alpine", digest, nil)
2828
require.NoError(t, err)
2929
blob, err := io.ReadAll(getRes.BlobData)
3030
require.NoError(t, err)
31-
startRes, err := client.StartUpload(ctx, "hello-world-test", nil)
31+
startRes, err := client.StartUpload(ctx, "hello-world", nil)
3232
require.NoError(t, err)
3333
calculator := NewBlobDigestCalculator()
3434
uploadResp, err := client.UploadChunk(ctx, *startRes.Location, bytes.NewReader(blob), calculator, nil)
@@ -40,16 +40,16 @@ func TestBlobClient_CompleteUpload(t *testing.T) {
4040

4141
func TestBlobClient_UploadChunk(t *testing.T) {
4242
startRecording(t)
43-
cred, options := getCredAndClientOptions(t)
43+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
4444
ctx := context.Background()
45-
client, err := NewBlobClient("https://azacrlivetest.azurecr.io", cred, &BlobClientOptions{ClientOptions: options})
45+
client, err := NewBlobClient(endpoint, cred, &BlobClientOptions{ClientOptions: options})
4646
require.NoError(t, err)
47-
digest := "sha256:2db29710123e3e53a794f2694094b9b4338aa9ee5c40b930cb8063a1be392c54"
48-
getRes, err := client.GetBlob(ctx, "hello-world", digest, nil)
47+
digest := "sha256:042a816809aac8d0f7d7cacac7965782ee2ecac3f21bcf9f24b1de1a7387b769"
48+
getRes, err := client.GetBlob(ctx, "alpine", digest, nil)
4949
require.NoError(t, err)
5050
blob, err := io.ReadAll(getRes.BlobData)
5151
require.NoError(t, err)
52-
startRes, err := client.StartUpload(ctx, "hello-world-test", nil)
52+
startRes, err := client.StartUpload(ctx, "hello-world", nil)
5353
require.NoError(t, err)
5454
calculator := NewBlobDigestCalculator()
5555
uploadResp, err := client.UploadChunk(ctx, *startRes.Location, bytes.NewReader(blob), calculator, nil)
@@ -61,16 +61,16 @@ func TestBlobClient_UploadChunk(t *testing.T) {
6161

6262
func TestBlobClient_CompleteUpload_uploadByChunk(t *testing.T) {
6363
startRecording(t)
64-
cred, options := getCredAndClientOptions(t)
64+
endpoint, cred, options := getEndpointCredAndClientOptions(t)
6565
ctx := context.Background()
66-
client, err := NewBlobClient("https://azacrlivetest.azurecr.io", cred, &BlobClientOptions{ClientOptions: options})
66+
client, err := NewBlobClient(endpoint, cred, &BlobClientOptions{ClientOptions: options})
6767
require.NoError(t, err)
68-
digest := "sha256:2db29710123e3e53a794f2694094b9b4338aa9ee5c40b930cb8063a1be392c54"
69-
getRes, err := client.GetBlob(ctx, "hello-world", digest, nil)
68+
digest := "sha256:042a816809aac8d0f7d7cacac7965782ee2ecac3f21bcf9f24b1de1a7387b769"
69+
getRes, err := client.GetBlob(ctx, "alpine", digest, nil)
7070
require.NoError(t, err)
7171
blob, err := io.ReadAll(getRes.BlobData)
7272
require.NoError(t, err)
73-
startRes, err := client.StartUpload(ctx, "hello-world-test", nil)
73+
startRes, err := client.StartUpload(ctx, "hello-world", nil)
7474
require.NoError(t, err)
7575
calculator := NewBlobDigestCalculator()
7676
oriReader := bytes.NewReader(blob)

‎sdk/containers/azcontainerregistry/ci.yml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,9 @@ stages:
2626
parameters:
2727
ServiceDirectory: 'containers/azcontainerregistry'
2828
RunLiveTests: true
29+
SupportedClouds: 'Public,UsGov,China'
30+
EnvVars:
31+
AZURE_CLIENT_ID: $(AZCONTAINERREGISTRY_CLIENT_ID)
32+
AZURE_TENANT_ID: $(AZCONTAINERREGISTRY_TENANT_ID)
33+
AZURE_CLIENT_SECRET: $(AZCONTAINERREGISTRY_CLIENT_SECRET)
34+
AZURE_SUBSCRIPTION_ID: $(AZCONTAINERREGISTRY_SUBSCRIPTION_ID)

0 commit comments

Comments
 (0)