[keyvault] update azkeys (old) to api version 7.4 (Azure#20518)

* update autorest

* update to 7.4

Author: gracewilcox

sdk/keyvault/azkeys/CHANGELOG.md

@@ -3,8 +3,10 @@
 ## 0.9.1 (Unreleased)
 
 ### Features Added
+* Upgraded to api version 7.4
 
 ### Breaking Changes
+* Renamed `ActionType` to `KeyRotationPolicyAction`
 
 ### Bugs Fixed
 

sdk/keyvault/azkeys/autorest.md

@@ -4,15 +4,15 @@
 clear-output-folder: false
 export-clients: true
 go: true
-input-file: https://github.com/Azure/azure-rest-api-specs/blob/323a8c3fabad74fe18f4202926b8fd826551a7ce/specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.3/keys.json
+input-file: https://github.com/Azure/azure-rest-api-specs/blob/551275acb80e1f8b39036b79dfc35a8f63b601a7/specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.4/keys.json
 license-header: MICROSOFT_MIT_NO_VERSION
 module: github.com/Azure/azure-sdk-for-go/sdk/keyvault/azkeys
 openapi-type: "data-plane"
 output-folder: ../azkeys
 override-client-name: Client
 security: "AADToken"
 security-scopes: "https://vault.azure.net/.default"
-use: "@autorest/go@4.0.0-preview.43"
+use: "@autorest/go@4.0.0-preview.46"
 version: "^3.0.0"
 
 directive:
@@ -102,11 +102,6 @@ directive:
     where: $
     transform: return $.replace(/(?:\/\/.*\s)+func \(a \*?Attributes\).*\{\s(?:.+\s)+\}\s/g, "");
 
-  # delete generated constructor
-  - from: client.go
-    where: $
-    transform: return $.replace(/(?:\/\/.*\s)+func NewClient.+\{\s(?:.+\s)+\}\s/, "");
-
   # delete the version path param check (version == "" is legal for Key Vault but indescribable by OpenAPI)
   - from: client.go
     where: $

sdk/keyvault/azkeys/build.go

@@ -2,6 +2,7 @@
 // +build go1.18
 
 //go:generate autorest ./autorest.md
+//go:generate gofmt -w .
 
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.

sdk/keyvault/azkeys/client.go

@@ -635,7 +635,7 @@ func TestRotateKey(t *testing.T) {
 				LifetimeActions: []*azkeys.LifetimeActions{
 					{
 						Action: &azkeys.LifetimeActionsType{
-							Type: to.Ptr(azkeys.ActionTypeRotate),
+							Type: to.Ptr(azkeys.KeyRotationPolicyActionRotate),
 						},
 						Trigger: &azkeys.LifetimeActionsTrigger{
 							TimeAfterCreate: timeAfterCreate,
@@ -653,7 +653,7 @@ func TestRotateKey(t *testing.T) {
 			require.NotEmpty(t, getResp.LifetimeActions)
 			require.Condition(t, func() bool {
 				for _, action := range getResp.LifetimeActions {
-					if strings.EqualFold(string(*action.Action.Type), string(azkeys.ActionTypeRotate)) && strings.EqualFold(string(*action.Trigger.TimeAfterCreate), *timeAfterCreate) {
+					if strings.EqualFold(string(*action.Action.Type), string(azkeys.KeyRotationPolicyActionRotate)) && strings.EqualFold(string(*action.Trigger.TimeAfterCreate), *timeAfterCreate) {
 						return true
 					}
 				}

sdk/keyvault/azkeys/client_test.go

@@ -37,8 +37,11 @@ func NewClient(vaultURL string, credential azcore.TokenCredential, options *Clie
 			DisableChallengeResourceVerification: options.DisableChallengeResourceVerification,
 		},
 	)
-	pl := runtime.NewPipeline(moduleName, version, runtime.PipelineOptions{PerRetry: []policy.Policy{authPolicy}}, &options.ClientOptions)
-	return &Client{endpoint: vaultURL, pl: pl}, nil
+	azcoreClient, err := azcore.NewClient("azkeys.Client", version, runtime.PipelineOptions{PerRetry: []policy.Policy{authPolicy}}, &options.ClientOptions)
+	if err != nil {
+		return nil, err
+	}
+	return &Client{endpoint: vaultURL, internal: azcoreClient}, nil
 }
 
 // ID is a key's unique ID, containing its version, if any, and name.

sdk/keyvault/azkeys/constants.go

@@ -126,7 +126,7 @@ func ExampleClient_UpdateKeyRotationPolicy() {
 		LifetimeActions: []*azkeys.LifetimeActions{
 			{
 				Action: &azkeys.LifetimeActionsType{
-					Type: to.Ptr(azkeys.ActionTypeRotate),
+					Type: to.Ptr(azkeys.KeyRotationPolicyActionRotate),
 				},
 				Trigger: &azkeys.LifetimeActionsTrigger{
 					TimeAfterCreate: to.Ptr("P18M"),