Skip to content

Commit 380d05a

Browse files
azure-sdkbenbp
andauthored
Fix regression - base name overrides in CI (Azure#20563)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
1 parent 4bdfb89 commit 380d05a

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

eng/common/TestResources/SubConfig-Helpers.ps1

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,12 @@ function GetBaseAndResourceGroupNames(
2323
[string]$serviceDirectoryName,
2424
[bool]$CI
2525
) {
26+
if ($baseNameDefault) {
27+
$base = $baseNameDefault.ToLowerInvariant()
28+
$group = $resourceGroupNameDefault ? $resourceGroupNameDefault : ("rg-$baseNameDefault".ToLowerInvariant())
29+
return $base, $group
30+
}
31+
2632
if ($CI) {
2733
$base = 't' + (New-Guid).ToString('n').Substring(0, 16)
2834
# Format the resource group name based on resource group naming recommendations and limitations.
@@ -37,12 +43,6 @@ function GetBaseAndResourceGroupNames(
3743
return $base, $group
3844
}
3945

40-
if ($baseNameDefault) {
41-
$base = $baseNameDefault.ToLowerInvariant()
42-
$group = $resourceGroupNameDefault ? $resourceGroupNameDefault : ("rg-$baseNameDefault".ToLowerInvariant())
43-
return $base, $group
44-
}
45-
4646
# Handle service directories in nested directories, e.g. `data/aztables`
4747
$serviceDirectorySafeName = $serviceDirectoryName -replace '[\./\\]', ''
4848
# Seed off resource group name if set to avoid name conflicts with deployments where it is not set

0 commit comments

Comments
 (0)