Skip to content

Commit 09e1d3d

Browse files
authored
1 parent 1faa82f commit 09e1d3d

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

eng/tools/generator/cmd/v2/common/fileProcessor.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,10 @@ func CalculateNewVersion(changelog *model.Changelog, previousVersion string, isC
287287
} else {
288288
prl = FirstGALabel
289289
}
290-
} else if changelog.HasBreakingChanges() || changelog.Modified.HasAdditiveChanges() {
290+
} else if changelog.HasBreakingChanges() {
291+
newVersion = version.IncMinor()
292+
prl = BetaBreakingChangeLabel
293+
} else if changelog.Modified.HasAdditiveChanges() {
291294
newVersion = version.IncMinor()
292295
prl = BetaLabel
293296
} else {

eng/tools/generator/cmd/v2/common/fileProcessor_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ func TestCalculateNewVersion(t *testing.T) {
4141
newVersion, prl, err = CalculateNewVersion(breakingChange, "0.5.0", true)
4242
assert.NoError(t, err)
4343
assert.Equal(t, newVersion.String(), "0.6.0")
44-
assert.Equal(t, BetaLabel, prl)
44+
assert.Equal(t, BetaBreakingChangeLabel, prl)
4545

4646
// additive with stable
4747
newVersion, prl, err = CalculateNewVersion(additiveChange, "0.5.0", false)

0 commit comments

Comments
 (0)