Skip to content

Commit 7d4bc91

Browse files
author
Ziyue Zheng
authored
Remove Storage TestController (Azure#18470)
* Remove TestController * Update StorageBlobTests.cs * Update StorageTestRunner.cs * Update StorageTestRunner.cs
1 parent 6567757 commit 7d4bc91

File tree

5 files changed

+49
-188
lines changed

5 files changed

+49
-188
lines changed

src/Storage/Storage.Management.Test/ScenarioTests/StorageBlobTests.cs

Lines changed: 16 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -12,107 +12,101 @@
1212
// limitations under the License.
1313
// ----------------------------------------------------------------------------------
1414

15-
16-
using Microsoft.Azure.ServiceManagement.Common.Models;
1715
using Microsoft.WindowsAzure.Commands.ScenarioTest;
18-
using Microsoft.WindowsAzure.Commands.Test.Utilities.Common;
1916
using Xunit;
2017
using Xunit.Abstractions;
2118

2219
namespace Microsoft.Azure.Commands.Management.Storage.Test.ScenarioTests
2320
{
24-
public class StorageBlobTests : RMTestBase
21+
public class StorageBlobTests : StorageTestRunner
2522
{
26-
public XunitTracingInterceptor _logger;
27-
2823
public StorageBlobTests(ITestOutputHelper output)
24+
: base(output)
2925
{
30-
_logger = new XunitTracingInterceptor(output);
31-
XunitTracingInterceptor.AddToContext(_logger);
3226
}
3327

3428
[Fact]
3529
[Trait(Category.AcceptanceType, Category.CheckIn)]
3630
public void TestStorageBlobIsVersioningEnabled()
3731
{
38-
TestController.NewInstance.RunPsTest(_logger, "Test-StorageBlobIsVersioningEnabled");
32+
TestRunner.RunTestScript("Test-StorageBlobIsVersioningEnabled");
3933
}
4034

4135
[Fact]
4236
[Trait(Category.AcceptanceType, Category.CheckIn)]
4337
public void TestStorageBlobContainer()
4438
{
45-
TestController.NewInstance.RunPsTest(_logger, "Test-StorageBlobContainer");
39+
TestRunner.RunTestScript("Test-StorageBlobContainer");
4640
}
4741

4842
[Fact]
4943
[Trait(Category.AcceptanceType, Category.CheckIn)]
5044
public void TestStorageBlobContainerEncryptionScope()
5145
{
52-
TestController.NewInstance.RunPsTest(_logger, "Test-StorageBlobContainerEncryptionScope");
53-
}
46+
TestRunner.RunTestScript("Test-StorageBlobContainerEncryptionScope");
47+
}
5448

5549
[Fact]
5650
[Trait(Category.AcceptanceType, Category.CheckIn)]
5751
public void TestStorageBlobContainerLegalHold()
5852
{
59-
TestController.NewInstance.RunPsTest(_logger, "Test-StorageBlobContainerLegalHold");
53+
TestRunner.RunTestScript("Test-StorageBlobContainerLegalHold");
6054
}
6155

6256
[Fact]
6357
[Trait(Category.AcceptanceType, Category.CheckIn)]
6458
public void TestStorageBlobContainerImmutabilityPolicy()
6559
{
66-
TestController.NewInstance.RunPsTest(_logger, "Test-StorageBlobContainerImmutabilityPolicy");
60+
TestRunner.RunTestScript("Test-StorageBlobContainerImmutabilityPolicy");
6761
}
6862

6963
[Fact]
7064
[Trait(Category.AcceptanceType, Category.CheckIn)]
7165
public void TestStorageBlobServiceProperties()
7266
{
73-
TestController.NewInstance.RunPsTest(_logger, "Test-StorageBlobServiceProperties");
74-
}
67+
TestRunner.RunTestScript("Test-StorageBlobServiceProperties");
68+
}
7569

7670
[Fact]
7771
[Trait(Category.AcceptanceType, Category.CheckIn)]
7872
public void TestStorageBlobORS()
7973
{
80-
TestController.NewInstance.RunPsTest(_logger, "Test-StorageBlobORS");
74+
TestRunner.RunTestScript("Test-StorageBlobORS");
8175
}
8276

8377
[Fact]
8478
[Trait(Category.AcceptanceType, Category.CheckIn)]
8579
public void TestStorageBlobRestore()
8680
{
87-
TestController.NewInstance.RunPsTest(_logger, "Test-StorageBlobRestore");
81+
TestRunner.RunTestScript("Test-StorageBlobRestore");
8882
}
8983

9084
[Fact]
9185
[Trait(Category.AcceptanceType, Category.CheckIn)]
9286
public void TestStorageBlobChangeFeed()
9387
{
94-
TestController.NewInstance.RunPsTest(_logger, "Test-StorageBlobChangeFeed");
88+
TestRunner.RunTestScript("Test-StorageBlobChangeFeed");
9589
}
9690

9791
[Fact]
9892
[Trait(Category.AcceptanceType, Category.CheckIn)]
9993
public void TestStorageBlobContainerSoftDelete()
10094
{
101-
TestController.NewInstance.RunPsTest(_logger, "Test-StorageBlobContainerSoftDelete");
95+
TestRunner.RunTestScript("Test-StorageBlobContainerSoftDelete");
10296
}
10397

10498
[Fact]
10599
[Trait(Category.AcceptanceType, Category.CheckIn)]
106100
public void TestStorageBlobLastAccessTimeTracking()
107101
{
108-
TestController.NewInstance.RunPsTest(_logger, "Test-StorageBlobLastAccessTimeTracking");
102+
TestRunner.RunTestScript("Test-StorageBlobLastAccessTimeTracking");
109103
}
110104

111105
[Fact]
112106
[Trait(Category.AcceptanceType, Category.CheckIn)]
113107
public void TestStorageBlobContainerVLW()
114108
{
115-
TestController.NewInstance.RunPsTest(_logger, "Test-StorageBlobContainerVLW");
109+
TestRunner.RunTestScript("Test-StorageBlobContainerVLW");
116110
}
117111
}
118112
}

src/Storage/Storage.Management.Test/ScenarioTests/StorageDataPlaneTests.cs

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,83 +12,72 @@
1212
// limitations under the License.
1313
// ----------------------------------------------------------------------------------
1414

15-
using System;
16-
using System.Collections;
17-
using System.Collections.ObjectModel;
18-
using System.Management.Automation;
1915
using Xunit;
2016
using Xunit.Abstractions;
21-
using System.Diagnostics;
22-
using Microsoft.Azure.ServiceManagement.Common.Models;
2317
using Microsoft.WindowsAzure.Commands.ScenarioTest;
24-
using Microsoft.WindowsAzure.Commands.Test.Utilities.Common;
25-
using Microsoft.Azure.Management.Internal.Resources;
26-
using Microsoft.Azure.Management.Storage;
2718
using Microsoft.Rest.ClientRuntime.Azure.TestFramework;
2819

2920
namespace Microsoft.Azure.Commands.Management.Storage.Test.ScenarioTests
3021
{
31-
public class StorageDataPlaneTests : RMTestBase
22+
public class StorageDataPlaneTests : StorageTestRunner
3223
{
33-
public XunitTracingInterceptor _logger;
3424
private string resourceGroupName;
3525
private string storageAccountName;
3626

3727
public StorageDataPlaneTests(ITestOutputHelper output)
28+
: base(output)
3829
{
3930
resourceGroupName = TestUtilities.GenerateName();
4031
storageAccountName = "sto" + resourceGroupName;
41-
_logger = new XunitTracingInterceptor(output);
42-
XunitTracingInterceptor.AddToContext(_logger);
4332
}
4433

4534
[Fact]
4635
[Trait(Category.RunType, Category.LiveOnly)]
4736
public void TestBlob()
4837
{
49-
TestController.NewInstance.RunPsTest(_logger, $"Test-Blob -ResourceGroupName \"{resourceGroupName}\" -StorageAccountName \"{storageAccountName}\"");
38+
TestRunner.RunTestScript($"Test-Blob -ResourceGroupName \"{resourceGroupName}\" -StorageAccountName \"{storageAccountName}\"");
5039
}
5140

5241
[Fact]
5342
[Trait(Category.RunType, Category.LiveOnly)]
5443
public void TestFile()
5544
{
56-
TestController.NewInstance.RunPsTest(_logger, $"Test-File -ResourceGroupName \"{resourceGroupName}\" -StorageAccountName \"{storageAccountName}\"");
45+
TestRunner.RunTestScript($"Test-File -ResourceGroupName \"{resourceGroupName}\" -StorageAccountName \"{storageAccountName}\"");
5746
}
5847

5948
[Fact]
6049
[Trait(Category.RunType, Category.LiveOnly)]
6150
public void TestBlobFileCopy()
6251
{
63-
TestController.NewInstance.RunPsTest(_logger, $"Test-BlobFileCopy -ResourceGroupName \"{resourceGroupName}\" -StorageAccountName \"{storageAccountName}\"");
52+
TestRunner.RunTestScript($"Test-BlobFileCopy -ResourceGroupName \"{resourceGroupName}\" -StorageAccountName \"{storageAccountName}\"");
6453
}
6554

6655
[Fact]
6756
[Trait(Category.RunType, Category.LiveOnly)]
6857
public void TestTable()
6958
{
70-
TestController.NewInstance.RunPsTest(_logger, $"Test-Table -ResourceGroupName \"{resourceGroupName}\" -StorageAccountName \"{storageAccountName}\"");
59+
TestRunner.RunTestScript($"Test-Table -ResourceGroupName \"{resourceGroupName}\" -StorageAccountName \"{storageAccountName}\"");
7160
}
7261

7362
[Fact]
7463
[Trait(Category.RunType, Category.LiveOnly)]
7564
public void TestQueue()
7665
{
77-
TestController.NewInstance.RunPsTest(_logger, $"Test-Queue -ResourceGroupName \"{resourceGroupName}\" -StorageAccountName \"{storageAccountName}\"");
66+
TestRunner.RunTestScript($"Test-Queue -ResourceGroupName \"{resourceGroupName}\" -StorageAccountName \"{storageAccountName}\"");
7867
}
7968

8069
[Fact]
8170
[Trait(Category.RunType, Category.LiveOnly)]
8271
public void TestCommon()
8372
{
84-
TestController.NewInstance.RunPsTest(_logger, $"Test-Common -ResourceGroupName \"{resourceGroupName}\" -StorageAccountName \"{storageAccountName}\"");
73+
TestRunner.RunTestScript($"Test-Common -ResourceGroupName \"{resourceGroupName}\" -StorageAccountName \"{storageAccountName}\"");
8574
}
8675

8776
[Fact]
8877
[Trait(Category.RunType, Category.LiveOnly)]
8978
public void TestDatalakeGen2()
9079
{
91-
TestController.NewInstance.RunPsTest(_logger, $"Test-DatalakeGen2 -ResourceGroupName \"{resourceGroupName}\" -StorageAccountName \"{storageAccountName}\"");
80+
TestRunner.RunTestScript($"Test-DatalakeGen2 -ResourceGroupName \"{resourceGroupName}\" -StorageAccountName \"{storageAccountName}\"");
9281
}
9382
}
9483
}

src/Storage/Storage.Management.Test/ScenarioTests/StorageFileTests.cs

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -12,65 +12,59 @@
1212
// limitations under the License.
1313
// ----------------------------------------------------------------------------------
1414

15-
16-
using Microsoft.Azure.ServiceManagement.Common.Models;
1715
using Microsoft.WindowsAzure.Commands.ScenarioTest;
18-
using Microsoft.WindowsAzure.Commands.Test.Utilities.Common;
1916
using Xunit;
2017
using Xunit.Abstractions;
2118

2219
namespace Microsoft.Azure.Commands.Management.Storage.Test.ScenarioTests
2320
{
24-
public class StorageFileTests : RMTestBase
21+
public class StorageFileTests : StorageTestRunner
2522
{
26-
public XunitTracingInterceptor _logger;
27-
2823
public StorageFileTests(ITestOutputHelper output)
24+
: base(output)
2925
{
30-
_logger = new XunitTracingInterceptor(output);
31-
XunitTracingInterceptor.AddToContext(_logger);
3226
}
3327

3428
[Fact]
3529
[Trait(Category.AcceptanceType, Category.CheckIn)]
3630
public void TestStorageFileShare()
3731
{
38-
TestController.NewInstance.RunPsTest(_logger, "Test-StorageFileShare");
32+
TestRunner.RunTestScript("Test-StorageFileShare");
3933
}
4034

4135
[Fact]
4236
[Trait(Category.AcceptanceType, Category.CheckIn)]
4337
public void TestStorageFileShareGetUsage()
4438
{
45-
TestController.NewInstance.RunPsTest(_logger, "Test-StorageFileShareGetUsage");
39+
TestRunner.RunTestScript("Test-StorageFileShareGetUsage");
4640
}
4741

4842
[Fact]
4943
[Trait(Category.AcceptanceType, Category.CheckIn)]
5044
public void TestShareSoftDeletee()
5145
{
52-
TestController.NewInstance.RunPsTest(_logger, "Test-ShareSoftDelete");
46+
TestRunner.RunTestScript("Test-ShareSoftDelete");
5347
}
5448

5549
[Fact]
5650
[Trait(Category.AcceptanceType, Category.CheckIn)]
5751
public void TestShareSnapshot()
5852
{
59-
TestController.NewInstance.RunPsTest(_logger, "Test-ShareSnapshot");
53+
TestRunner.RunTestScript("Test-ShareSnapshot");
6054
}
6155

6256
[Fact]
6357
[Trait(Category.AcceptanceType, Category.CheckIn)]
6458
public void TestFileServiceProperties()
6559
{
66-
TestController.NewInstance.RunPsTest(_logger, "Test-FileServiceProperties");
60+
TestRunner.RunTestScript("Test-FileServiceProperties");
6761
}
6862

6963
[Fact]
7064
[Trait(Category.AcceptanceType, Category.CheckIn)]
7165
public void TestAzureStorageShareNFS()
7266
{
73-
TestController.NewInstance.RunPsTest(_logger, "Test-AzureStorageShareNFS");
74-
}
67+
TestRunner.RunTestScript("Test-AzureStorageShareNFS");
68+
}
7569
}
7670
}

src/Storage/Storage.Management.Test/ScenarioTests/StorageTestRunner.cs

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
// ----------------------------------------------------------------------------------
1414

1515
using Microsoft.Azure.Commands.TestFx;
16+
using System.Collections.Generic;
1617
using Xunit.Abstractions;
1718

1819
namespace Microsoft.Azure.Commands.Management.Storage.Test
@@ -28,13 +29,26 @@ protected StorageTestRunner(ITestOutputHelper output)
2829
.WithProjectSubfolderForTests("ScenarioTests")
2930
.WithCommonPsScripts(new[]
3031
{
31-
@"Common.ps1", @"../AzureRM.Resources.ps1"
32+
@"Common.ps1",
33+
@"../AzureRM.Resources.ps1"
3234
})
3335
.WithNewRmModules(helper => new[]
3436
{
3537
helper.RMProfileModule,
3638
helper.RMStorageModule
3739
})
40+
.WithNewRecordMatcherArguments(
41+
userAgentsToIgnore: new Dictionary<string, string>
42+
{
43+
{"Microsoft.Azure.Management.Resources.ResourceManagementClient", "2016-02-01"}
44+
},
45+
resourceProviders: new Dictionary<string, string>
46+
{
47+
{"Microsoft.Resources", null},
48+
{"Microsoft.Features", null},
49+
{"Microsoft.Authorization", null}
50+
}
51+
)
3852
.Build();
3953
}
4054
}

0 commit comments

Comments
 (0)