Skip to content

Commit b1f3aa8

Browse files
azat-ioazat-io
committed
feat: remove samples column from reports
1 parent 9ec3983 commit b1f3aa8

File tree

6 files changed

+30
-39
lines changed

6 files changed

+30
-39
lines changed

‎reporters/use-console-report.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import type { SystemInfo } from './collect-system-info'
55

66
import { collectSystemInfo } from './collect-system-info'
77
import { formatDeviation } from './format-deviation'
8-
import { formatNumber } from './format-number'
98
import { formatHz } from './format-hz'
109
import { formatMs } from './format-ms'
1110

@@ -23,7 +22,6 @@ const TABLE_HEADERS = [
2322
'Min',
2423
'Max',
2524
'StdDev',
26-
'Samples',
2725
]
2826

2927
const EMPTY_ROW_VALUES = [
@@ -34,7 +32,6 @@ const EMPTY_ROW_VALUES = [
3432
'N/A',
3533
'N/A',
3634
'N/A',
37-
'N/A',
3835
]
3936

4037
/**
@@ -103,7 +100,6 @@ let formatMetricsRow = (
103100
formatMs(sample.metrics.min),
104101
formatMs(sample.metrics.max),
105102
formatDeviation(sample.metrics.stdDev),
106-
formatNumber(sample.metrics.sampleCount),
107103
]
108104

109105
/**

‎reporters/use-markdown-report.ts‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import type { SystemInfo } from './collect-system-info'
44

55
import { collectSystemInfo } from './collect-system-info'
66
import { formatDeviation } from './format-deviation'
7-
import { formatNumber } from './format-number'
87
import { formatMs } from './format-ms'
98
import { formatHz } from './format-hz'
109

@@ -80,15 +79,13 @@ export let useMarkdownReport = async (
8079
let tableRows: string[] = []
8180

8281
tableRows.push(
83-
'| Sample | Ops/sec | Avg Time | Median | Min | Max | StdDev | Samples |',
84-
'| ------ | ------- | -------- | ------ | --- | --- | ------ | ------- |',
82+
'| Sample | Ops/sec | Avg Time | Median | Min | Max | StdDev |',
83+
'| ------ | ------- | -------- | ------ | --- | --- | ------ |',
8584
)
8685

8786
for (let testCaseResult of testSpecResult.testCaseResults) {
8887
if (testCaseResult.samplesResults.length === 0) {
89-
tableRows.push(
90-
`| No samples | N/A | N/A | N/A | N/A | N/A | N/A | N/A |`,
91-
)
88+
tableRows.push(`| No samples | N/A | N/A | N/A | N/A | N/A | N/A |`)
9289
continue
9390
}
9491

@@ -105,7 +102,6 @@ export let useMarkdownReport = async (
105102
formatMs(sampleResult.metrics.min),
106103
formatMs(sampleResult.metrics.max),
107104
formatDeviation(sampleResult.metrics.stdDev),
108-
formatNumber(sampleResult.metrics.sampleCount),
109105
]
110106

111107
tableRows.push(`| ${rowData.join(' | ')} |`)

‎test/reporters/__snapshots__/use-console-report.test.ts.snap‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,19 @@
22

33
exports[`useConsoleReport > handles multiple test specifications with proper spacing 1`] = `
44
"
5-
--------------------------------------------------------------------------------------------------
6-
Rule: no-negated-conjunction
7-
--------------------------------------------------------------------------------------------------
8-
Sample | Ops/sec | Avg Time | Median | Min | Max | StdDev | Samples
9-
base-case.ts | 17,896 ops/sec | 0.056 ms | 0.055 ms | 0.052 ms | 0.063 ms | ±0.002 ms | 37,011
10-
complex-case.ts | 17,973 ops/sec | 0.056 ms | 0.055 ms | 0.053 ms | 0.062 ms | ±0.002 ms | 32,886
11-
--------------------------------------------------------------------------------------------------
12-
--------------------------------------------------------------------------------------------------
13-
Rule: no-negated-disjunction
14-
--------------------------------------------------------------------------------------------------
15-
Sample | Ops/sec | Avg Time | Median | Min | Max | StdDev | Samples
16-
base-case.ts | 17,941 ops/sec | 0.056 ms | 0.055 ms | 0.053 ms | 0.063 ms | ±0.002 ms | 34,813
17-
--------------------------------------------------------------------------------------------------
5+
----------------------------------------------------------------------------------------
6+
Rule: no-negated-conjunction
7+
----------------------------------------------------------------------------------------
8+
Sample | Ops/sec | Avg Time | Median | Min | Max | StdDev
9+
base-case.ts | 17,896 ops/sec | 0.056 ms | 0.055 ms | 0.052 ms | 0.063 ms | ±0.002 ms
10+
complex-case.ts | 17,973 ops/sec | 0.056 ms | 0.055 ms | 0.053 ms | 0.062 ms | ±0.002 ms
11+
----------------------------------------------------------------------------------------
12+
----------------------------------------------------------------------------------------
13+
Rule: no-negated-disjunction
14+
----------------------------------------------------------------------------------------
15+
Sample | Ops/sec | Avg Time | Median | Min | Max | StdDev
16+
base-case.ts | 17,941 ops/sec | 0.056 ms | 0.055 ms | 0.053 ms | 0.063 ms | ±0.002 ms
17+
----------------------------------------------------------------------------------------
1818
1919
System Information:
2020

‎test/reporters/__snapshots__/use-markdown-report.test.ts.snap‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@ exports[`useMarkdownReport > handles multiple test specifications 1`] = `
55
66
### Rule: no-negated-conjunction
77
8-
| Sample | Ops/sec | Avg Time | Median | Min | Max | StdDev | Samples |
9-
| ------ | ------- | -------- | ------ | --- | --- | ------ | ------- |
10-
| base-case.ts | 17,896 ops/sec | 0.056 ms | 0.055 ms | 0.052 ms | 0.063 ms | ±0.002 ms | 37,011 |
11-
| complex-case.ts | 17,973 ops/sec | 0.056 ms | 0.055 ms | 0.053 ms | 0.062 ms | ±0.002 ms | 32,886 |
8+
| Sample | Ops/sec | Avg Time | Median | Min | Max | StdDev |
9+
| ------ | ------- | -------- | ------ | --- | --- | ------ |
10+
| base-case.ts | 17,896 ops/sec | 0.056 ms | 0.055 ms | 0.052 ms | 0.063 ms | ±0.002 ms |
11+
| complex-case.ts | 17,973 ops/sec | 0.056 ms | 0.055 ms | 0.053 ms | 0.062 ms | ±0.002 ms |
1212
1313
1414
### Rule: no-negated-disjunction
1515
16-
| Sample | Ops/sec | Avg Time | Median | Min | Max | StdDev | Samples |
17-
| ------ | ------- | -------- | ------ | --- | --- | ------ | ------- |
18-
| base-case.ts | 17,941 ops/sec | 0.056 ms | 0.055 ms | 0.053 ms | 0.063 ms | ±0.002 ms | 34,813 |
16+
| Sample | Ops/sec | Avg Time | Median | Min | Max | StdDev |
17+
| ------ | ------- | -------- | ------ | --- | --- | ------ |
18+
| base-case.ts | 17,941 ops/sec | 0.056 ms | 0.055 ms | 0.053 ms | 0.063 ms | ±0.002 ms |
1919
2020
### System Information
2121

‎test/reporters/use-console-report.test.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ describe('useConsoleReport', () => {
182182
expect(consoleOutput).toContain('Min')
183183
expect(consoleOutput).toContain('Max')
184184
expect(consoleOutput).toContain('StdDev')
185-
expect(consoleOutput).toContain('Samples')
186185

187186
expect(consoleOutput).toContain('sampleA.js')
188187
expect(consoleOutput).toContain('1,000 ops/sec')
@@ -439,7 +438,7 @@ describe('useConsoleReport', () => {
439438

440439
for (let line of dataLines) {
441440
let columns = line.split('|').map(col => col.trim())
442-
expect(columns.filter(col => col.length > 0)).toHaveLength(8)
441+
expect(columns.filter(col => col.length > 0)).toHaveLength(7)
443442
}
444443
})
445444
})

‎test/reporters/use-markdown-report.test.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -180,16 +180,16 @@ describe('useMarkdownReport', () => {
180180
expect(markdownOutput).toContain('# ESLint Rule Benchmark Report')
181181
expect(markdownOutput).toContain('## My Rule Benchmarks')
182182
expect(markdownOutput).toContain(
183-
'| Sample | Ops/sec | Avg Time | Median | Min | Max | StdDev | Samples |',
183+
'| Sample | Ops/sec | Avg Time | Median | Min | Max | StdDev |',
184184
)
185185
expect(markdownOutput).toContain(
186-
'| ------ | ------- | -------- | ------ | --- | --- | ------ | ------- |',
186+
'| ------ | ------- | -------- | ------ | --- | --- | ------ |',
187187
)
188188
expect(markdownOutput).toContain(
189-
'| sampleA.js | 1,000 ops/sec | 1.000 ms | 0.900 ms | 0.800 ms | 1.200 ms | ±0.050 ms | 10 |',
189+
'| sampleA.js | 1,000 ops/sec | 1.000 ms | 0.900 ms | 0.800 ms | 1.200 ms | ±0.050 ms |',
190190
)
191191
expect(markdownOutput).toContain(
192-
'| sampleB.js | 500 ops/sec | 2.000 ms | 1.900 ms | 0.800 ms | 1.200 ms | ±0.050 ms | 10 |',
192+
'| sampleB.js | 500 ops/sec | 2.000 ms | 1.900 ms | 0.800 ms | 1.200 ms | ±0.050 ms |',
193193
)
194194
expect(markdownOutput).not.toContain('Test Specification:')
195195
expect(markdownOutput).not.toContain('Rule ID:')
@@ -309,7 +309,7 @@ describe('useMarkdownReport', () => {
309309
)
310310

311311
expect(markdownOutput).toContain(
312-
'| No samples | N/A | N/A | N/A | N/A | N/A | N/A | N/A |',
312+
'| No samples | N/A | N/A | N/A | N/A | N/A | N/A |',
313313
)
314314
})
315315

@@ -355,7 +355,7 @@ describe('useMarkdownReport', () => {
355355
)
356356

357357
expect(markdownOutput).toContain(
358-
'| Invalid metrics sample | N/A | N/A | N/A | N/A | N/A | N/A | 0 |',
358+
'| Invalid metrics sample | N/A | N/A | N/A | N/A | N/A | N/A |',
359359
)
360360
})
361361
})

0 commit comments

Comments
 (0)